[HOLD for payment 2024-08-09] [$250] "Leave" option icon should have "exit" icon instead of "thread" icon

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721922103779509

Action Performed:

1. Go to workspace list
2. Click 3 dot menu of the workspace where user is not an admin

Expected Result:

We should be using the exit icon for the "leave" option on workspaces

Actual Result:

Now it is a leave thread icon

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df4ffa2e8434c8ce
• Upwork Job ID: 1816829296583393158
• Last Price Increase: 2024-07-26

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Now it is a leave thread icon

What is the root cause of that problem?

We are using ChatBubbles in:

App/src/pages/workspace/WorkspacesListPage.tsx

Line 174 in 0559307

icon: Expensicons.ChatBubbles,

What changes do you think we should make in order to solve the problem?

Should use Exit icon in this, what we used in leave room:

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Leave" option icon should have "exit" icon instead of "thread" icon

What is the root cause of that problem?

We are setting the ChatBubbles icon here

App/src/pages/workspace/WorkspacesListPage.tsx

Line 173 in b0f810d

icon: Expensicons.ChatBubbles,

What changes do you think we should make in order to solve the problem?

We should change it to

                    icon: Expensicons.Exit,

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df4ffa2e8434c8ce

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[mollfpr]

The proposal from @daledah looks good to me!

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@mollfpr this PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: change icon ChatBubble to Exit #46396

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#35671

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/35671/files#r1706528957

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

We already have the checklist for UI changes and it is still good.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to the workspace list
2. Click 3 dot menu of the workspace where the user is not an admin
3. Verify that: The Exit icon is displayed instead of the ChatBubbles icon
4. 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mollfpr owed $250 via NewDot
• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@anmurali)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1816829296583393158/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@francoisl, @anmurali, @mollfpr, @daledah Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

@daledah - can you pls link me your Upwork profile?

[daledah]

@anmurali Here it is https://www.upwork.com/freelancers/~0138d999529f34d33f

[melvin-bot]

@francoisl, @anmurali, @mollfpr, @daledah Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@francoisl, @anmurali, @mollfpr, @daledah 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mollfpr]

@anmurali Could you give the payment summary? Thank you!

[melvin-bot]

@francoisl, @anmurali, @mollfpr, @daledah 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@francoisl, @anmurali, @mollfpr, @daledah 12 days overdue. Walking. Toward. The. Light...

[anmurali]

Payment summary

• @daledah - offer is here https://www.upwork.com/nx/wm/offer/103712361
• @mollfpr - approved $250 on New Dot

[daledah]

@anmurali Thanks, offer accepted

[anmurali]

@mollfpr feel free to request via New Dot.

[garrettmknight]

$250 approved for @mollfpr