[Awaiting checklist] [$250] [MEDIUM] Allow non-admins to set Workspace Address on newDot when attempting to Book Travel

[twisterdotcom]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @twisterdotcom
Slack conversation:

Action Performed:

1. Ensure you're added to the spotnanaTravel beta
2. Create a new Workspace (becoming an Admin) as a user without access to Expensify Travel yet
3. Invite an employee to that Workspace
4. Sign in as the employee
5. Tap "Book Travel"
6. Accept Terms and Conditions

Expected Result:

Anyone booking travel for the first time should be able to set the Workspace address regardless of role. Thus enabling to them to book trips. This works on oldDot: https://github.com/Expensify/Expensify/issues/404079

Actual Result:

See an error.

Workaround:

Have an admin set the Workspace address

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01398cd8d50461c00a
• Upwork Job ID: 1816865684699873550
• Last Price Increase: 2024-07-26
• Automatic offers:
• shubham1206agra | Contributor | 103281647

Issue Owner

Current Issue Owner: @twisterdotcom

cc @deetergp, @rushatgabhane, @shubham1206agra

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01398cd8d50461c00a

[melvin-bot]

Current assignee @twisterdotcom is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[twisterdotcom]

Assigning @shubham1206agra as he's done most of the C+ work for Travel @parasharrajat.

[ShridharGoel]

@twisterdotcom @shubham1206agra I'm getting 400 bad request on https://api-ext-sboxmeta.partners.spotnana.com/v2/auth/token/companies even though I have the beta enabled and a token is getting generated. This is happening even on the account which is the owner of workspace (I'm not sure if the 'book travel' option is even connected to a workspace?)

[rushatgabhane]

@twisterdotcom i'd like to work on this

If activePolicyID.address is empty, we will navigate the user to policy address page - /settings/workspaces/policyID/profile/address

All done in ManageTrips page.

[rushatgabhane]

PR here #46333

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Set workspace address when attempting to Book Travel #46333

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Payment Summary:

• @rushatgabhane paid $250 via NewDot Manual Request
• @shubham1206agra paid $250 here (Contributor)

[shubham1206agra]

@twisterdotcom Accepted offer

[twisterdotcom]

Paid!

[twisterdotcom]

This is a new feature, so not going to go with a checklist here.

[JmillsExpensify]

$250 approved for @rushatgabhane