Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expenses - Submit button appears and immediately disappears after expense is posted #46872

Closed
6 tasks done
lanitochka17 opened this issue Aug 6, 2024 · 8 comments
Closed
6 tasks done
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4818052
Email or phone of affected tester (no customers): fischer9966+080524aemp@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  1. Login as the admin and create Collect workspace
  2. Navigate to the collect workspace settings > More features > Enable workflows
  3. Navigate to workflows > Enable Approvals
  4. Enable delay submissions and set it to Manually
  5. Invite a new user with Gmail account as an employee
    Steps:
  6. Login as the employee account in ND
  7. Navigate to the workspace chat
  8. Submit expense to the workspace for >100$
  9. Verify a "Submit" button is displayed

Expected Result:

"Submit" button is displayed for expense after the employee posted it

Actual Result:

"Submit" button appears and immediately disappears after the employee posted expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563043_1722921717371.Android-Submit-Expense-Button-dissappear.mp4
Bug6563043_1722921717369.Web-Submit-Expense-dissappear.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@rlinoz
Copy link
Contributor

rlinoz commented Aug 6, 2024

This is caused by this PR: https://github.com/Expensify/Web-Expensify/pull/42976/files#diff-7e2d65062b3d1b62158a39b82faabb6666d1fc9a64abe64404c94c374208fb56 which is now sending reimbursable to Auth, but we don't always send reimbursable from the App.

@rlinoz
Copy link
Contributor

rlinoz commented Aug 6, 2024

Fixing on Web-E, so removing the App deploy blocker.

@rlinoz rlinoz removed the DeployBlockerCash This issue or pull request should block deployment label Aug 6, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Aug 6, 2024

@kavimuru
Copy link

kavimuru commented Aug 6, 2024

Now Submit button appears. After tap it blinks, but there are no errors.

iOS-Collect-Submit-Button.mp4

@rlinoz rlinoz added Daily KSv2 and removed DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Aug 6, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Aug 7, 2024

The PR is deployed to prod, so closing.

@rlinoz rlinoz closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants