Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-08-06 #46849

Closed
83 tasks done
github-actions bot opened this issue Aug 6, 2024 · 18 comments
Closed
83 tasks done

Deploy Checklist: New Expensify 2024-08-06 #46849

github-actions bot opened this issue Aug 6, 2024 · 18 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Release Version: 9.0.17-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Aug 6, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2024

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.17-0 🚀

@rlinoz
Copy link
Contributor

rlinoz commented Aug 6, 2024

Fixing #46872 on Web-E

@roryabraham
Copy link
Contributor

Demoting #46877

@mvtglobally
Copy link

Regression is at 12% left on High/Critical TCs and 100% on Low/Med

Open Blockers
#46874
#46909

@marcaaron
Copy link
Contributor

Checking off #46874 as we CP'd a fix for that

@marcaaron
Copy link
Contributor

Checking off #46929 as it is an internal tool.

@trjExpensify
Copy link
Contributor

Demoting #46949 (comment). Known minor design issue.

@trjExpensify
Copy link
Contributor

Demoting #46954, dupe detection is behind a beta.

@trjExpensify
Copy link
Contributor

Demoting #46952 (comment), p2p distance is behind a beta.

@trjExpensify
Copy link
Contributor

Demoting #46957 (comment), another related to rate that's behind the p2p distance beta. (CC: @neil-marcellini, seeing quite a few of these coming up.)

@mvtglobally
Copy link

mvtglobally commented Aug 7, 2024

Regression is at 40% Med/Low TC left

Blockers #46963

PRs
#40021 is failing #46873, #46879
#43163 is failing #46879
#46165 is pending validation on all platforms
#46487 is failing #45935
#46557 is failing #46872
#46629 is failing #46876
#46654 is failing #46872
#46721 is failing #46896

@trjExpensify
Copy link
Contributor

#46971 (comment) demoted because Book travel in NewDot is behind a beta.

Checked off #46963 as we CP'd a fix to staging for it here: #46978

@marcaaron
Copy link
Contributor

Looks like we are good to check off #46972 as well.

@trjExpensify
Copy link
Contributor

Closed #46987 (comment) Plaid doesn't support Fidelity, not on us.

@marcaaron
Copy link
Contributor

App timings looking slightly better today:

2024-08-07_10-04-23

Still discussing in this thread, but shouldn't block today's deploy.

@marcaaron
Copy link
Contributor

There is one fresh crash here but IMO does not look concerning.

@mvtglobally
Copy link

Regression is completed

PRs
#40021 is failing #46873, #46879
#43163 is failing #46879. Repro in PROD checking off
#46165 is failing #46874. blocker removed. ok to check off?
#46333 is failing with #46971. blocker removed. ok to check off?
#46487 is failing #45935. repro in PROD.checking off
#46557 is failing #46872. issue is closed. checking off
#46629 is failing #46876
#46654 is failing #46872. issue is closed. checking off
#46721 is failing #46896. repro in PROD checking off
#46833 (comment) - Can we check this off?

@marcaaron
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants