Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task – Blue border appears around task details header if delete task using Enter key #46875

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 6, 2024 · 5 comments
Closed
1 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4825048
Email or phone of affected tester (no customers): applausetester+jp_e_category_2@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Click on FAB and select Assign task
  4. Assign task to you and share to another user
  5. Open task details
  6. Send a message
  7. Click on header and select detete
  8. On confirmation modal click Enter key to delete the task

Expected Result:

Blue border not appears around task details header

Actual Result:

Blue border appears around task details header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563119_1722930689249.Blue_delete_task.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@pecanoro pecanoro removed the DeployBlocker Indicates it should block deploying the API label Aug 6, 2024
@pecanoro
Copy link
Contributor

pecanoro commented Aug 6, 2024

This is only reproducible if you click on the delete modal before clicking enter. I also think this is probably expected since I think we were trying to fix that the right hand modal was staying opened after deleting.

@pecanoro pecanoro removed the DeployBlockerCash This issue or pull request should block deployment label Aug 6, 2024
@pecanoro
Copy link
Contributor

pecanoro commented Aug 6, 2024

I am going to close since that blue border is just the focus and I don't think it's worth investing time on it as it's a super edge case

@pecanoro pecanoro closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants