IOU - Hold option is missing on employee, approver and owner side

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+workspaceapprover155@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #46721

Action Performed:

Precondition:

1. Workspace has an approver (can be workspace owner)
2. Employee submits 2 expenses on workspace chat
3. As approver, open thread transaction of one of the expenses
4. Click on workspace chat header
5. Check present options on the modal

Expected Result:

Hold option should be present

Actual Result:

Hold option is not present on transaction details page, so user can not hold the expense
Hold option is missing on employee, approver and owner side

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563461_1722954964361.Recording__3650.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

I can reproduce this, I think this might already be a known issue but I'm not sure if it needs to be internal.

https://expensify.slack.com/archives/C036QM0SLJK/p1722958894237379

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold option is missing on employee, approver and owner side

What is the root cause of that problem?

It is not money request action. The code returns false for canHoldRequest.

App/src/libs/ReportUtils.ts

Lines 2901 to 2902 in 2c60fc9

	if (!ReportActionsUtils.isMoneyRequestAction(reportAction)) {
	return {canHoldRequest: false, canUnholdRequest: false};

What changes do you think we should make in order to solve the problem?

We can add a check for isReportPreviewAction.

 if (!ReportActionsUtils.isMoneyRequestAction(reportAction)&& !ReportActionsUtils.isReportPreviewAction(reportAction)) {
        return {canHoldRequest: false, canUnholdRequest: false};
    }

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

asking if this should be worked on as part of #46371

[cretadn22]

@Christinadobrzyn I can't reproduce this issue

Screen45.mov

[Christinadobrzyn]

Thanks for testing @cretadn22 - this does appear to be resolved. Asking QA to test again.

[Christinadobrzyn]

https://expensify.slack.com/archives/C9YU7BX5M/p1723149513879979

[kavimuru]

Bug is fixed.

Recording.3669.mp4

[Christinadobrzyn]

Awesome! Closing!