-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CRITICAL] Adjust <WorkspaceWorkflowsApprovalsApproverPage /> for Approver Selection #46510
[CRITICAL] Adjust <WorkspaceWorkflowsApprovalsApproverPage /> for Approver Selection #46510
Conversation
To push things forward I opened the PR without videos, I'm sick and will add them later. @suneox please have a look at the PR 😄 |
@blazejkustra Sure, how can I access the document to get more context? I’ve requested access docs via email |
I shared it with you 🚀 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-02.at.22.18.09.mp4Android: mWeb ChromeScreen.Recording.2024-08-02.at.22.16.48.mp4iOS: NativeScreen.Recording.2024-08-02.at.22.06.49.mp4iOS: mWeb SafariScreen.Recording.2024-08-02.at.22.00.31.mp4MacOS: Chrome / SafariScreen.Recording.2024-08-02.at.21.56.00.mp4MacOS: DesktopScreen.Recording.2024-08-02.at.22.04.15.mp4 |
src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected on all platforms, and the change set LGTM
return <WorkspaceWorkflowsApprovalsApproverPageOld {...props} />; | ||
} | ||
|
||
function WorkspaceWorkflowsApprovalsApproverPageNew({policy, personalDetails, isLoadingReportData = true, route}: WorkspaceWorkflowsApprovalsApproverPageProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind changing the name of this component to WorkspaceWorkflowsApprovalsApproverPageBeta
and I would just keep the name of the "old" component the way it was before. The only reason is that "new" and "old" hold no meaning once this PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.17-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀
|
2 similar comments
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀
|
Details
Link to the doc.
UI changes
WorkspaceWorkflowsApprovalsApproverPage
is split into two components:WorkspaceWorkflowsApprovalsApproverPageNew
- The new refreshed UI with logic changes, this variant is displayed only whencanUseWorkflowsAdvancedApproval
beta is turned on +approverIndex
screen param has to be provided.WorkspaceWorkflowsApprovalsApproverPageOld
- The old screen left for backward compatibility, it will be displayed for the old flow:Onyx actions:
Clicking on an approver will set the approver with
setApprovalWorkflowApprover
action (more info in the Onyx setup section) and navigate to the ‘Create approval’ page (‘settings/workspaces/:policyID/workflows/approvals/new’
) or ‘Edit approval’ page (‘settings/workspaces/:policyID/workflows/approvals/:firstApproverEmail/edit’
) based onisBeingEdited
property in Onyx.Fixed Issues
$ #45955
PROPOSAL: N/A
Tests
More features
settings page)canUseWorkflowsAdvancedApproval
function to return true (or usecanUseWorkflowsAdvancedApproval
beta)Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.webm
Android: mWeb Chrome
android-web.webm
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-08-02.at.09.09.38.mov
MacOS: Desktop
desktop.mov