Distance - System message contains blank info when submitting expense and editing rate offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

• Workspace has a few distance rates

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Go offline
4. Submit a distance expense
5. Go to transaction thread
6. Click Rate
7. Select a different rate

Expected Result:

The system message should only appear after returning online as it contains incorrect before and after amount - "which updated the amount to $0.00 (previously )"

Actual Result:

The system message is not accurate and contains blank info. It shows "which updated the amount to $0.00 (previously )". The previous amount is blank, the new amount is $0.00 which is also not accurate. The message should only appear after returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563402_1722951149936.20240806_212613.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to ##wave-collect - Release 1

[marcochavezf]

Seems this was introduced here and seems the Edit Rate is a new feature cc @neil-marcellini @paultsimura

[neil-marcellini]

Not a blocker, under the P2P distance beta. I agree with the expected result that the modified expense message shouldn't appear until we come back online.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[paultsimura]

@neil-marcellini please assign me and I'll prepare the PR today or early tomorrow

[paultsimura]

@neil-marcellini when updating waypoints, we do not add the optimistic MODIFIEDEXPENSE action while offline, because:

We don't create a modified report action if we're updating the waypoints, since there isn't actually any optimistic data we can create for them and the report action is created on the server with the response from the MapBox API

Currently, my thought process is to not add such action when modifying the rate if the distance is pending – this can be if the request was created offline, or the route was edited offline before the rate edit. Otherwise, it will always lack the amount & mileage data.

But maybe you'd want to consider not adding the optimistic action at all, similarly to the updating waypoints scenario.

[paultsimura]

@neil-marcellini bump on #46895 (comment)

[neil-marcellini]

Yeah that sounds good, we shouldn't create the optimistic action if we don't have the data to compute it, but we could create it if that data is present and we know it's not stale. The same could be done for the waypoints in some cases, but I think the author didn't want to bother with those edge cases.

I'm going to let @marcochavezf continue to manage this one internally since I really appreciate the extra help on these distance bugs. Please direct questions to him, but I'll be around if there's something you really need my opinion on.

[aimane-chnaif]

Not overdue

[paultsimura]

@aimane-chnaif the PR is ready: #47145

[paultsimura]

Deployed to production yesterday.
Payment is due 27 Aug.

[paultsimura]

@allroundexperts could you please fill out the BZ checklist? It's due payment today, but the automation failed.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[marcochavezf]

Hi @miljakljajic! Can you handle the payment for @paultsimura as contributor and @allroundexperts as C+ reviewer?

[miljakljajic]

@marcochavezf is this a 250 USD or 125 USD issue?

[marcochavezf]

250 please

[paultsimura]

Bump @miljakljajic 🙏

[allroundexperts]

Checklist

1. feat: Edit Distance Rate flow #40021
2. Author was aware of the issue and fixed it.
3. N/A
4. A regression test might be useful.

Regression test

1. Open the app and login to an account that has multiple distance rates available
2. Go offline and submit a distance expense to the workspace with multiple distance rates
3. Go to transaction thread -> click Rate -> select a different rate

Verify that the system message should only appear after returning online

Do we 👍 or 👎 ?

[miljakljajic]

Payment summary for @allroundexperts

@allroundexperts is owed 250 for their work reviewing this PR

@paultsimura paid in Upwork

[JmillsExpensify]

$250 approved for @allroundexperts