[HOLD for payment 2024-08-27] [$250] Expense - Copied content from report title system message is different from the system message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit an expense
4. Go to expense report
5. Click on the report header
6. Click Title
7. Edit the title and save it
8. Refresh the page
9. Right click on the report title system message > Copy to clipboard
10. Paste the content in the composer

Expected Result:

The copied content will be the same as the system message

Actual Result:

The copied content is different from the system message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563216_1722938498447.bandicam_2024-08-06_17-57-15-872.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018e6a5a151d252557
• Upwork Job ID: 1820881503609119225
• Last Price Increase: 2024-08-06
• Automatic offers:
• DylanDylann | Reviewer | 103505015

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[cristipaval]

This is the offending PR, but I wouldn't consider this a blocker TBH.

[abdulrahuman5196]

This is the offending PR, but I wouldn't consider this a blocker TBH.

I doubt if this is a regression from that particular PR. Because it only changed the usage with a common component. cc: @neonbhai What is your thoughts?

[roryabraham]

agreed in slack that this is NAB

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018e6a5a151d252557

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copied content of report name changed message is not same as displayed in chat.

What is the root cause of that problem?

We don't have condition for copying content related to RENAMED action in onPress handler.

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 366 to 371 in 6263c24

	onPress: (closePopover, {reportAction, transaction, selection, reportID}) => {
	const isReportPreviewAction = ReportActionsUtils.isReportPreviewAction(reportAction);
	const messageHtml = getActionHtml(reportAction);
	const messageText = ReportActionsUtils.getReportActionMessageText(reportAction);
	const isAttachment = ReportActionsUtils.isReportActionAttachment(reportAction);

We are getting result of -

const messageText = ReportActionsUtils.getReportActionMessageText(reportAction);

What changes do you think we should make in order to solve the problem?

1. We shall add check for renamed action with ReportActionsUtils.isRenamedAction(reportAction)
2. Add new method ReportActionsUtils.getRenamedActionMessage(), it will take reportAction as argument and return the required result. Its body will look like -

function getRenamedActionMessage(reportAction: OnyxEntry<ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.RENAMED>>): string {
    const initialMessage = getOriginalMessage(reportAction);
    return Localize.translateLocal('newRoomPage.renamedRoomAction', {
        oldName: initialMessage?.oldName ?? '',
        newName: initialMessage?.newName ?? '',
    })
}

result -

Screen.Recording.2024-08-07.at.12.27.39.AM.mov

What alternative solutions did you explore? (Optional)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The copied content is different from the system message

What is the root cause of that problem?

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 366 to 371 in 6263c24

	onPress: (closePopover, {reportAction, transaction, selection, reportID}) => {
	const isReportPreviewAction = ReportActionsUtils.isReportPreviewAction(reportAction);
	const messageHtml = getActionHtml(reportAction);
	const messageText = ReportActionsUtils.getReportActionMessageText(reportAction);
	const isAttachment = ReportActionsUtils.isReportActionAttachment(reportAction);

In ContextMenuAction, we specify the message for each message type. But we miss the RENAME type

What changes do you think we should make in order to solve the problem?

App/src/pages/home/report/ReportActionItem.tsx

Lines 662 to 667 in 8c11aa4

	} else if (ReportActionsUtils.isRenamedAction(action)) {
	const initialMessage = ReportActionsUtils.getOriginalMessage(action);
	const message = translate('newRoomPage.renamedRoomAction', {
	oldName: initialMessage?.oldName ?? '',
	newName: initialMessage?.newName ?? '',
	});

We need to make this code as a util function and using in three places: ReportActionItem, ContextMenuAction and LHN

App/src/libs/SidebarUtils.ts

Line 394 in 8c11aa4

if (ReportActionsUtils.isRenamedAction(lastAction)) {

App/src/pages/home/report/ReportActionItem.tsx

Lines 662 to 667 in 8c11aa4

	} else if (ReportActionsUtils.isRenamedAction(action)) {
	const initialMessage = ReportActionsUtils.getOriginalMessage(action);
	const message = translate('newRoomPage.renamedRoomAction', {
	oldName: initialMessage?.oldName ?? '',
	newName: initialMessage?.newName ?? '',
	});

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 366 to 371 in 6263c24

	onPress: (closePopover, {reportAction, transaction, selection, reportID}) => {
	const isReportPreviewAction = ReportActionsUtils.isReportPreviewAction(reportAction);
	const messageHtml = getActionHtml(reportAction);
	const messageText = ReportActionsUtils.getReportActionMessageText(reportAction);
	const isAttachment = ReportActionsUtils.isReportActionAttachment(reportAction);

What alternative solutions did you explore? (Optional)

NA

[DylanDylann]

Both proposals have the same RCA and working well, but I prefer to go with @daledah's proposal because his solution will make code cleaner and more consistent

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

@cristipaval, @stephanieelliott, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

[DylanDylann]

Not overdue. Waiting for @cristipaval to give the final decision

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[BhuvaneshPatil]

@cristipaval Please have a look at comments above and both proposal. For the main issue, both proposal mention the same solution and mine came first. And still not chosen on the point that it doesn't make code cleaner. I think this shouldn't be the basis of selecting proposal.

[daledah]

@DylanDylann This PR is ready for review.

[stephanieelliott]

Hey @DylanDylann looks like this PR is held on your review, can you take a look?

[stephanieelliott]

PR was deployed to prod today

[stephanieelliott]

Hm, this was deployed to prod on 8/20 but nothing updated. Will process payment today since it's exactly 7 days past

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @daledah $250 via Upwork -- PAID
• Contributor+: @DylanDylann $250 via Upwork -- PAID

Upwork job is here: https://www.upwork.com/jobs/~018e6a5a151d252557

[daledah]

can you link your Upwork profile please?

@stephanieelliott Here's my profile https://www.upwork.com/freelancers/~0138d999529f34d33f

[stephanieelliott]

Thanks @daledah! Extended an offer to you: https://www.upwork.com/nx/wm/offer/103743804

[daledah]

@stephanieelliott Accepted thx

[stephanieelliott]

All paid! Thanks