Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Uploading a receipt with >24MB freezes the app for a while #46882

Closed
2 of 6 tasks
m-natarajan opened this issue Aug 6, 2024 · 13 comments
Closed
2 of 6 tasks

IOU - Uploading a receipt with >24MB freezes the app for a while #46882

m-natarajan opened this issue Aug 6, 2024 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Aug 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating #45448
Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): nathanmulugetatesting+881@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Submit an expense to a user or a workspace
  3. Open the expense detail and click on the add receipt button
  4. Upload a picture with size > 24MB

Expected Result:

The app quickly closes the RHP and shows navigates to the expense details page (which is the behavior seen for smaller file sizes), or the app should show a loading spinner

Actual Result:

The app freezes for a while when reducing the file size and clicking on anything is not functional

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6563182_1722936352565.bandicam_2024-08-06_12-21-16-010.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@twisterdotcom
Copy link
Contributor

I agree this is an issue, but does it need to block the deploy or be hourly? @dangrous what do you think? This isn't a common flow, so I think we could make it just a daily bug.

I know @kidroca recently worked on uploading attachments, but not receipts. Not sure what else could have caused this if it was working well before.

@dangrous
Copy link
Contributor

dangrous commented Aug 6, 2024

I thiiiink I agree that this is not a blocker - I believe before the latest deploy you just couldn't upload images greater than 24mb, so this is better than that.

However, we should probably have @luacmartins @nkdengineer @shubham1206agra take a look since it's the new functionality they introduced.

I'm going to demote this, but keep as daily.

@dangrous dangrous added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Aug 6, 2024
@luacmartins
Copy link
Contributor

@nkdengineer @shubham1206agra could you please take a look?

@luacmartins luacmartins self-assigned this Aug 6, 2024
@nkdengineer
Copy link
Contributor

@luacmartins The reason is the resize function takes a long time with the large image. Then I don't think it's a bug.

If we want to improve this case, we can display a loading while the image is uploading. What do you think?

cc @shubham1206agra

@luacmartins
Copy link
Contributor

Agreed! Let's add a loading indicator while things are processing.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 7, 2024
@nkdengineer
Copy link
Contributor

@shubham1206agra The PR is here.

cc @luacmartins Please help look at the screenshot and let me know your thoughts.

@dangrous
Copy link
Contributor

I think this went to prod 8/12 but the automation didn't fire. If everything looks good, we can work to close out on 8/19.

Will we need payment for this? or is it regression/followup from #44084

@shubham1206agra
Copy link
Contributor

@dangrous No payment required here

@nkdengineer
Copy link
Contributor

Yes, no payment is required here. It's an improvement from #44084

@dangrous
Copy link
Contributor

Awesome! closing out then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants