[Hold PR #46869] Pay someone - App crashes when proceeding to confirmation page during pay someone flow

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #46629

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM.
3. Click +
4. Click Pay.
5. Enter amount.
6. Click Next.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6563114_1722930469626!staging.new.expensify.com-1722930458808.txt

Bug6563114_1722930357149.20240806_154434.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay someone - App crashes when proceeding to confirmation page during pay someone flow

What is the root cause of that problem?

We are accessing comment from transaction?.comment without optional chaining.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 349 in 290a9d9

const trimmedComment = (transaction?.comment.comment ?? '').trim();

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 534 in 290a9d9

const trimmedComment = transaction?.comment?.comment ? transaction.comment.comment.trim() : '';

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 349 in 290a9d9

const trimmedComment = (transaction?.comment.comment ?? '').trim();

What changes do you think we should make in order to solve the problem?

Update to transaction?.comment?.comment

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when proceeding to confirmation page during pay someone flow

What is the root cause of that problem?

The transaction?.comment is undefined here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 611 in 290a9d9

iouComment={transaction?.comment.comment ?? ''}

What changes do you think we should make in order to solve the problem?

Change to

iouComment={transaction?.comment?.comment ?? ''}

What alternative solutions did you explore? (Optional)

[Krishna2323]

This will be fixed here.

[trjExpensify]

Put it on hold for that PR.

[trjExpensify]

Confirmed this is no longer reproducible, closing.