Fix delete modal confirmation message changes briefly when closing the modal #46128

bernhardoj · 2024-07-24T15:45:44Z

Details

The delete transaction confirmation modal message in search page changes briefly when closing the modal. This PR fix it.

Fixed Issues

$ #45447
PROPOSAL: #45447 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: has at least one unpaid expense

Open Search page
Click on the checkbox next to one of the expenses (one only, important)
Click on the dropdown
Click Delete
Note that the confirmation message is "Are you sure that you want to delete this expense?"
Click Cancel
Verify the confirmation message doesn't change to "Are you sure that you want to delete these expenses?"

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-07-24T15:45:49Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2024-07-29T08:21:26Z

Checking now

abdulrahuman5196 · 2024-07-30T17:59:26Z

@robertjchen I have tested all platforms except ios native and the changes work fine. I am unable to test locally due to a setup issue for ios native, could you kindly add the Ready to Build label to generate Adhoc builds for testing?

robertjchen · 2024-07-31T10:10:20Z

label added 👍

abdulrahuman5196 · 2024-07-31T18:06:21Z

@robertjchen The build is still not generated? Could you kindly trigger adhoc builds again?

robertjchen · 2024-08-01T05:28:24Z

@abdulrahuman5196 Ah, I think this is only possible on a branch on the actual Expensify/App repo? Let me create a branch and run it there. 🤔

robertjchen · 2024-08-01T05:36:43Z

@bernhardoj Hm, can you please try resolving the conflict first? Thanks!

…when-closing-it

bernhardoj · 2024-08-01T05:47:56Z

Conflicts solved

abdulrahuman5196 · 2024-08-01T06:09:08Z

@abdulrahuman5196 Ah, I think this is only possible on a branch on the actual Expensify/App repo? Let me create a branch and run it there. 🤔

@robertjchen Is it so? Because all external PRs would be from a fork repo right since contributors don't have access to Expensify branches?

Similar thing happened in this PR as well for the first time - #43084. @MonilBhavsar re-triggered again which generated a a build. Should we do something else as well to trigger a adhoc build for this PR?

github-actions · 2024-08-05T08:50:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/46128/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/46128/NewExpensify.dmg	https://46128.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

abdulrahuman5196 · 2024-08-05T09:11:38Z

@bernhardoj Kindly add the QA steps in the author checklist

bernhardoj · 2024-08-05T09:36:57Z

Oh, didn't realize it was empty. Updated!

abdulrahuman5196 · 2024-08-05T11:02:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-30.at.11.21.05.PM.mp4

Android: mWeb Chrome

Screen.Recording.2024-07-30.at.11.23.49.PM.mp4

iOS: Native

Untitled.mov

iOS: mWeb Safari

Screen.Recording.2024-07-29.at.2.44.29.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-07-29.at.2.12.45.PM.mp4

MacOS: Desktop

Screen.Recording.2024-07-29.at.2.24.33.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @robertjchen

🎀 👀 🎀
C+ Reviewed

robertjchen

Looks great, thank you!

OSBotify · 2024-08-05T13:58:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-06T04:27:47Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.0.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-07T22:03:37Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T04:53:14Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T20:04:38Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

clear the selection item when modal hides

28064f8

bernhardoj requested a review from a team as a code owner July 24, 2024 15:45

melvin-bot bot removed the request for review from a team July 24, 2024 15:45

melvin-bot bot requested a review from abdulrahuman5196 July 24, 2024 15:45

This comment was marked as outdated.

Sign in to view

robertjchen added the Ready To Build label Jul 31, 2024

bernhardoj added 2 commits August 1, 2024 13:44

Merge branch 'main' into fix/45447-delete-confirmation-modal-changes-…

3864ff0

…when-closing-it

clear selected transaction when modal hides

f4fcc47

abdulrahuman5196 approved these changes Aug 5, 2024

View reviewed changes

melvin-bot bot requested a review from robertjchen August 5, 2024 11:02

robertjchen approved these changes Aug 5, 2024

View reviewed changes

robertjchen merged commit 4a558f4 into Expensify:main Aug 5, 2024
16 checks passed

github-actions bot mentioned this pull request Aug 6, 2024

Deploy Checklist: New Expensify 2024-08-06 #46849

Closed

83 tasks

lanitochka17 mentioned this pull request Aug 6, 2024

[$250] Search - No delete or hold option for expense while offline #46890

Closed

6 tasks

melvin-bot bot mentioned this pull request Aug 7, 2024

[HOLD for payment 2024-08-14] [$250] Search - Delete modal message changes to ".. these expenses" briefly when clicking Cancel #45447

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix delete modal confirmation message changes briefly when closing the modal #46128

Fix delete modal confirmation message changes briefly when closing the modal #46128

bernhardoj commented Jul 24, 2024 •

edited

Loading

melvin-bot bot commented Jul 24, 2024

abdulrahuman5196 commented Jul 29, 2024

This comment was marked as outdated.

abdulrahuman5196 commented Jul 30, 2024

robertjchen commented Jul 31, 2024

abdulrahuman5196 commented Jul 31, 2024

robertjchen commented Aug 1, 2024

robertjchen commented Aug 1, 2024

bernhardoj commented Aug 1, 2024

abdulrahuman5196 commented Aug 1, 2024

github-actions bot commented Aug 5, 2024

abdulrahuman5196 commented Aug 5, 2024

bernhardoj commented Aug 5, 2024 •

edited

Loading

abdulrahuman5196 commented Aug 5, 2024

abdulrahuman5196 left a comment

robertjchen left a comment

OSBotify commented Aug 5, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024

Fix delete modal confirmation message changes briefly when closing the modal #46128

Fix delete modal confirmation message changes briefly when closing the modal #46128

Conversation

bernhardoj commented Jul 24, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 24, 2024

abdulrahuman5196 commented Jul 29, 2024

This comment was marked as outdated.

abdulrahuman5196 commented Jul 30, 2024

robertjchen commented Jul 31, 2024

abdulrahuman5196 commented Jul 31, 2024

robertjchen commented Aug 1, 2024

robertjchen commented Aug 1, 2024

bernhardoj commented Aug 1, 2024

abdulrahuman5196 commented Aug 1, 2024

github-actions bot commented Aug 5, 2024

abdulrahuman5196 commented Aug 5, 2024

bernhardoj commented Aug 5, 2024 • edited Loading

abdulrahuman5196 commented Aug 5, 2024

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

robertjchen left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 5, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024

bernhardoj commented Jul 24, 2024 •

edited

Loading

bernhardoj commented Aug 5, 2024 •

edited

Loading