Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"User Profiling" Toggle Not Working #46929

Closed
1 of 6 tasks
IuliiaHerets opened this issue Aug 6, 2024 · 15 comments
Closed
1 of 6 tasks

"User Profiling" Toggle Not Working #46929

IuliiaHerets opened this issue Aug 6, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Sign in to the new dot.
  2. Click on Ctrl + D.
  3. Observe that the modal appears.
  4. Attempt to toggle the 'User Profile' and notice that it does not work.

Expected Result:

The user should be able to toggle the 'User Profile'.

Actual Result:

The user is unable to toggle the 'User Profile'.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6563790_1722977273083.Screen_Recording_2024-08-06_at_1.05.53_PM.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@marcaaron
Copy link
Contributor

The user should be able to toggle the 'User Profile'.

Sorry, did you mean Use Profiling ?

Gonna remove the blocker here. This is an internal tool and not mission critical.

@marcaaron marcaaron added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Aug 6, 2024
@IuliiaHerets
Copy link
Author

@marcaaron Yes, Use Profiling, sorry for confusing

@Tony-MK
Copy link
Contributor

Tony-MK commented Aug 7, 2024

This is issue doesn't actually occur on the main branch

@zanyrenney
Copy link
Contributor

2024-08-07_14-58-18 (1)

can reproduce on staging

@zanyrenney
Copy link
Contributor

but i agree this is not critical

@zanyrenney
Copy link
Contributor

do we actually do this? @thienlnam I see only one ever mention of "user profiling" in slack and its in reference to iOS:
2024-08-07_15-01-48

@zanyrenney zanyrenney changed the title User Profile Toggle Not Working "User Profiling" Toggle Not Working Aug 7, 2024
@zanyrenney
Copy link
Contributor

@kirillzyusko
Copy link
Contributor

It happens because "hosting" is not allowing "self-profiling":

Document policy violation: js-profiling is not allowed in this document.

I described it here: https://github.com/margelo/react-native-release-profiler?tab=readme-ov-file#web-support

We enabled this toggle in dev mode, but to enable it in prod (staging and prod) you'll need to add 'Document-Policy': 'js-profiling' header to html response.

I don't have permissions to deploy so I can not fix it, but if someone can shed some light on where and how the app is hosted (is it AWS S3?) then I can co-operate with that person and together we can fix that 🤞

@thienlnam thienlnam added the Infra label Aug 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2024
@zanyrenney
Copy link
Contributor

Hey @thienlnam any progress here please? I see you added the Infra label - what's the intention for that to assign a specific person/group so that we can move this forward or are you still able to manage it?

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Aug 12, 2024
@thienlnam
Copy link
Contributor

Bumped this back to a weekly since it's not high priority.

I need to double check where we want to add this header - chances are it will probably be in our salt config

@thienlnam thienlnam added Reviewing Has a PR in review and removed Infra labels Aug 20, 2024
@thienlnam
Copy link
Contributor

Screenshot 2024-08-23 at 9 23 33 AM

Nice, resolved! We only added this to staging and adhoc builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

6 participants