[HOLD for payment 2024-08-14] [$250] MEDIUM: [Debugability] Add profile trace download option to Desktop and Web

[muttmuure]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

What performance issue do we need to solve?

e.g. memory consumption, storage read/write times, React native bridge concerns, inefficient React component rendering, etc.

Desktop and web performance is currently difficult to evaluate compared with mobile because we don't support profile tracing

What is the impact of this on end-users?

List specific user experiences that will be improved by solving this problem e.g. app boot time, time to for some interaction to complete, etc.

Desktop and web users are unable to have their performance issues fully triaged.

List any benchmarks that show the severity of the issue

Please also provide exact steps taken to collect metrics above if any so we can independently verify the results.

Triaging this issue would benefit from having a profile trace

Proposed solution (if any)

Please list out the steps you think we should take to solve this issue.

Add web support to react-native-release-profiler
Make the "share profile" flow work on web as well

Add profile trace functionality to the desktop and web apps, in the Troubleshoot menu and four-finger-tap menu

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Note: These should be the same as the benchmarks collected before any changes.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @muttmuure
Slack conversation:

View all open jobs on Upwork

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b1cc2a053306cc3
• Upwork Job ID: 1801178849066862909
• Last Price Increase: 2024-06-20

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018b1cc2a053306cc3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[melvin-bot]

@jayeshmangwani Huh... This is 4 days overdue. Who can take care of this?

[jayeshmangwani]

Waiting on proposal, bumped on #expensify-open-source

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hannojg]

Hey, Hanno from Margelo here 👋 we built react-native-release-profiler the library we use on mobile for recording performance profiles. We can enable recording profiles for desktop (and web), by adding web support to the library.
Feel free to assign me!

[kirillzyusko]

Hey, Kiryl from Margelo here 👋

@hannojg asked me to work on this task. Can you please assign me on this task? 👀

[melvin-bot]

@hannojg, @kirillzyusko, @jayeshmangwani Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kirillzyusko]

I'm working on this task. At the moment I can capture profile traces and I'm discovering the best option for representing this data (obviously it has to match Google Chrome parser standards). Right now I have two options:

• to use a custom transformer;
• to convert to Hermes profiler format and then use hermes transformer.

I think tomorrow or the day after tomorrow the PR will be ready for review 👀

[jayeshmangwani]

Not Overdue! Kirill is working on this issue. The last update is here, and the PR will be ready for review in a day or two.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: release-profiler on web #44432

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)
• @kirillzyusko does not require payment (Contractor)
• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @hannojg is from an agency-contributor and not due payment
• Contributor: @kirillzyusko is from an agency-contributor and not due payment
• Reviewer: @jayeshmangwani owed $250 via NewDot

BugZero Checklist (@lschurr)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1801178849066862909/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jayeshmangwani]

@lschurr Issue is not ready to be paid out yet. The original PR was reverted due to a regression, and a new PR was just merged 3 days ago. Please keep this issue open until the new PR has been in production for 7 days.

[lschurr]

Can you link the new PR here @jayeshmangwani?

[kirillzyusko]

@lschurr it's a link for new PR #46133 🙌

[muttmuure]

#46929

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: release-profiler on web #44432
• feat: web profiler v2 #46133

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)
• @kirillzyusko does not require payment (Contractor)
• @jayeshmangwani requires payment through NewDot Manual Requests

[lschurr]

Payment summary:

Due to the regression, payments are half.

• Contributor: @kirillzyusko (no payment needed)
• Reviewer: @jayeshmangwani $125 via NewDot

[jayeshmangwani]

Requested on ND as per #43363 (comment)

[JmillsExpensify]

$125 approved for @jayeshmangwani