[$250] Menu - The font size (menu text) does not respond to resizing

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #46707

Action Performed:

Change the font size in OS to the maximum font size. In Chrome settings (Accessibility), increase text scaling to maximum

1. Open in Chrome https://staging.new.expensify.com/
2. Log in with any login
3. Navigate to the settings
4. Navigate to About
5. Navigate through the different menus
6. Watch the font size

Expected Result:

Text size in mWeb(Chrome) app partially does not resize
The text size in mWeb(Chrome) app should react to the increase in size.

Actual Result:

The font size (menu text) does not respond to resizing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563533_1722960178879.Record_2024-08-06-20-43-41.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c57c6c3405a2d684
• Upwork Job ID: 1821663436717148240
• Last Price Increase: 2024-09-19

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

he font size (menu text) does not respond to resizing

What is the root cause of that problem?

We need to set the font size via getValueUsingPixelRatio like here

App/src/styles/variables.ts

Lines 53 to 54 in 0e46257

	fontSizeSmall: getValueUsingPixelRatio(11, 17),
	fontSizeExtraSmall: 9,

and in all places where we gave static font size it will not rescale. for instance in initial settings page we have given static font here

App/src/styles/index.ts

Lines 2848 to 2849 in 0e46257

	fontSize: 13,
	...FontUtils.fontFamily.platform.EXP_NEUE,

What changes do you think we should make in order to solve the problem?

We need to set the font size via getValueUsingPixelRatio every where we need

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c57c6c3405a2d684

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

📣 @muhammad-r39! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[muhammad-r39]

Contributor details
Your Expensify account email: muhammadrussell39@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/muhammadrussell

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[saowwapark]

Contributor details
Your Expensify account email: saowwapark.chanwigoon@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~012348c9a4780fd260?mp_source=share

By default, the font-size in React is pixel unit which is static unit. To change the size depending on accessibility control please change it to be rem unit. It is a convention to use rem unit for font size in modern web application.

The real problem is to change from pixel to rem throughout the project is rather cumbersome. You have to decide whether which method you prefer between ...

1. Setting root font size (Not recommended)

html {
    font-size: 62.5%;
}

.paragraph-font-size {
    /* The font size for default is 18px. */
    font-size: 1.8rem;
}

If you want the size 18px, you have to set it to be 1.8rem.

2. CSS variable (Recommended)

html {
    --18px: 0.875rem
}

.paragraph-font-size {
    /* The font size for default is 18px. */
    font-size: var(--18px);
}

In my opinion, you can use media query and set font size like below instead of getValueUsingPixelRatio() :

@media (xx >= width <= xx) {
    --fs-300: clamp(0.94rem, calc(0.92rem + 0.08vw))
    --fs-400: clamp(1.13rem, calc(1.06rem + 0.33vw))
}

@media (yy >= width <= yy) {
    --fs-300: clamp(?rem, calc(?rem + ?vw))
    --fs-400: clamp(?rem, calc(?rem + ?vw))
}

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@johncschuster, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

@saowwapark Can you please familiarize yourself with our codebase and some old proposals on closed issues to understand what is expected in a proposal?

[situchan]

We need to set the font size via getValueUsingPixelRatio every where we need

@FitseTLT thanks for the proposal. can you please list all places? The test branch is fine.

[FitseTLT]

We need to set the font size via getValueUsingPixelRatio every where we need

@FitseTLT thanks for the proposal. can you please list all places? The test branch is fine.

@situchan It looks like the problem is specific to mWeb and don't think my RCA is correct.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@johncschuster, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shubham1206agra]

I think all font sizes on that screen should react to the increase in size. It feels weird to me as well that the headline isn't changing.

@dubielzyk-expensify Can you tell me how we decide the upper bound of these fonts? Is that chosen randomly, or is there a method to decide on this?

[dubielzyk-expensify]

I'm not 100% sure actually. I would check the rest of that screen and stop the font-size when the rest is stopping.

I think for a headline on that screen specifically I'd stop at around 40px.

I'm making a note for the future to start defining this stuff 👍 Thanks for calling it out and asking 😄

[melvin-bot]

@johncschuster @situchan this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[johncschuster]

I think we're waiting for a bit of clarification on this one, Melv.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[johncschuster]

Bumping this to keep Melvin happy. It looks like we're waiting on a proposal to be accepted.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[johncschuster]

Thanks for the retest!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

@johncschuster, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

Not overdue

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[situchan]

OP needs updated to meet #46902 (comment) on all platforms

[johncschuster]

Updated

[johncschuster]

It seems like this may be resolved though. I'm going to close this one out.