[$250] Track Expense - Actionable whisper stays on LHN after expense is moved

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4834393
Email or phone of affected tester (no customers): nathanmulugetatesting+912@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a track expense
3. On the actionable whisper click on submit to someone
4. Enter an account to submit to and select it
5. Click on submit to confirm
6. Click on your self DM report

Expected Result:

The actionable whisper doesn't reappear on the LHN

Actual Result:

The actionable whisper message reappears on the LHN even if the expense is moved to another report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565620_1723122907666.bandicam_2024-08-08_16-08-58-101.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165e88bc0f739036b
• Upwork Job ID: 1821706141212640383
• Last Price Increase: 2024-08-16

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[jliexpensify]

Very odd one! I can repro.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165e88bc0f739036b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[trjExpensify]

Track bug, moving to #vip-vsb.

[ijmalik]

Please re-state the problem that we are trying to solve in this issue.

Track Expense - Actionable Whisper Remains on LHN After Expense is Moved

Actions to reproduce:

1. Navigate to staging.new.expensify.com
2. Create a track expense
3. On the actionable whisper click on submit to someone
4. Enter an account to submit to and select it
5. Click on submit to confirm
6. Click on your self DM report

What is the root cause of that problem?

The root cause of the problem lies in the backend (BE) processing, specifically related to the handling of an action type called ACTIONABLETRACKEXPENSEWHISPER

App/src/libs/OptionsListUtils.ts

Line 717 in e6546d6

return lastMessageTextFromReport || (report?.lastMessageText ?? '');

Here lastMessageText is being used to show message for selfDM on LHN

In step 6, the API OpenReport request was sent, and the response was received. The last action of type ACTIONABLETRACKEXPENSEWHISPER ultimately set the lastMessageText in the Report to "What would you like to do with this expense?"

                "8220943923986747993": {
                    "person": [
                        {
                            "type": "TEXT",
                            "style": "strong",
                            "text": "concierge@expensify.com"
                        }
                    ],
                    "actorAccountID": 8392101,
                    "message": [
                        {
                            "type": "COMMENT",
                            "html": "What would you like to do with this expense?",
                            "text": "What would you like to do with this expense?",
                            "isEdited": false,
                            "whisperedTo": [],
                            "isDeletedParentAction": false,
                            "deleted": ""
                        }
                    ],
                    "originalMessage": {
                        "html": "What would you like to do with this expense?",
                        "lastModified": "2024-08-09 03:49:33.075",
                        "resolution": "request",
                        "transactionID": "4103948917902194526"
                    },
                    "avatar": "https:\/\/d1wpcgnaa73g0y.cloudfront.net\/894b50e60056c966d12216005fbcacec8ce5a2c0.png",
                    "created": "2024-08-09 03:48:02.807",
                    "timestamp": 1723175282,
                    "reportActionTimestamp": 1723175282807,
                    "automatic": false,
                    "actionName": "ACTIONABLETRACKEXPENSEWHISPER",
                    "shouldShow": true,
                    "reportActionID": "8220943923986747993",
                    "lastModified": "2024-08-09 03:49:33.075",
                    "whisperedToAccountIDs": []
                },

What changes do you think we should make in order to solve the problem?

The backend should handle the message for the ACTIONABLETRACKEXPENSEWHISPER action.

47075_ErrorDemo.mp4

[melvin-bot]

@jliexpensify, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jliexpensify]

Bumping @DylanDylann for a review of the proposal

[DylanDylann]

On my list today

[codewaseem]

I could not reproduce this after syncing with main branch.

[ijmalik]

@codewaseem

I've synced with the main branch and am now on version 9.0.19-10, but the issue still persists. It also continues to occur on staging.

I've noticed that the issue reoccurs particularly when the OpenReport API response is received. Sometimes, the OpenReport API call isn't sent, which causes the issue to reappear upon page refresh.

47075_Staging_error_3.mp4

[jliexpensify]

Bumping @DylanDylann again

[DylanDylann]

I still can reproduce this bug

[DylanDylann]

Looking for more proposals

[DylanDylann]

@jliexpensify After rechecking again, I see this bug should be handled on the BE side. report.lastMessageText is wrong

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[IuliiaHerets]

This issue is still reproducible, build - v9.0.51-2

bandicam.2024-10-21.12-36-58-575.mp4

[AndrewGable]

Still focused on higher priority issues, so going to un-assign

[jliexpensify]

Adding the Retest label as I can't reliably repro on v9.0.56-0 now.

[jliexpensify]

Waiting on a re-test

[jliexpensify]

Going to close this. I can't repro.

[IuliiaHerets]

QA team still can repro this issue, build - v9.0.67-0

bandicam.2024-11-26.21-13-06-701.mp4

[jliexpensify]

I'm now able to repro it.

[jliexpensify]

Under the new project system, I believe this is an #expense bug

[jliexpensify]

Not overdue, waiting on an engineer to pick it up. I'm also OOO until the 29th.