Deploy Checklist: New Expensify 2024-11-07

[github-actions]

Release Version: 9.0.59-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix: [Dupe detection] Tax code review step shows empty option when workspace does not have tax rate #48958
• fix: app goes to workspace initial page when back from not found page #49226
• hide expensify from new chat page #50937
• Prevent selection list from losing focus #51068
• Enable/disable per diem rates #51232
• Approval button is missing after payment of the report with hold expense #51503
• Update Expensify Classic - Sage Intacct Connect and Configure articles with images #51606
• Make autocomplete work with entity ids #51633
• Hide approve button for pending card transaction #51644
• Reports with "report not found" error cause Inbox tab RBR #51675
• Fix: Chats - Selected chat is hidden when navigating via keyboard #51754
• Removed the hasText condition from getIconWidthAndHeightStyle utils #51775
• Fix: App crashes when opening attachments in #expensify-roadmap public room on iOS #51783
• Fix - Android - Hybrid app - Tags - Tapping a tag and quickly long press it shows "select" option in tag page #51818
• [NOQA] New help content migration #51827
• [Workspace Chats for All] Default QAB to primary workspace if no value #51836
• Fix blank map preview on employee side #51840
• [QBD] Handle errors gracefully if the setup link cannot be obtained #51850
• Fix blank view when report is deleted #51920
• Fix WS chat for invalid member doesn't show error #51923
• fix: QAB - Without entering any amount, tapping submit expense/pay elsewhere shows diff. behavior. #51929
• iOS: Clear temp pasted files #51932
• Fix/29783 v2 #51944
• Add Track expense follow up questions as rows in details view of a Tracked expense #51951
• Handle disabled case when computing menu item background color #51988
• [NoQA] Remove direct and company cards betas #51997
• fix blue border around year #52014
• [NO QA]: Workspace feed fix bank clean up in others #52022
• Fix app navigation issue after workspace upgrade #52050
• [NoQA] e2e: fixed typing test #52062
• Update en.ts #52069
• Update es.ts #52080
• Remove P2P distance requests beta checks #52081
• Expensify Card - Remove the exclamation marks on Spanish translation #52085
• Use platform specific mute setting for sounds #52088
• Dismiss RHP on back button click from Issue New Card page #52091
• [No QA] Update Upgrade-to-the-new-Expensify-Card-from-Visa.md #52125
• [CP Staging] Updated Background Color Condition #52273
• [CP Staging] Prevent showing track expense option for submitted track expense #52274
• [CP STAGING] Fix long press search page regression #52278

Internal QA:

• Workspace Feed - add Search for more than 8 export rows #52042 - @mountiny
• [Workspace Feeds] Card name field on confirmation page #52028 - @mountiny
• Redirect to feed after completing the bank connection #52016 - @mountiny

Deploy Blockers:

• [HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error #52096
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] Android - Workspace - App freezes then crashes when inviting a member to a workspace #52113
• [HOLD for payment 2024-11-21] QAB - Scan QAB is not displayed for offline created workspace #52186
• [$250] Track expense - Back button returns to expense report after submitting track expense #52189
• [HOLD for payment 2024-11-20] [$250] mweb - Per diem - View your subscription link opens Subscription page then back to Workspace #52201
• [HOLD for payment 2024-11-20] [$250] Search - Unable to select expenses by tapping and holding #52202
• mWeb - Workspace - After enabling all features, unable to enable tax option #52203
• [HOLD][$250] Search - Suggestion still shows the report when it is already selected as search query #52213
• [HOLD for payment 2024-11-28] [$250] Search - Search icon is not responsive after sharing expense with accountant and return to LHN #52239
• [HOLD for payment 2024-11-20] [$250] Track expense - Track expense options are still present in report header after it is submitted #52240
• Per diem - Error when submitting distance expense when Per diem is enabled #52245
• Per diem - Unable to edit category when Per diem is enabled #52257
• [PAID] [$250] Expense - Disabled category when selected is not highlighted #52259
• [HOLD for payment 2024-11-29] [$250] Search - The shortcut CTRL + K does not work with a user as employee in a WS #52260

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.59-0 🚀

[kavimuru]

Regression is 83% of progress.
We still working on the PRs. iOS HybridApp updated just an hour ago.

[carlosmiceli]

Demoted #52201

[MarioExpensify]

Demoting #52213

[mvtglobally]

Regression is at 5% left

Blockers
#52096
#52189
#52202

PRs

#48958 - Pending validation on Desktop and IOS
#49226 - Pending validation on IOS
#51606 - is Prod QA. Can we check off?
#51633 - Pending validation on mWeb
#51644 - Pending validation on all platforms
#51783 - is failing with KI #51181. Repro in prod, checking off
#51850 - Pending validation on Desktop
#51920 - is failing #50843 & #52191
#51929 - Pending validation on Desktop and Hybrid apps
#52080 - can you clarify QA steps

[izarutskaya]

Regression is a couple steps left

PRs:
#48958 - Failing with #52210
#49226 - Pending validation on IOS
#51783 - Failing with KI #51181.
#51850 - Pending validation on Desktop
#51920 - Failing with #50843 & #52191
#51929 - KI #50780, KI comment Pending validation on iOS
#51951 - KI #47075

Blockers:
#52096
#52189
#52202
#52239
#52240

[Julesssss]

#48958 - Failing with #52210

Minor, not a blocker. Checking off.

#51783 - Failing with KI #51181

Existing issue, PR in review.

#51920 - Failing with #50843 & #52191

Asked here to clarify why this can't be verified, but regardless this shouldn't block deploy.

#51951 - KI #47075

Pre-existing issue, in progress

[Julesssss]

• [HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error #52096 confirmed fixed: [CP STAGING] fix: Bank account - Website in upper-case letters is accepted despite validation error. #52155 (comment)
• [HOLD for payment 2024-11-28] [$250] Search - Search icon is not responsive after sharing expense with accountant and return to LHN #52239 is not a blocker
• Update Expensify Classic - Sage Intacct Connect and Configure articles with images #51606 - asked here to see if there should be test steps
• Checked off Per diem - Error when submitting distance expense when Per diem is enabled #52245 as not a blocker

[mvtglobally]

Regression is last 4 steps left

Blockers
#52189
#52202
#52240
#52257
#52259
#52260

PRs

#49226 - Is blocked with #51090 on Hybrid app. Unable to validate the PR fully. Can you check internally if any workaround?
#51606 - is Prod QA. Can we check off?
#51644 - checking off #51644 (comment)
#51929 - few known issues repro KI #50780, KI #51242 (comment). Repro in PROD. Checking off
#52080 - Can we check this off? Its a copy change

[Julesssss]

#52080 - Can we check this off? Its a copy change
#51606 - is Prod QA. Can we check off?

Yes to both, I have checked off.

#49226 - Is blocked with #51090 on Hybrid app. Unable to validate the PR fully. Can you check internally if any workaround?

I asked @lakchote to verify this here.

[mvtglobally]

Regression is completed

[Julesssss]

I have bumped the remaining blockers

[NikkiWines]

Demoted #52257 - not a blocker

[lakchote]

#49226 - Is blocked with #51090 on Hybrid app. Unable to validate the PR fully. Can you check internally if any workaround?

I asked @lakchote to verify this here.

Checked it off. See my test here.

[Julesssss]

Three blockers remaining:

• [CP Staging] Prevent showing track expense option for submitted track expense #52274 and [CP STAGING] Fix long press search page regression #52278 fixed here
• [CP Staging] Updated Background Color Condition #52273 fixed, awaiting CP

[Julesssss]

Above PRs cherry picked. Asked for QA here.

[mountiny]

Demoted #52189

[francoisl]

Checking off the last 3 blockers, they were fixed and confirmed in the QA channel.

• Prevent showing track expense option for submitted track expense
• Fix long press search page regression
• Updated Background Color Condition

[francoisl]