Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Feed - add Search for more than 8 export rows #52042

Conversation

narefyev91
Copy link
Contributor

Explanation of Change

Add missing search input - when user has more than 8 export items to choose in Company card detail view

Fixed Issues

$ #51884
PROPOSAL:

Tests

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details
  4. Click Quickbooks Online Debit card Export
  5. Verify that it will be no search - if less than 8 export items presented
  6. Verify that it will be a search - if 8+ export items presented
  7. Verify that search functionality is working
  • Verify that no errors appear in the JS console

Offline tests

No changes here

QA Steps

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details
  4. Click Quickbooks Online Debit card Export
  5. Verify that it will be no search - if less than 8 export items presented
  6. Verify that it will be a search - if 8+ export items presented
  7. Verify that search functionality is working
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov

@narefyev91 narefyev91 requested a review from a team as a code owner November 5, 2024 14:28
@melvin-bot melvin-bot bot requested review from allgandalf and removed request for a team November 5, 2024 14:28
Copy link

melvin-bot bot commented Nov 5, 2024

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@allgandalf
Copy link
Contributor

@narefyev91 please mark this one no QA

@narefyev91 narefyev91 changed the title Workspace Feed - add Search for more than 8 export rows [NO QA]: Workspace Feed - add Search for more than 8 export rows Nov 5, 2024
@allgandalf
Copy link
Contributor

allgandalf commented Nov 5, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native Screenshot 2024-11-07 at 2 16 42 AM
Android: mWeb Chrome Screenshot 2024-11-07 at 2 18 08 AM
iOS: Native Screenshot 2024-11-07 at 2 10 42 AM
iOS: mWeb Safari Screenshot 2024-11-07 at 2 20 32 AM
MacOS: Chrome / Safari Screenshot 2024-11-07 at 1 43 06 AM
MacOS: Desktop Screenshot 2024-11-07 at 1 52 56 AM

@allgandalf
Copy link
Contributor

@narefyev91 can you please provide me mock data for cardlist:)

@narefyev91
Copy link
Contributor Author

@narefyev91 can you please provide me mock data for cardlist:)

use this useEffect:

useEffect(() => {
    Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {
        connections: {
            quickbooksOnline: {
                config: {
                    companyName: 'test',
                    credentials: {
                        access_token:
                            '2LHOKnH9waofJaMRyrVBUP+4qJsh4u+6E3Ffu73YJFJ6FnzAfsydZVkVFwjQmyxknEXCOYNeqoRljafcUk2sgzeq6002fXY55AEKF36UjaQQskfo4wR192K0v/68BUEzCpghfahoRmupoNq0u1JM8h/NDNIcLEi9ZDBno+7a22wi2jshJtcGL/wGBMUalWFupOmkiJbLPFen+mHFqLI8kF4TydI2a7SC4M4BAkZ2N7cFvp9LC39cLvrL7pZ/0wdIe8d4AMrKdR8M8V+KD8r2X4zXoQhKxSPA+2wRFiXIwOKB2iZqgI19dQHD0QqwbW6a512nOb7Q1Y0/SrF6NtVAaBXwhF2o3VULwFH3cy4QTYxB25wXCU76bhYsvUaQ/xWUVjY2TEi3GXkdTrNN8Ys8MXH3A9kVX7I32whBMfygcjYLtxc4/aVr8gYg8w5XPRRJ5Q/OGy68mX1JlCyWi+1NNAUJVkeRXuOsnivYvvaRisCJ4bng4ZiK9hnSWJ6qyKMWnb/nPpjZfZe25nbXfEG/e3CgwJ3KU4RlWZM+ECSWGcM/KyAGfErbcDBXXQk/6BnMjTqQkP5HotH8BHsUzYsw8D1A8i3gpgU/CStK8b+2PFcoqgTxWmsPgL7O32AFNR6z1yd1Zsrk5cDVHDlTddw1ePxrvfJRuT7gNKlut9oIAjgyR5iagxk/By2AGp0o2S53becAoPRGtuYYxk5WmpfB2q0N0QHI9VtRDJ5p1wn4KPO4twnnkU5YyD/u2UuBCWw9UB1rDWZVpGRUilyF2/0vy7PJHoUCXodz0DIulT+cDSHqf9hmc1pm7LI3Qt17X4uO1YCIQA7qQk1G5aY32HwNVq2VnyZJT64nEJ3JMydI4k74jrGy9Zp+52lAF39AenCaNjbVJg5svd0KEeOdwqr1j9SNkrHZkMmhuAUSI/WfyAhrtmjmRVGBTJ6b9l8fjdzwLwubXdFInG8M7h8Pc0Db7VTvd8Qv8MFRjhomzHbTkVMApKr1EH9WGzf932FlDse9HwKC4c6mA2Uj0BCaxsbnKnqd/I6Ug==;vJoXwrJgPzNOdv28yQHtPA==;eKPhE8t3aDV62W1np/MZoKIYA1bRawdFuttb5yxT44HQWjYgEc5x/Glx+Ye6YZP06Aj3N0A7eMw6rj98Kjpaow==',
                        companyID: '934145206296',
                        companyName: 'test',
                        expires: 1730725016,
                        realmId: '934145340296',
                        refresh_token:
                            'KwizVqdImwI5kHeImQ2NrXO7rteCSzvtQakR3uhp7Y04X06z3F4Hvt42jw==;fK/XjysVFPC4lYgRXbzi/RpxI1z3aWWpaLSAnT5v1kRtg4ilXX9fjQvA6Wc3LhKqZXnADugm2DbveEmZWAItlg==',
                        scope: 'Accounting',
                        token_type: 'bearer',
                    },
                    realmId: '9341453405206',
                    autoSync: {
                        enabled: true,
                        jobID: '4604867689969023701',
                    },
                    syncClasses: 'REPORT_FIELD',
                    pendingFields: {},
                    errorFields: {},
                    syncLocations: 'NONE',
                    autoCreateVendor: false,
                    collectionAccountID: '29',
                    enableNewCategories: true,
                    export: {
                        exporter: 'zhenja3033@gmail.com',
                    },
                    exportDate: 'REPORT_EXPORTED',
                    hasChosenAutoSyncOption: true,
                    lastConfigurationTime: 1730721696740,
                    markChecksToBePrinted: false,
                    nonReimbursableBillDefaultVendor: 'NONE',
                    nonReimbursableExpensesAccount: {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents',
                    },
                    nonReimbursableExpensesExportDestination: 'debit_card',
                    reimbursableExpensesAccount: {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents',
                    },
                    reimbursableExpensesExportDestination: 'bill',
                    reimbursementAccountID: '29',
                    syncCustomers: 'TAG',
                    syncItems: false,
                    syncPeople: false,
                    syncTax: false,
                },
                data: {
                    accountPayable: [],
                    accountsReceivable: [],
                    bankAccounts: [
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '29',
                            name: 'Cash and cash equivalents',
                        },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents1',
                      },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents2',
                      },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents3',
                      },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents4',
                      },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents5',
                      },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents6',
                      },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents7',
                      },
                      {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents8',
                      },
                    ],
                    country: 'PL',
                    creditCards: [],
                    edition: 'QuickBooks Online Simple Start',
                    employees: [],
                    homeCurrency: 'PLN',
                    isMultiCurrencyEnabled: false,
                    journalEntryAccounts: [
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '32',
                            name: 'Accrued liabilities',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '70',
                            name: 'Allowance for bad debt',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '13',
                            name: 'Available for sale assets (short-term)',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '38',
                            name: 'Dividends payable',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '26',
                            name: 'Income tax payable',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '65',
                            name: 'Inventory',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '74',
                            name: 'Payroll Clearing',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '73',
                            name: 'Payroll liabilities',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '47',
                            name: 'Prepaid expenses',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '71',
                            name: 'Short-term debit',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '1',
                            name: 'Uncategorised Asset',
                        },
                    ],
                    otherCurrentAssetAccounts: [
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '70',
                            name: 'Allowance for bad debt',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '13',
                            name: 'Available for sale assets (short-term)',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '65',
                            name: 'Inventory',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '47',
                            name: 'Prepaid expenses',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '1',
                            name: 'Uncategorised Asset',
                        },
                    ],
                    vendors: [],
                },
                lastSync: {
                    errorDate: '',
                    errorMessage: '',
                    isAuthenticationError: false,
                    isConnected: true,
                    isSuccessful: true,
                    source: 'NEWEXPENSIFY',
                    successfulDate: '2024-11-04T12:01:36+0000',
                },
            },
        },
    });
}, [policyID]);

Copy link
Contributor

@allgandalf allgandalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well

@melvin-bot melvin-bot bot requested a review from mountiny November 6, 2024 20:51
@mountiny mountiny changed the title [NO QA]: Workspace Feed - add Search for more than 8 export rows Workspace Feed - add Search for more than 8 export rows Nov 7, 2024
@mountiny mountiny added the InternalQA This pull request required internal QA label Nov 7, 2024
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -3056,6 +3056,7 @@ const CONST = {
// Character Limits
FORM_CHARACTER_LIMIT: 50,
STANDARD_LENGTH_LIMIT: 100,
STANDARD_LIST_ITEM_LIMIT: 8,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding such const it should be good to also updated all the applicable usages to use it, maybe you can do it in another PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - today will add it with upcoming PR.

@mountiny mountiny merged commit 160a2d2 into Expensify:main Nov 7, 2024
20 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.59-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@joekaufmanexpensify
Copy link
Contributor

Search bar with 8+ rows

Confirmed search functionality working too.
image

No search bar <8 rows

image

Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄 skipped 🚫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
InternalQA This pull request required internal QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants