-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect to feed after completing the bank connection #52016
Redirect to feed after completing the bank connection #52016
Conversation
@mountiny The PR is up |
@dukenv0307 @allgandalf Could you guys help to review this PR? Please comment on this PR and start reviewing soon. Thanks |
Please comment on the code change then the Melvin will not get another C+ when I open the PR |
I can review it |
i can help |
@dukenv0307 should i review this? i have free cycle |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@dukenv0307 I still trying to test this change. It seems hard to test on dev without an auth connection cc @mountiny |
@dukenv0307 Problem: When users complete the bank account flow, the App doesn't navigate them to Company Feed. This PR will fix this problem CleanShot.2024-11-01.at.12.40.44.mp4 |
I anticipate this is hard to test locally, sorry there is no way to handle it. How does the xero connection or other integration connections handle it, i think they must use the same approach |
src/pages/workspace/companyCards/addNew/BankConnection/index.tsx
Outdated
Show resolved
Hide resolved
src/pages/workspace/companyCards/addNew/BankConnection/index.tsx
Outdated
Show resolved
Hide resolved
src/pages/workspace/companyCards/addNew/BankConnection/index.tsx
Outdated
Show resolved
Hide resolved
This is another flow, and I don't think we can use the same way here. Trying another way |
806aa97
to
6069922
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@mountiny For sure, we need to make a build and reach out to some internal QA who have chase accounts to test this PR |
This comment has been minimized.
This comment has been minimized.
@dukenv0307 There are some updates. We only need to mock this response
|
@dukenv0307 Please help to review again |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
@dukenv0307 kindly bump |
I'm recording the videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #52169. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, we will continue improving this code overtime but right now mainly we want to get the connection working smoothly so we can test other flows easier
@JmillsExpensify will help us test this
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.59-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀
|
Explanation of Change
Fixed Issues
$ https://expensify.slack.com/archives/C06ML6X0W9L/p1730461357005019?thread_ts=1729596921.819569&cid=C06ML6X0W9L
PROPOSAL: https://expensify.slack.com/archives/C06ML6X0W9L/p1730688809259139?thread_ts=1729596921.819569&cid=C06ML6X0W9L
Tests
Offline tests
Internal QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-06.at.23.20.11.mov
Android: mWeb Chrome
Screen.Recording.2024-11-07.at.00.21.55.mov
iOS: Native
Screen.Recording.2024-11-07.at.00.29.34.mov
iOS: mWeb Safari
Screen.Recording.2024-11-07.at.00.24.13.mov
MacOS: Chrome / Safari
Screen.Recording.2024-11-06.at.22.32.11.mov
MacOS: Desktop
Screen.Recording.2024-11-06.at.22.52.25.mov