-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app navigation issue after workspace upgrade #52050
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@DylanDylann I'll attach the videos shortly |
Please using a meaningful name for PR name/ commit |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-06.at.12.18.48.movAndroid: mWeb ChromeScreen.Recording.2024-11-06.at.12.16.55.moviOS: NativeScreen.Recording.2024-11-06.at.12.19.53.moviOS: mWeb SafariScreen.Recording.2024-11-06.at.12.20.29.movMacOS: Chrome / SafariScreen.Recording.2024-11-06.at.12.13.51.movMacOS: DesktopScreen.Recording.2024-11-06.at.12.17.16.mov |
@Nodebrute Could you give an ETA for your update? |
I'm working on it. My Android build is taking time, but I should have it ready within the next hour. |
@DylanDylann All yours. |
@NikkiWines All yours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
@hannojg I think it was a random failure? I don' think changes from this PR can affect startup metrics... |
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.0.59-0 🚀
|
@kirillzyusko agree, this seems like a false positive 🤔 |
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀
|
Explanation of Change
Fixed Issues
$ #51733
PROPOSAL: #51733 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
XRecorder_06112024_120229.mp4
Android: mWeb Chrome
Screen.Recording.2024-11-06.at.11.41.51.AM.mov
iOS: Native
Screen.Recording.2024-11-06.at.10.25.25.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-11-06.at.10.24.53.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-11-06.at.10.21.11.AM.mov
MacOS: Desktop
Screen.Recording.2024-11-06.at.11.47.49.AM.mov