-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Prevent showing track expense option for submitted track expense #52274
Conversation
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-11.at.07.55.54.mp4Android: mWeb ChromeScreen.Recording.2024-11-11.at.07.52.55.mp4iOS: NativeScreen.Recording.2024-11-11.at.07.51.37.mp4iOS: mWeb SafariScreen.Recording.2024-11-11.at.07.49.29.mp4MacOS: Chrome / SafariScreen.Recording.2024-11-11.at.07.40.51.mp4MacOS: DesktopScreen.Recording.2024-11-11.at.07.46.57.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[CP Staging] Prevent showing track expense option for submitted track expense (cherry picked from commit ed230ea) (CP triggered by Julesssss)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.59-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀
|
Explanation of Change
Prevent showing track expense option for submitted track expense
Fixed Issues
$ #52240
PROPOSAL: #52240 (comment)
Tests
Precondition
Offline tests
Same as above
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Precondition
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-09.at.00.54.29.mov
Android: mWeb Chrome
Screen.Recording.2024-11-09.at.01.01.50.mov
iOS: Native
Screen.Recording.2024-11-09.at.00.47.56.mov
iOS: mWeb Safari
Screen.Recording.2024-11-09.at.00.58.46.mov
MacOS: Chrome / Safari
Screen.Recording.2024-11-09.at.00.39.02.mov
MacOS: Desktop
Screen.Recording.2024-11-09.at.01.04.16.mov