-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOQA] New help content migration #51827
Conversation
Your New Help changes have been deployed to https://11db5377.newhelp.pages.dev ⚡️ |
@Gonals I think this is ready for your review! Remember: This site is still hidden behind a robots.txt, and not linked anywhere. So it's very much a prototype/WIP, but I'd like to merge it so I can engage others in the next steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments!
@Gonals Can you add the PR reviewer checklist? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🚀Deployed to NewHelp production! 🚀 |
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.59-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀
|
Explanation of Change
This is part of the ongoing effort to create New Help. This includes a ton of new but largely AI-generated fake content, as well as updates to the ToC.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/414789
PROPOSAL:
(none)
Tests
Offline tests
n/a
QA Steps
n/a
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
n/a