[$125] Attachment - Keyboard shows up with delay after canceling taking photo flow

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4829914
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app and log in
2. Select any chat
3. Tap the + button > Add attachment > Take photo
4. Close the camera or tap the back button

Expected Result:

The keyboard shows up right after exiting camera

Actual Result:

The keyboard shows up with a delay, the grey area instead of the keyboard is displayed briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6564938_1723061688563.video_2024-08-07_13-29-52.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013b1d8e65cdd9c8c7
• Upwork Job ID: 1823386646555076621
• Last Price Increase: 2024-08-27
• Automatic offers:
• eh2077 | Reviewer | 103753396

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[sakluger]

I'm not sure how complex this one is, but it looks like it might be pretty simple to fix. I'm going to set the price to $125, but I am open to increasing the price if it's more complex.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013b1d8e65cdd9c8c7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

📣 @excile1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[eh2077]

The root cause of this keyboard issue is subtle. So, I need to spend sometime to understand it.

[eh2077]

@sakluger There should be a proposal posted above right? I'm going to review it but I found it was deleted by the author.

[sakluger]

Yeah, I remember seeing a proposal posted on this issue. I'm not sure where it went 🤷‍♂️

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sakluger @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@sakluger, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eh2077]

Not overdue as the team has decided how to move forward with this issue.

[rezkiy37]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

When the user opens modals (menu items, attachment options, and emojis), the keyboard shows up with a delay, the grey area instead of the keyboard is displayed briefly.

What changes do you think we should make in order to solve the problem?

Do not focus Composer after interactions with those modals (menu items, attachment options, and emojis).

Video

Android.mp4

I checked other messengers like Telegram and What's Up and they don't open the keyboard then if the user clicks on attachments to invoke modals on IOS at least. It works pretty smoothly.

Videos

Telegram.mp4

What.s.Up.mp4

What alternative solutions did you explore? (Optional)

Change the native property to adjustPan. The doc says:

"adjustPan" - The activity's main window isn't resized to make room for the soft keyboard. Rather, the contents of the window automatically pan so that the current focus is never obscured by the keyboard, and users can always see what they are typing. This is generally less desirable than resizing, because the user might need to close the soft keyboard to get at and interact with obscured parts of the window.

This means that the keyboard behavior is similar to that of IOS. However, this change requires adjusting KeyboardAvoidingView and testing all pieces where the app uses inputs and the keyboard. It is too big of a change to justify fixing this bug, as we will have to check every place that interacts with the keyboard and will possibly create other issues we aren’t aware of.

[rezkiy37]

Hey!
I will be OOO from 04.09 (afternoon) till 09.09. I will continue to work on this one once I am back.

[rezkiy37]

Hey!
I've opened PR (#48415) for review (in order of my proposal (#47082 (comment))) because I will be OOO this week. So if C+ approves the proposal please start to review the PR then.

[eh2077]

@rezkiy37 I'll be able to review the PR by the EOD, so it's a bit rushed for us to get it merged before you're ooo. At the first glance, we fix it by removing lines and chances look good to me. While the issue relates to composer focusing is usually subtle, so I'll need to do more testing on this.

I think we can wait until you're back from leave because it doesn't seem like an urgent issue.

[rezkiy37]

@eh2077, it makes sense. So you can test it and we will merge it next week 🙂

[sakluger]

Love the urgency here, but I agree that there's no huge rush on this one. We can finish when you return from OOO.

[rezkiy37]

Hey!
I am back 🙂

[rezkiy37]

@eh2077, As I understand we all agreed (#47082 (comment), #47082 (comment)) not to focus Composer.

So I posted this proposal (#47082 (comment)) and opened the PR (#48415). Please review it 🙂

[rezkiy37]

Hello!
I am OOO from 19.09 - 23.09. I will continue to work on this one when I am back.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tylerkaraszewski]

Why did I get assigned to this now? Seems like it's already done?

[rezkiy37]

Yes, the PR was merged. We can go ahead and close the issue.

[eh2077]

Hi @sakluger, I think I should be eligible for payment as I helped review PR #48415.

[sakluger]

Hey @eh2077, you are definitely eligible for payment. Thanks for letting us know, and sorry for missing that.

[sakluger]

Summarizing payment on this issue:

Contributor+: @eh2077 $125, please request on Newdot

[eh2077]

Requested in NewDot

[JmillsExpensify]

$125 approved for @eh2077

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.