Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Composer - Expand button does not appear when reopening chat with long draft #47224

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 12, 2024 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to chat
  3. Enter text long enough until expand button appears
  4. Return to LHN
  5. Open the chat in Step 3

Expected Result:

Expand button will appear next to the composer

Actual Result:

Expand button does not appear next to the composer until anything is typed in the composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6569731_1723462871743.c.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rlinoz
Copy link
Contributor

rlinoz commented Aug 12, 2024

Not a backend issue.

@rlinoz rlinoz removed the DeployBlocker Indicates it should block deploying the API label Aug 12, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Aug 12, 2024

I think this is related to #46796, but I don't think it is worth blocking on this.

cc: @hannojg

@rlinoz
Copy link
Contributor

rlinoz commented Aug 12, 2024

Removing the deploy blocker label because this is an edge case and typing in the composer shows up the expand button again.

@rlinoz rlinoz added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 12, 2024
@hannojg
Copy link
Contributor

hannojg commented Aug 14, 2024

Okay, will work on a fix today!

@hannojg
Copy link
Contributor

hannojg commented Aug 14, 2024

@kirillzyusko is helping with this ticket!

@kirillzyusko
Copy link
Contributor

Yep, feel free to assign it to me!

@kirillzyusko
Copy link
Contributor

I prepared a fix #47449

But since we updated RN to the latest version (0.75) earlier - this bug is not reproducible anymore:

Screen.Recording.2024-08-29.at.18.42.09.mov

@rlinoz @hannojg @lanitochka17 what are the next steps then? Should we re-test this issue on latest main and if it's not reproducible, then close the issue and close the PR?

@hannojg
Copy link
Contributor

hannojg commented Sep 4, 2024

Should we re-test this issue on latest main and if it's not reproducible, then close the issue and close the PR?

Yes, that sounds right!

@rlinoz
Copy link
Contributor

rlinoz commented Sep 9, 2024

Yep, just tested it in the latest app version and it works fine, let's close this one.

Thanks!

@rlinoz rlinoz closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants