[HOLD for payment 2024-08-09] [HOLD for payment 2024-08-01] [$250] CRITICAL: Native - Message stays in the Composer after being sent

[kacper-mikolajczak]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.47-10
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: N/A
Expensify/Expensify Issue URL:
Issue reported by: @kacper-mikolajczak
Slack conversation: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1709816920314349

Action Performed:

1. Open a report
2. Type and send messages one after another in fast manner

Expected Result:

Composer is emptied of old message after Send button is pressed, resulting in clean state whenever user wants to type new message.

Actual Result:

From time to time, Composer lags behind and old message is kept in the input.

Workaround:

Related issues:

#10148

#35225 (comment)

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

RPReplay_Final1709762923.mov

composer-lags-behind.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ec0505687d1ab91
• Upwork Job ID: 1807817457409282324
• Last Price Increase: 2024-07-01

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kacper-mikolajczak]

Replacing MarkdownInput with regular TextInput did not help.

markdown-input-replaced-with-text-input.mp4

[melvin-bot]

@muttmuure, @kacper-mikolajczak Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@muttmuure, @kacper-mikolajczak Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@muttmuure, @kacper-mikolajczak Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@muttmuure, @kacper-mikolajczak 10 days overdue. I'm getting more depressed than Marvin.

[muttmuure]

@kacper-mikolajczak is this still being worked on?

[kacper-mikolajczak]

Hi @muttmuure, sorry I am occupied with other tasks! For now I don't have a clear solution, but I would love to dig into that once I am free. Can we wait with final decision whether close the issue till Friday? Thanks a lot!

[muttmuure]

OK!

[kacper-mikolajczak]

Hi @muttmuure I want to let you know that I've been mostly involved in Monitoring setup and finishing the hasDraft PR and was not able to get back to this assignment.

I will continue with monitoring setup (and Control phase in general) next week, so let me know if you want to close or put on hold this issue, so we can get back to it later. Thanks a lot and have a nice peaceful weekend!

[muttmuure]

Let's put it on hold

[muttmuure]

Still held

[muttmuure]

Held

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Composer: add clear command that bypasses the event count #46091

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @hannojg does not require payment (Contractor)
• @kacper-mikolajczak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hannojg]

The last PR for fixing this was reverted. Working on a new one to fix the regression!

[hannojg]

Opened a new PR here:

• Composer: add clear command that bypasses the event count #46796

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @Ollyws owed $250 via NewDot
• Contributor: @hannojg is from an agency-contributor and not due payment

BugZero Checklist (@muttmuure)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1807817457409282324/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Ollyws]

This one is due for payment today, looking at the date that the last PR was deployed to producion.

[muttmuure]

How many PRs did you review? It seems like this should be more than $250

[Ollyws]

3 in total, as the first and second PRs were reverted.

[Ollyws]

Friendly bump @muttmuure

[muttmuure]

Handling

[muttmuure]

$750 for @Ollyws C+

[muttmuure]

Do we need a regression test for this one?

[Ollyws]

We could add the regression test:

1. Spam the 'a' key, typing 'aaaaaa...'
2. Press send
3. Spam the 'b' key, typing 'bbbbbb...'
4. Expect that the composer shows first 'aaaaaa', then clears it, then it shows 'bbbbbb'

[Ollyws]

Requested in ND.

[garrettmknight]

$750 approved for @Ollyws based on this comment