-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Update the workspace connected bank account page for clarity and consistency #47578
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01a8923a1af5c75af2 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Update the workspace connected bank account page for clarity and consistency (New design) What is the root cause of that problem?New design What changes do you think we should make in order to solve the problem?We need to update this Section Component
to
Also need to add new note (detai in the PR) What alternative solutions did you explore? (Optional) |
Edited by proposal-police: This proposal was edited at 2024-08-17T14:15:00Z. ProposalPlease re-state the problem that we are trying to solve in this issue.Add a note What is the root cause of that problem?Feature request What changes do you think we should make in order to solve the problem?We can add following styles here. We should conditionally render these styles and display this note only when the user has added a personal bank account. We can use this key to check if
We should also add the note in en.ts and es.ts file Further styles can be modified according to the design in the PR. We can update this section here. Additionally, I think we should add the illustrationBackgroundColor to align with the design.
Note As noted by a fellow contributor regarding the use of The main issue here is that we’re only checking App/src/components/Section/index.tsx Line 173 in 7615898
Additionally, I noticed that the design uses the same styles for 'Connect Manually' and 'Connect with Plaid'. Therefore, we should also update the styles for 'Connect with Plaid' to match. All the font sizes and other styles can be further adjusted in the pull request. What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Update the workspace connected bank account page for clarity and consistency [Design Update] What is the root cause of that problem?New Feature What changes do you think we should make in order to solve the problem?
<Section
title={translate("workspace.bankAccount.streamlinePayments")}
illustration={LottieAnimations.Coin}
isCentralPane
subtitle={translate("bankAccount.toGetStarted")}
subtitleMuted
></Section>;
<View
style={[
styles.flexRow,
styles.mv3,
styles.alignItemsStart,
styles.gap2,
styles.mln1,
]}
>
<Icon
src={Expensicons.Lightbulb}
height={variables.iconSizeLarge}
width={variables.iconSizeLarge}
fill={theme.icon}
additionalStyles={styles.p1}
/>
<Text style={[styles.textLabelSupporting, styles.textAlignLeft]}>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Eligendi fugiat
facilis nisi alias
</Text>
</View>; What alternative solutions did you explore? (Optional) |
Just adding a note that we do have an existing lottie animation to use in the top green area of the card, so it will match other places in our app (like in Settings) where the header area is animated. |
Looking at the timestamps of the proposal edits it seems that @BhuvaneshPatil had the first fully fleshed-out proposal so lets go with them. |
Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@Ollyws When @BhuvaneshPatil proposed the solution, the only difference between his proposal and mine was the usage of isCentralPane, which was incorrect in his proposal. The main difference between our proposals was indeed the usage of isCentralPane. I later pointed out the correct root cause analysis (RCA). Could you please review the proposal again? |
Hey @Ollyws, I wanted to clarify that |
@Nodebrute By looking at timestamps, when I posted my proposal, your proposal didn't mention about updating /adding |
@BhuvaneshPatil Hey, I missed that we were also supposed to add the illustration. I've since updated my code to include the illustrations, but my approach is quite different from yours. Just like in your proposal, it looks like you missed mentioning the 'Connect Online with Plaid' button |
Hey @Ollyws, here's a timeline of all the proposals:
|
Hi @Ollyws, just a gentle reminder to let me know your thoughts on this when you have a moment. Thanks! |
Hey, I'm just seeing this issue, but whoever works on this, can you please only make the new "Note" visible when the user has a personal bank account connected? I don't think the note needs to be visible if they haven't ever added a personal bank account and it could be just as confusing. |
Proposal updated with the new requested changes. |
@francoisl, @Ollyws Whoops! This issue is 2 days overdue. Let's get this updated quick! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Hi @Ollyws, can confirm the chosen proposal is still valid please, especially given the last request to only make the note visible after an account is connected, and also the discussion about using |
I still stand by my initial selection of @BhuvaneshPatil It was the first and only proposal that suggested adding all the required features including the illustration prop. @Nodebrute then built upon @BhuvaneshPatil’s proposal suggesting we further modify what is essentially the functionality of the As for this note, it was added after I had selected the proposal so it can be considered a note addressed to the selected contributor for consideration in their PR. |
📣 @BhuvaneshPatil 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Triggered auto assignment to @kadiealexander ( |
Adding the |
@francoisl, @Ollyws, @BhuvaneshPatil Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@francoisl @Ollyws @BhuvaneshPatil @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@trjExpensify I am facing trouble testing on IOS device. I will raise PR as soon as it works |
Have you taken your questions to #expensify-open-source to get some help on what's blocking you from testing on iOS? |
@BhuvaneshPatil - bump on Tom's question when you have a sec! #47578 (comment) |
PR is in review |
I think following up to fix that particular spot makes sense for consistency's sake. I also think something we missed when implementing this is that we should use our standard edge-to-edge push rows here. Right now we use the old "rounded pill" option row style which I think we should kill: CleanShot.2024-09-13.at.07.25.38.mp4The correct style looks like this: CleanShot.2024-09-13.at.07.26.46.mp4 |
@BhuvaneshPatil can you work on a PR to address Shawn's feedback please, and then tag Design for review? Thanks! |
Sure. I will raise the PR. @trjExpensify what do you think about this comment |
raised the PR, uploaded video for macos web. will update videos on other platforms next morning |
I agree with Shawn:
|
@trjExpensify @shawnborton PR is now merged 🎊 |
Great! |
Users are confused when they go to add a bank account to their workspace and cannot select their linked personal bank accounts. So let's add some explainer text that educates them on the need for a Business Bank Account. While we're at it, let's also update the page to our newest pattern for consistency.
Today
Update to
Final copy for the note:
cc @shawnborton @maddylewis @jamesdeanexpensify
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @OllywsThe text was updated successfully, but these errors were encountered: