-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Update Wallet and Generic Folder empty state to use lottie animations #48013
Comments
Triggered auto assignment to @anmurali ( |
|
Current assignee @shawnborton is eligible for the NewFeature assigner, not assigning anyone new. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Edited by proposal-police: This proposal was edited at 2024-08-26 17:21:01 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Update Wallet and Generic Folder empty state to use lottie animations What is the root cause of that problem?Improvement What changes do you think we should make in order to solve the problem?We need to add the animations in this file and update the props below: App/src/pages/Search/EmptySearchView.tsx Line 41 in 61aa0af
EmptyStateExpenses
We might also need to update several other props like App/src/pages/Search/EmptySearchView.tsx Line 55 in 61aa0af
What alternative solutions did you explore? (Optional)ResultMonosnap.screencast.2024-08-26.23-35-46.mp4 |
Proposal Updated
|
@Krishna2323 I think you missed a few spots where this change is needed, such as here. Please enumerate all the locations in the app where |
@roryabraham thanks, proposal updated, we also need to update in |
There's also a spot when creating reportFields that we have an empty list view as well. |
@shawnborton, you mean this illustration also, right? |
@shawnborton that illustration ^ is called |
Job added to Upwork: https://www.upwork.com/jobs/~0164ffd5b6f9684066 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 ( |
Yes, but I think the whole view should be replaced with the new empty state style that we see everywhere else. I think it was missed when we updated the empty state views for Search, Tags, etc. |
Proposal Updated
|
Optimized |
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Thanks for assigning. I will start working on it within an hour. |
I'll pop it in #wave-collect. 👍 |
We have some empty states in our product that are currently static, and we want to update them to have looping Lottie animations.
The first place is the Wallet empty state:
And the other place is anywhere we show the folder empty state, like Search or Workspaces > Tags, Workspaces > Report fields, etc:
Here are the lottie files needed:
cc @roryabraham @Expensify/design @luacmartins for visibility
@trjExpensify - I wonder if this is considered #wave-control polish or something?
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hungvu193The text was updated successfully, but these errors were encountered: