[$125] Update tasks in the Manage my team's expenses onboarding flow to include direct links to those workspace settings #424515

[danielrvidal]

Problem: Multiple tasks use the language "2. Go to [Workspaces > [your workspace]" in the task. We never meant for it to be [your workspace] because that just looks incorrect. After discussion, we're going to update the tasks so that they are not included. Here is what I'm talking about.

Solution: Update the text to remove [your workspace], while still giving the user full directions to train them and providing a link directly to where they can make the changes.

All of the Task titles would remain unchanged. The assignee would remain unchanged as well. Below is the updated text in the description of each task.

Set up categories

Set up categories so your team can code expenses for easy reporting.

Here’s how to set up categories:

1. Click your profile picture.
2. Go to Workspaces.
3. Select your workspace.
4. Click Categories.
5. Enable and disable default categories.
6. Click Add categories to make your own.
7. For more controls like requiring a category for every expense, click Settings.

Take me to workspace category settings.

Note: the link would direct the user to the categories section in the workspace editor of the workspace.

Add expense approvals

Add expense approvals to review your team’s spend and keep it under control.

Here’s how to add expense approvals:

1. Click your profile picture.
2. Go to Workspaces.
3. Select your workspace.
4. Click More features.
5. Enable Workflows.
6. In Workflows, enable Add approvals.
7. You’ll be set as the expense approver. You can change this to any admin once you invite your team.

Take me to enable more features.

Note: the link would direct the user to the more features section in the workspace editor of the workspace.

Invite your team

Invite your team to Expensify so they can start tracking expenses today.

Here’s how to invite your team:

1. Click your profile picture.
2. Go to Workspaces.
3. Select your workspace.
4. Click Members > Invite member.
5. Enter emails or phone numbers.
6. Add an invite message if you want.

Take me to workspace members. That’s it, happy expensing! :)

Note: the link would direct the user to the members section in the workspace editor of the workspace.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebd40facad6e93ad
• Upwork Job ID: 1829287796879757259
• Last Price Increase: 2024-08-29
• Automatic offers:
• gijoe0295 | Contributor | 103805341

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebd40facad6e93ad

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update tasks in the Manage my team's expenses onboarding flow

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

1. Update the copy accordingly

App/src/CONST.ts

Line 4279 in 1d48409

tasks: [

2. For the Take me to links, implement them like below, we already had the workspace and admin room links, just need to introduce new variables for each links and use them in the form of link markdown [name](url):

App/src/libs/actions/Report.ts

Lines 3372 to 3375 in 7be6144

	? task.description({
	adminsRoomLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID ?? '-1')}`,
	workspaceLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,
	})

App/src/CONST.ts

Line 4350 in 1d48409

description: ({workspaceLink}: {workspaceLink: string}) =>

App/src/CONST.ts

Line 4356 in 1d48409

`2. Go to [*Workspaces* > [your workspace]](${workspaceLink}).\n` +

[gijoe0295]

Update proposal

• Update code permalinks

[aimane-chnaif]

@danielrvidal looks like image in OP is broken
https://github.com/user-attachments/assets/390606e7-d5e4-480c-8f2d-393b66c3edc3

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update tasks in the Manage my team's expenses onboarding flow

What is the root cause of that problem?

Update requests

What changes do you think we should make in order to solve the problem?

1. Create workspaceCategoryLink, workspaceMoreFeatureLink, workspaceMembersLink and delete the workspaceLink since it will not be used any more
   Change this to the following:

                ? task.description({
                      adminsRoomLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID ?? '-1')}`,
                      workspaceCategoryLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.WORKSPACE_CATEGORIES.getRoute(onboardingPolicyID ?? '-1')}`,
                      workspaceMoreFeatureLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.WORKSPACE_MORE_FEATURES.getRoute(onboardingPolicyID ?? '-1')}`,
                      workspaceMembersLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.WORKSPACE_MEMBERS.getRoute(onboardingPolicyID ?? '-1')}`,
                  })

2. change task description for setupCategories, addExpenseApprovals and inviteTeam to the following

                {
                    type: 'setupCategories',
                    autoCompleted: false,
                    title: 'Set up categories',
                    description: ({workspaceCategoryLink}: {workspaceCategoryLink: string}) =>
                        '*Set up categories* so your team can code expenses for easy reporting.\n' +
                        '\n' +
                        'Here’s how to set up categories:\n' +
                        '\n' +
                        '1. Click your profile picture.\n' +
                        `2. Go to Workspaces.\n` +
                        '3. Select your workspace.\n' +
                        '4. Click *Categories*.\n' +
                        '5. Enable and disable default categories.\n' +
                        '6. Click *Add categories* to make your own.\n' +
                        '7. For more controls like requiring a category for every expense, click *Settings*.\n' +
                        '\n' +
                        `[Take me to workspace category settings](${workspaceCategoryLink}).`,
                },
                {
                    type: 'addExpenseApprovals',
                    autoCompleted: false,
                    title: 'Add expense approvals',
                    description: ({workspaceMoreFeatureLink}: {workspaceMoreFeatureLink: string}) =>
                        '*Add expense approvals* to review your team’s spend and keep it under control.\n' +
                        '\n' +
                        'Here’s how to add expense approvals:\n' +
                        '\n' +
                        '1. Click your profile picture.\n' +
                        `2. Go to Workspaces.\n` +
                        '3. Select your workspace.\n' +
                        '4. Click *More features*.\n' +
                        '5. Enable *Workflows*.\n' +
                        '6. In *Workflows*, enable *Add approvals*.\n' +
                        '7. You’ll be set as the expense approver. You can change this to any admin once you invite your team.\n' +
                        '\n' +
                        `[Take me to enable more features](${workspaceMoreFeatureLink}).`,
                },
                {
                    type: 'inviteTeam',
                    autoCompleted: false,
                    title: 'Invite your team',
                    description: ({workspaceMembersLink}: {workspaceMembersLink: string}) =>
                        '*Invite your team* to Expensify so they can start tracking expenses today.\n' +
                        '\n' +
                        'Here’s how to invite your team:\n' +
                        '\n' +
                        '1. Click your profile picture.\n' +
                        `2. Go to Workspaces.\n` +
                        '3. Select your workspace.\n' +
                        '4. Click *Members > Invite member*.\n' +
                        '5. Enter emails or phone numbers.\n' +
                        '6. Add an invite message if you want.\n' +
                        '\n' +
                        `[Take me to workspace members](${workspaceMembersLink}). That’s it, happy expensing! :)`,
                },

What alternative solutions did you explore? (Optional)

[anmurali]

@aimane-chnaif - bump for a review

[melvin-bot]

@aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aimane-chnaif]

reviewing

[danielrvidal]

Thanks @aimane-chnaif let us know if we need to help at all? Otherwise hopefully we can keep making progress today or tomorrow!

[aimane-chnaif]

@danielrvidal can you please share screenshot for this?

[aimane-chnaif]

This is straightforward and we can go with first submitter @gijoe0295
Proposal: #48294 (comment)
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[danielrvidal]

@aimane-chnaif does this image not work for you? It's showing up for me.

[aimane-chnaif]

That image works. Thanks

[danielrvidal]

Nice, I tested on staging and it looks great!

[gijoe0295]

Hmm I wonder why this has not reach production yet.

[anmurali]

Same. @danielrvidal you need to investigate

[danielrvidal]

Just commented on the PR because I think it actually live on production. I'll report back.

[marcaaron]

Pretty sure this is on production and Melvin did not leave a comment for some reason.

[gijoe0295]

@anmurali The deploy checklist containing this issue was closed on Sep 9 #48664 (comment). So I think we're already due for payment.

[anmurali]

Payment summary

• Contributor @gijoe0295 $125 approved via Upwork
• Contributor plus @aimane-chnaif $125 approved via New Dot

[aimane-chnaif]

I am still using upwork

[anmurali]

@aimane-chnaif - offer is here