Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVP] Bottom Up - iOS Safari - first name field is focused, but keyboard not open on the "What's your name?" page #48333

Closed
1 of 6 tasks
trjExpensify opened this issue Aug 30, 2024 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Aug 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.26-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C05E8R5K55K/p1725026086476479?thread_ts=1725025982.019969&cid=C05E8R5K55K (internal)

Action Performed:

  1. Sign-up on newDot with a new account
  2. Choose the manage my teams expenses onboarding intent
  3. Observe the business name field is focused and the keyboard is open
  4. Click the back caret <
  5. Choose the "get paid back by my employer" intent
  6. Observe the first name field is focused but the keyboard is not open

Expected Result:

When the first name field is focused, the keyboard should be open.

Actual Result:

The first name field is focused, but the keyboard is not open.

Workaround:

Yes, tap the field to bring up the keyboard.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

RPReplay_Final1725025978.MP4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abdulrahuman5196
@trjExpensify trjExpensify added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 30, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 30, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

Copy link

melvin-bot bot commented Aug 30, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dominictb
Copy link
Contributor

dominictb commented Aug 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first name field is focused, but the keyboard is not open.

What is the root cause of that problem?

On iOS, focus() within setTimeout or delay may not bring the keyboard show up

What changes do you think we should make in order to solve the problem?

Enable autoFocus in BaseOnboardingPersonalDetails here same as what we already did in BaseOnboardingWork

What alternative solutions did you explore? (Optional)

Check other places if needed

@trjExpensify
Copy link
Contributor Author

@abdulrahuman5196 what do you think about this proposal?

@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
@abdulrahuman5196
Copy link
Contributor

Hi will check today

@melvin-bot melvin-bot bot removed the Overdue label Sep 2, 2024
@trjExpensify
Copy link
Contributor Author

Thanks you!

@abdulrahuman5196
Copy link
Contributor

@trjExpensify Are you able to reproduce the issue? Seems to be working fine for me.

Screen.Recording.2024-09-03.at.12.44.17.AM.mov

@trjExpensify
Copy link
Contributor Author

Yup! Physical device, iPhone 15 Pro (iOS 17.6.1).

RPReplay_Final1725306778.MP4

Copy link

melvin-bot bot commented Sep 6, 2024

@trjExpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2024
@abdulrahuman5196
Copy link
Contributor

Checking again

@melvin-bot melvin-bot bot removed the Overdue label Sep 6, 2024
@trjExpensify
Copy link
Contributor Author

Thanks!

@trjExpensify
Copy link
Contributor Author

@abdulrahuman5196 did you check?

@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@abdulrahuman5196
Copy link
Contributor

Not yet. I haven't been able to find how to test dev web in real iPhone's device. Checking with team on the same - https://expensify.slack.com/archives/C02NK2DQWUX/p1725898604633999

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@trjExpensify
Copy link
Contributor Author

Cool, thanks for escalating to Slack!

@abdulrahuman5196
Copy link
Contributor

abdulrahuman5196 commented Sep 11, 2024

Found way to test in physical device.
@trjExpensify In my iphone safari, the keyboard doesn't pop up for any input. Attaching the video here.
iPhone 12, 17.6.1

ios.mov

Sometime back I remember seeing an issue where focus is not working on safari properly. Not sure if that was solved. But couldn't find that issue, will check in our slack as well if this is something we should solve here.

Slack thread - https://expensify.slack.com/archives/C02NK2DQWUX/p1726080852534069

Copy link

melvin-bot bot commented Sep 13, 2024

@trjExpensify @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@trjExpensify
Copy link
Contributor Author

Found way to test in physical device.
@trjExpensify In my iphone safari, the keyboard doesn't pop up for any input. Attaching the video here.
iPhone 12, 17.6.1

But we include autoFocus on the one page and not the other in this flow, so for the devices this does work for that makes it an inconsistent bug, right?

@melvin-bot melvin-bot bot added the Overdue label Sep 17, 2024
@trjExpensify
Copy link
Contributor Author

trjExpensify commented Sep 17, 2024

#48333 (comment) - did you check this solution on a physical iPhone device using Safari, @dominictb? Can you include a vid, please.

@abdulrahuman5196
Copy link
Contributor

#48333 (comment) - did you check this solution on a physical iPhone device using Safari, @dominictb? Can you include a vid, please.

And FYI seems the autoFocus is removed in theBaseOnboardingWork due to some issue #48137 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@trjExpensify
Copy link
Contributor Author

Cool, so @dominictb. Bump on this!

#48333 (comment) - did you check this solution on a physical iPhone device using Safari, @dominictb? Can you include a vid, please.

Copy link

melvin-bot bot commented Sep 20, 2024

@trjExpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2024
@trjExpensify
Copy link
Contributor Author

@dominictb still awaiting a vid for confirmation here.

@dominictb
Copy link
Contributor

I'm trying to build on Physical device. will update soon

@dominictb
Copy link
Contributor

@trjExpensify My solution doesn't work on Safari Physical device. Do you think it's ios behavior to prevent showing keyboard programmatically?

Copy link

melvin-bot bot commented Sep 24, 2024

@trjExpensify, @abdulrahuman5196 Still overdue 6 days?! Let's take care of this!

@trjExpensify
Copy link
Contributor Author

@trjExpensify My solution doesn't work on Safari Physical device. Do you think it's ios behavior to prevent showing keyboard programmatically?

Got it. Then yes, this sounds like the inconsistent upstream bug with mWeb safari we've (unsuccessfully) fought before.

@abdulrahuman5196
Copy link
Contributor

Got it. Then yes, this sounds like the inconsistent upstream bug with mWeb safari we've (unsuccessfully) fought before.

Yep. I think we should close this one IMO. @trjExpensify

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2024
@trjExpensify
Copy link
Contributor Author

Yep, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Development

No branches or pull requests

3 participants