Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-09-24][$1250] [Search v2.3] [App] Update the advanced filters view #48453

Closed
lakchote opened this issue Sep 3, 2024 · 31 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lakchote
Copy link
Contributor

lakchote commented Sep 3, 2024

We need to update Search's advanced filters view to include the Save Search functionality.

More details here

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021838573229478534392
  • Upwork Job ID: 1838573229478534392
  • Last Price Increase: 2024-09-24
Issue OwnerCurrent Issue Owner: @sakluger
@lakchote lakchote moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Sep 3, 2024
@lakchote lakchote changed the title [Search v2.3] [App] Update the advanced filters view [HOLD Auth #425359] [Search v2.3] [App] Update the advanced filters view Sep 3, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Sep 10, 2024
@lakchote lakchote changed the title [HOLD Auth #425359] [Search v2.3] [App] Update the advanced filters view [Search v2.3] [App] Update the advanced filters view Sep 10, 2024
Copy link

melvin-bot bot commented Sep 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor

This is done.

@github-project-automation github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in [#whatsnext] #expense Sep 19, 2024
@jjcoffee
Copy link
Contributor

@luacmartins Just noticed that no payment issue was created from the PR that I reviewed as C+. Should we reopen this issue and add the Bug label to track payment?

@lakchote lakchote reopened this Sep 19, 2024
@lakchote lakchote added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 19, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.3] [App] Update the advanced filters view [$250] [Search v2.3] [App] Update the advanced filters view Sep 24, 2024
Copy link

melvin-bot bot commented Sep 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021838573229478534392

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 24, 2024
Copy link

melvin-bot bot commented Sep 24, 2024

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 24, 2024
@luacmartins luacmartins changed the title [$250] [Search v2.3] [App] Update the advanced filters view [HOLD for payment 2024-09-24][$1250] [Search v2.3] [App] Update the advanced filters view Sep 24, 2024
Copy link

melvin-bot bot commented Sep 24, 2024

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

Copy link

melvin-bot bot commented Sep 24, 2024

Upwork job price has been updated to $1250

@luacmartins luacmartins removed Reviewing Has a PR in review Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 24, 2024
@sakluger
Copy link
Contributor

@luacmartins I'm assuming you intended to change the price to $125 instead of $1250.

@sakluger sakluger changed the title [HOLD for payment 2024-09-24][$1250] [Search v2.3] [App] Update the advanced filters view [HOLD for payment 2024-09-24][$125] [Search v2.3] [App] Update the advanced filters view Sep 24, 2024
Copy link

melvin-bot bot commented Sep 24, 2024

Upwork job price has been updated to $125

@sakluger
Copy link
Contributor

@jjcoffee here's the Upwork offer: https://www.upwork.com/nx/wm/offer/104108657. Let me know once you've accepted.

Do you think we need to add regression tests for this?

Copy link

melvin-bot bot commented Sep 24, 2024

Payment Summary

Upwork Job

BugZero Checklist (@sakluger)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1838573229478534392/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@luacmartins
Copy link
Contributor

@sakluger please check out this comment. The PR linked to this issue was quite large and solved 5 issues, so we decided to handle compensation for all 5 issues here, so the amount is $1250.

@luacmartins luacmartins changed the title [HOLD for payment 2024-09-24][$125] [Search v2.3] [App] Update the advanced filters view [HOLD for payment 2024-09-24][$1250] [Search v2.3] [App] Update the advanced filters view Sep 24, 2024
Copy link

melvin-bot bot commented Sep 24, 2024

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

Copy link

melvin-bot bot commented Sep 24, 2024

Upwork job price has been updated to $1250

@sakluger
Copy link
Contributor

sakluger commented Sep 25, 2024

@luacmartins thanks for the context! I mssed that comment, and most of our issues pay $250 or $125, so I assumed it was a typo.

@jjcoffee sorry for the confusion. Here is the new offer: https://www.upwork.com/nx/wm/offer/104115502

@luacmartins
Copy link
Contributor

Np! all good

@jjcoffee
Copy link
Contributor

@sakluger No worries, offer accepted!

@sakluger
Copy link
Contributor

Paid!

@jjcoffee do we need to add any new regression test steps before closing this issue, or is that being handled elsewhere?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Sep 25, 2024
@luacmartins
Copy link
Contributor

We'll handle it as part of the project wrap up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

4 participants