Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-25] [HOLD for payment 2024-10-17] [$250] Sign in - Account settings long loading if navigate via public room link & login as new account #48715

Closed
2 of 6 tasks
lanitochka17 opened this issue Sep 6, 2024 · 60 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Hot Pick Ready for an engineer to pick up and run with

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.30-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ponikarchuks+106924@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #48144

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log out
  3. Go to this link https://staging.new.expensify.com/r/7075912447943023
  4. Tap sign in
  5. Enter credentials and log in as a new Gmail account

Expected Result:

Account settings loads fine

Actual Result:

Account settings long loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6595301_1725625415082.A_clear_anonymous_user_records_after_login.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836652520479378795
  • Upwork Job ID: 1836652520479378795
  • Last Price Increase: 2024-09-26
  • Automatic offers:
    • wildan-m | Contributor | 104259835
Issue OwnerCurrent Issue Owner: @thesahindia
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@bfitzexpensify
Copy link
Contributor

Checking in on the other issue here

@bfitzexpensify
Copy link
Contributor

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: confirming if the other PR caused this

@bfitzexpensify bfitzexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

@bfitzexpensify bfitzexpensify removed their assignment Sep 6, 2024
@bfitzexpensify bfitzexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@bfitzexpensify bfitzexpensify self-assigned this Sep 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@jjcoffee
Copy link
Contributor

jjcoffee commented Sep 9, 2024

This doesn't appear to be related to #47806 - I can repro with the changes from there reverted. It's probably a BE issue as there are no personalDetails returned in the SignUpUser call.

Copy link

melvin-bot bot commented Sep 9, 2024

@bfitzexpensify, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@VictoriaExpensify
Copy link
Contributor

Thanks for confirming @jjcoffee . I'm going to move this to internal since this sounds like a BE issue

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2024
@VictoriaExpensify VictoriaExpensify added Internal Requires API changes or must be handled by Expensify staff Hot Pick Ready for an engineer to pick up and run with labels Sep 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2024
@VictoriaExpensify
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
@trjExpensify
Copy link
Contributor

Is this bug specific to the public rooms flow and on Android native only? If so, that was a project in #vip-vsb, and I think @jasperhuangg might be good to offer insight into that.

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2024
@jasperhuangg
Copy link
Contributor

jasperhuangg commented Sep 19, 2024

@jjcoffee The SignUpUser command isn't in charge of returning personal details, ReconnectApp/OpenApp is.

cc @marcochavezf IIRC you implemented this flow, it seems like we're not calling ReconnectApp when the user is signed in from the public room, which I think could be preventing us from loading their personal details.

Screenshot 2024-09-19 at 2 18 21 PM

Under normal circumstances when we sign up a new user we do call it:
Screenshot 2024-09-19 at 2 21 36 PM

So I believe this issue lies in the front-end and can be worked on externally, I think we just need to figure out why we're not calling ReconnectApp for that particular flow.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 12, 2024
@bfitzexpensify bfitzexpensify added Daily KSv2 and removed Weekly KSv2 labels Oct 16, 2024
@bfitzexpensify
Copy link
Contributor

Waiting on regressions to be resolved before issuing payment

@melvin-bot melvin-bot bot added Daily KSv2 Weekly KSv2 and removed Daily KSv2 labels Oct 17, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-10-17] [$250] Sign in - Account settings long loading if navigate via public room link & login as new account [HOLD for payment 2024-10-25] [HOLD for payment 2024-10-17] [$250] Sign in - Account settings long loading if navigate via public room link & login as new account Oct 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 18, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
  • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@thesahindia] Determine if we should create a regression test for this bug.
  • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@bfitzexpensify bfitzexpensify added Daily KSv2 and removed Weekly KSv2 labels Oct 23, 2024
@bfitzexpensify
Copy link
Contributor

Payment to @wildan-m complete (paid out at $125 due to the regression).

@thesahindia, please complete the BZ checklist and I'll post the NewDot payment summary

@wildan-m
Copy link
Contributor

@bfitzexpensify why there is penalty?

no 50% urgency bonus when we merge within 3 days and penalty also removed based on the announcement

https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1698191269281379?thread_ts=1698191269.281379&cid=C01GTK53T8Q

@bfitzexpensify
Copy link
Contributor

@wildan-m we removed the time-based penalties that came from not merging a PR within 216 hours of assignment.

There was no change to the regression penalties, which dock 50% of the pay when a regression is caused.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Oct 25, 2024

There was no change to the regression penalties, which dock 50% of the pay when a regression is caused.

Does this apply if the same contributor fixed the regression here #50629 ?

Update: hmm I see now that the original PR was reverted and the @wildan-m put the new PR to fix without the regression. I have no idea how the penalties work and I'm just asking out of curiosity by the way :)

@bfitzexpensify
Copy link
Contributor

This is what we say in the CONTRIBUTING.md:

Regressions
If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

  • payments will be issued 7 days after all regressions are fixed (ie: deployed to production)
  • a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue

The 168 hours (aka 7 days) will be measured by calculating the time between when the PR is merged, and when a bug is posted to the #expensify-bugs Slack channel.

So the penalty is applied regardless of who resolves the regression.

@bfitzexpensify
Copy link
Contributor

Also bumping the BZ checklist @thesahindia - thank you!

@thesahindia
Copy link
Member

I don't think we can pin point an exact PR that is responsible for this issue.

We should add a test case. Here are the steps for it:

  1. Log out if you're signed in
  2. Go to https://staging.new.expensify.com/r/7075912447943023
  3. Click 'Sign in'
  4. Enter a new email id and log in as a new account
  5. Select any option and complete the flow
  6. Verify that the loading is complete and the app is responsive.
  7. Verify that you are at the initially opened report

@bfitzexpensify
Copy link
Contributor

Payment summary:

@thesahindia due $125 for C+ work

@melvin-bot melvin-bot bot added the Overdue label Nov 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

@lakchote @bfitzexpensify Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Hot Pick Ready for an engineer to pick up and run with
Projects
No open projects
Status: No status
Development

No branches or pull requests

10 participants