-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-25] [HOLD for payment 2024-10-17] [$250] Sign in - Account settings long loading if navigate via public room link & login as new account #48715
Comments
Triggered auto assignment to @bfitzexpensify ( |
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Checking in on the other issue here |
I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence. Current status: confirming if the other PR caused this |
Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new. |
Triggered auto assignment to @VictoriaExpensify ( |
This doesn't appear to be related to #47806 - I can repro with the changes from there reverted. It's probably a BE issue as there are no |
@bfitzexpensify, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Thanks for confirming @jjcoffee . I'm going to move this to internal since this sounds like a BE issue |
Not overdue |
Is this bug specific to the public rooms flow and on Android native only? If so, that was a project in #vip-vsb, and I think @jasperhuangg might be good to offer insight into that. |
@jjcoffee The cc @marcochavezf IIRC you implemented this flow, it seems like we're not calling ReconnectApp when the user is signed in from the public room, which I think could be preventing us from loading their personal details. Under normal circumstances when we sign up a new user we do call it: So I believe this issue lies in the front-end and can be worked on externally, I think we just need to figure out why we're not calling |
Waiting on regressions to be resolved before issuing payment |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-25. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment to @wildan-m complete (paid out at $125 due to the regression). @thesahindia, please complete the BZ checklist and I'll post the NewDot payment summary |
@bfitzexpensify why there is penalty? no 50% urgency bonus when we merge within 3 days and penalty also removed based on the announcement |
@wildan-m we removed the time-based penalties that came from not merging a PR within 216 hours of assignment. There was no change to the regression penalties, which dock 50% of the pay when a regression is caused. |
Does this apply if the same contributor fixed the regression here #50629 ? Update: hmm I see now that the original PR was reverted and the @wildan-m put the new PR to fix without the regression. I have no idea how the penalties work and I'm just asking out of curiosity by the way :) |
This is what we say in the CONTRIBUTING.md:
So the penalty is applied regardless of who resolves the regression. |
Also bumping the BZ checklist @thesahindia - thank you! |
I don't think we can pin point an exact PR that is responsible for this issue. We should add a test case. Here are the steps for it:
|
Payment summary: @thesahindia due $125 for C+ work |
@lakchote @bfitzexpensify Be sure to fill out the Contact List! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.30-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ponikarchuks+106924@gmail.com
Issue reported by: Applause - Internal Team
Issue found when executing PR #48144
Action Performed:
Expected Result:
Account settings loads fine
Actual Result:
Account settings long loading
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6595301_1725625415082.A_clear_anonymous_user_records_after_login.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @thesahindiaThe text was updated successfully, but these errors were encountered: