-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-25] [$250] Onboarding - New user lands on workspace chat when 'Manage my team's expenses' selected in modal #50578
Comments
Triggered auto assignment to @MarioExpensify ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Our PR touched the onboarding flow recently, looking into it.. will update in sometime! @MarioExpensify |
@twilight294 , please check on your end too, if this is a regression from our PR, you need to fix it too |
@MarioExpensify I reverted our PR and tested it here, but the bug is still reproducible, so not related to our PR, but i would love to help you on this one, I will stay subscribed to this thread: Screen.Recording.2024-10-10.at.8.08.46.PM.mov |
Trying to track down which PR caused the issue right now |
Cool, our was |
Crap, it did anyway 💢 |
Still haven't been able to come up with a fix for this one, @allgandalf feel free to hop in |
Job added to Upwork: https://www.upwork.com/jobs/~021844427822228964480 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 ( |
Edited by proposal-police: This proposal was edited at 2024-10-10 17:56:10 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace chat is displayed What is the root cause of that problem?This comes from #50278 We always navigate to the last accessed report here. In this case when we select
What changes do you think we should make in order to solve the problem?I checked and this logic is used when the user signs in with a public room. Then we can check if the
What alternative solutions did you explore? (Optional)Or we can always navigate to the concierge chat as we do in the past |
We are reverting the offending PR here: #50596 |
Given that the offending PR was reverted, this issue should be fixed - not an issue anymore. |
Hi, does anyone know why I have different flow? I've overridden canUseAllBetas, but it remains different. cc: @thesahindia, @lakchote Kapture.2024-10-11.at.10.23.32.mp4 |
You didn't use a gmail account to sign up. It's written in the issue's reproduction steps. |
@lakchote I've tried using gmail, but its flow still different compared to the reproduction steps above. And can't reproduce the issue even when my prev PR applied. Kapture.2024-10-11.at.15.22.35.mp4 |
I'll close the issue, feel free to continue the discussion in it, it is just to clear up my K2. |
@MarioExpensify please do not close it, as we still have a discussion ongoing and the problem hasn't found resolution yet. If it's to clear up your K2, just unassign yourself. Thanks! |
@wildan-m yes I've been able to reproduce (on your original PR's branch): Screen.Recording.2024-10-11.at.18.10.24.mov |
Ok so it is reproducible when we test on the original PR branch, but after the new changes made by #49161 it's not reproducible anymore. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-25. 🎊 For reference, here are some details about the assignees on this issue:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.47-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5070660
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Either Concierge chat or LHN should be displayed
Actual Result:
Workspace chat is displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6630791_1728569605765.OHBK2619.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ikevin127The text was updated successfully, but these errors were encountered: