feat: add employee and accounting page to onboarding flow #49161

nkdengineer · 2024-09-13T10:45:29Z

Details

Fixed Issues

$ #48745
PROPOSAL: #48745 (comment)

Tests

Login with a new account
In the first onboarding step choose Manage my team's expenses
Verify that the employee step appears with the correct style as design
Select an option and go to the next page
Verify that the accounting step appears with the correct style as design

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Login with a new account
In the first onboarding step choose Manage my team's expenses
Verify that the employee step appears with the correct style as design
Select an option and go to the next page
Verify that the accounting step appears with the correct style as design

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-16.at.15.30.48.mov

Android: mWeb Chrome

Screen.Recording.2024-09-16.at.15.27.18.mov

iOS: Native

Screen.Recording.2024-09-16.at.15.31.36.mov

iOS: mWeb Safari

Screen.Recording.2024-09-16.at.15.26.16.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-16.at.15.20.11.mov

MacOS: Desktop

Screen.Recording.2024-09-16.at.15.34.54.mov

melvin-bot · 2024-09-16T09:14:06Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-09-16T09:19:29Z

@dubielzyk-expensify what are your thoughts on the "Connect your accounting..." text below the headline?

I am thinking it should be bigger (in our normal font size, 15px) and maybe a bit more margin below it and above the options?

src/components/SelectionList/OnboardingListItem.tsx

s77rt · 2024-09-16T12:15:12Z

The font size is not consistent

Screen.Recording.2024-09-16.at.1.14.10.PM.mov

src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

dubielzyk-expensify · 2024-09-17T03:38:30Z

I am thinking it should be bigger (in our normal font size, 15px) and maybe a bit more margin below it and above the options?

Agree. In the mocks I've specified it as text which is our regular body 15px font size. I also have 20px margin between the text and the accounting options so let's use that

dubielzyk-expensify · 2024-09-17T03:42:00Z

The font size is not consistent

Agreed. All headlines should be the same here.

Also the padding here is off on @s77rt 's recording:

The text should all line up vertically on the left like so:

We use 32px padding on desktop modals and 20px on mobile :)

nkdengineer · 2024-09-17T03:55:43Z

Also the padding here is off on @s77rt 's recording:
The text should all line up vertically on the left like so:

This bug is fixed on the latest code.

nkdengineer · 2024-09-17T04:08:21Z

The font size is not consistent

Oh, that is the font-size that we use in the onboarding work step and I used this when creating new pages.

nkdengineer · 2024-09-17T04:15:44Z

@dubielzyk-expensify How about the spacing between the title and the description in the accounting step? Is it also 20px?

nkdengineer · 2024-09-17T04:22:18Z

Update two screenshots for desktop and mobile.

Screen.Recording.2024-09-17.at.11.20.45.mov

Screen.Recording.2024-09-17.at.11.21.47.mov

dubielzyk-expensify · 2024-09-17T04:46:43Z

The padding between the headline and the text should be 12px. Like so:

It looks a bit too big in the screenshots above

nkdengineer · 2024-09-17T05:38:31Z

Updated.

Screen.Recording.2024-09-17.at.12.37.48.mov

Screen.Recording.2024-09-17.at.12.37.31.mov

nkdengineer · 2024-10-08T19:26:30Z

@s77rt I updated.

src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

s77rt · 2024-10-09T01:41:17Z

src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

+                    if (!onboardingPolicyID) {
+                        const {adminsChatReportID, policyID} = Policy.createWorkspace(undefined, true);
+                        Welcome.setOnboardingAdminsChatReportID(adminsChatReportID);
+                        Welcome.setOnboardingPolicyID(policyID);
+                    }


Since we are not going to use the policy in between steps is there any reason that we create the workspace at that early step? Why not create it just before calling completeOnboarding in the accounting step?

Interesting. Did you have any concern about that or opinion on why it would be better to do one over the other?

No strong preference it's just a little questionable that we create the workspace when not really needed yet. Now I think about it more I think we may have a bug:

Login as a new user

On the onboarding flow, select purpose to manage team <-- This will create a workspace

Logout

Login in again

If you try to complete the onboarding flow you will be creating another workspace since onboardingPolicyID is not on onyx

cc @nkdengineer Can you please confirm if you can reproduce this bug?

Oh hmm that's an interesting edge case for sure - I'm not sure how we would completely solve that without designating a specific policy as the "onboarding policy". Though we could potentially check if a user has an existing policy.

Fixing the problem highlighted in #50759 may fix this as I think we will have to send the policy id from the backend

src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

s77rt · 2024-10-09T19:35:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

marcaaron · 2024-10-09T21:38:54Z

Sorry, @nkdengineer. Changes look great, but we have conflicts now.

nkdengineer · 2024-10-10T07:24:53Z

@marcaaron I updated.

marcaaron · 2024-10-10T20:26:39Z

Conflicts again.

nkdengineer · 2024-10-10T20:29:57Z

@marcaaron I resolved.

marcaaron

Looking great! Thanks for your patience and hard work here. And great review as always @s77rt 🙇

OSBotify · 2024-10-10T20:58:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-10T23:10:47Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2024-10-11T00:04:38Z

@nkdengineer are you working on adding the task next? Just making sure you are aware of that part of this ticket. Please let me know.

marcaaron · 2024-10-14T23:42:38Z

Heads up that there is another bug that we found concerning the signup flow between OldDot and NewDot. Because we have a flow where we set the signupQualifier before the user arrives at this flow. We will then skip the step that creates the policy.

I'm going to be working on that one because it essentially blocks the deploy since we can't release a version of the app where this policy doesn't get created.

github-actions · 2024-10-15T03:16:29Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.48-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkdengineer added 6 commits September 13, 2024 17:44

feat: add employee and accounting page to onboarding flow

accc8a1

fix ts error

419f7cc

Merge branch 'main' into fix/48745

88dda39

add OnboadingListItem

6bdf7ed

fix test

e0bc748

add offline indicator and fix ts bug

de74800

nkdengineer marked this pull request as ready for review September 16, 2024 09:14

nkdengineer requested review from a team as code owners September 16, 2024 09:14

melvin-bot bot requested review from s77rt and removed request for a team September 16, 2024 09:14

nkdengineer mentioned this pull request Sep 16, 2024

[HOLD for payment 2024-11-13] [HOLD for payment 2024-10-22] [$250] Ask our admin leads qualifying questions in Stage 1 and trigger "set up accounting integration" task #48745

Closed

s77rt suggested changes Sep 16, 2024

View reviewed changes

src/components/SelectionList/OnboardingListItem.tsx Outdated Show resolved Hide resolved

marcaaron self-requested a review September 16, 2024 20:34

marcaaron assigned nkdengineer Sep 16, 2024

marcaaron requested changes Sep 16, 2024

View reviewed changes

src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into fix/48745

5f75726

fix the font-size issue

a37009d

decrease spacing between title and description

d72dec2

update confirm button to continue button

4516b4d

nkdengineer added 2 commits October 9, 2024 02:39

fix ts error

aab3ad8

remove unused variable

9985e88

s77rt reviewed Oct 9, 2024

View reviewed changes

src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx Outdated Show resolved Hide resolved

s77rt suggested changes Oct 9, 2024

View reviewed changes

nkdengineer added 4 commits October 9, 2024 16:52

Merge branch 'main' into fix/48745

7bba26c

remove onboaring work

7fb12f0

merge main

433261c

remove import type

f806fde

s77rt approved these changes Oct 9, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron October 9, 2024 19:37

merge main

3584504

merge main

bd6b524

marcaaron approved these changes Oct 10, 2024

View reviewed changes

marcaaron merged commit 476d112 into Expensify:main Oct 10, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 10, 2024

Deploy Checklist: New Expensify 2024-10-10 #50603

Closed

38 tasks

thesahindia mentioned this pull request Oct 11, 2024

[HOLD for payment 2024-10-25] [$250] Onboarding - New user lands on workspace chat when 'Manage my team's expenses' selected in modal #50578

Closed

6 tasks

s77rt mentioned this pull request Oct 11, 2024

[$250] Accounting tab appears then disappears after selecting an integration during onboarding #50637

Closed

6 tasks

marcaaron mentioned this pull request Dec 12, 2024

Move Workspace creation in the onboardingFlow to OnboardingPurpose page and skip Workspace creation for OD signups #53729

Open

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add employee and accounting page to onboarding flow #49161

feat: add employee and accounting page to onboarding flow #49161

nkdengineer commented Sep 13, 2024 •

edited

Loading

melvin-bot bot commented Sep 16, 2024

shawnborton commented Sep 16, 2024

s77rt commented Sep 16, 2024 •

edited

Loading

dubielzyk-expensify commented Sep 17, 2024

dubielzyk-expensify commented Sep 17, 2024 •

edited

Loading

nkdengineer commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

dubielzyk-expensify commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

nkdengineer commented Oct 8, 2024

s77rt Oct 9, 2024

marcaaron Oct 10, 2024

s77rt Oct 10, 2024

marcaaron Oct 14, 2024

s77rt Oct 15, 2024

s77rt commented Oct 9, 2024

marcaaron commented Oct 9, 2024

nkdengineer commented Oct 10, 2024

marcaaron commented Oct 10, 2024

nkdengineer commented Oct 10, 2024

marcaaron left a comment

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

marcaaron commented Oct 11, 2024

marcaaron commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

feat: add employee and accounting page to onboarding flow #49161

feat: add employee and accounting page to onboarding flow #49161

Conversation

nkdengineer commented Sep 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 16, 2024

shawnborton commented Sep 16, 2024

s77rt commented Sep 16, 2024 • edited Loading

dubielzyk-expensify commented Sep 17, 2024

dubielzyk-expensify commented Sep 17, 2024 • edited Loading

nkdengineer commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

dubielzyk-expensify commented Sep 17, 2024

nkdengineer commented Sep 17, 2024

nkdengineer commented Oct 8, 2024

s77rt Oct 9, 2024

Choose a reason for hiding this comment

marcaaron Oct 10, 2024

Choose a reason for hiding this comment

s77rt Oct 10, 2024

Choose a reason for hiding this comment

marcaaron Oct 14, 2024

Choose a reason for hiding this comment

s77rt Oct 15, 2024

Choose a reason for hiding this comment

s77rt commented Oct 9, 2024

Reviewer Checklist

Screenshots/Videos

marcaaron commented Oct 9, 2024

nkdengineer commented Oct 10, 2024

marcaaron commented Oct 10, 2024

nkdengineer commented Oct 10, 2024

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

marcaaron commented Oct 11, 2024

marcaaron commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

nkdengineer commented Sep 13, 2024 •

edited

Loading

s77rt commented Sep 16, 2024 •

edited

Loading

dubielzyk-expensify commented Sep 17, 2024 •

edited

Loading