[CP Staging] Create workspace when new user signs up, selects the "Manage my team's expenses" option and completes the "employee" step #50759

marcaaron · 2024-10-15T00:40:36Z

Details

Fixes a Deploy Blocker issue where users get redirected from OldDot to NewDot after selecting "Manage my team's expenses" onboarding option and no workspace is created for them. This will ensure the workspace is created in the "employees" step vs. the "intent" step (since this OldDot flow is skipping that step).

cc @s77rt @nkdengineer we are going to have to fix this in the API layer. The desired behavior is to create the workspace when the user navigates from OldDot, but will take some time to implement on the backend.

Fixed Issues

$ #50758

PROPOSAL:

Moving the call to the employees question step is a temporary fix so that the flow can continue working while we come up with a better fix in the BE.

Tests

Go to OldDot web
Select the "Manage my team's expenses" from the sign in page
Create the account by pressing the "Join" button
Click through the onboarding step which asks how many employees the user has.
Verify a workspace is created at this point.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

2024-10-14_14-54-29.mp4

MacOS: Desktop

…ves with a vsb intent in the url

melvin-bot · 2024-10-15T00:40:41Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron · 2024-10-15T00:41:36Z

@thesahindia this might be tricky to test since it requires being able to test the flow from old to new. I will request and internal reviewer.

srikarparsi · 2024-10-15T01:22:51Z

Screen.Recording.2024-10-14.at.9.21.31.PM.mov

I have to click the number of employees twice to proceed. Does that happen for you as well @marcaaron?

Slack thread

srikarparsi · 2024-10-15T01:31:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2024-10-14.at.9.21.31.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-10-15T01:43:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ldDotRedirect [CP Staging] Create workspace when new user signs up, selects the "Manage my team's expenses" option and completes the "employee" step (cherry picked from commit 0167316) (CP triggered by marcaaron)

…g-50759-1 🍒 Cherry pick PR #50759 to staging 🍒

github-actions · 2024-10-15T02:45:26Z

🚀 Cherry-picked to staging by https://github.com/srikarparsi in version: 9.0.48-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-10-15T03:17:40Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.48-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron added 3 commits October 14, 2024 13:24

Create policy when redirecting past the intent step and the user arri…

cc659e8

…ves with a vsb intent in the url

Move the policy creation to the employees step

fd01c72

Remove unneeded stuff

bff8e00

marcaaron self-assigned this Oct 15, 2024

marcaaron requested a review from a team as a code owner October 15, 2024 00:40

melvin-bot bot requested a review from thesahindia October 15, 2024 00:40

melvin-bot bot removed the request for review from a team October 15, 2024 00:40

marcaaron removed the request for review from thesahindia October 15, 2024 00:41

marcaaron added 2 commits October 14, 2024 14:42

remove other imports not needed

dadf916

Remove unnecessary newline

9479176

srikarparsi approved these changes Oct 15, 2024

View reviewed changes

srikarparsi merged commit 0167316 into main Oct 15, 2024
20 checks passed

srikarparsi deleted the marcaaron-createWorkspaceOnOldDotRedirect branch October 15, 2024 01:33

os-botify bot mentioned this pull request Oct 15, 2024

🍒 Cherry pick PR #50759 to staging 🍒 #50760

Merged

56 tasks

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 15, 2024

marcaaron added a commit that referenced this pull request Oct 15, 2024

Merge pull request #50760 from Expensify/marcaaron-cherry-pick-stagin…

ad10b37

…g-50759-1 🍒 Cherry pick PR #50759 to staging 🍒

github-actions bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-10 #50603

Closed

38 tasks

melvin-bot bot mentioned this pull request Oct 15, 2024

Users who select "Manage my team" in OldDot end up with no workspace when redirected to NewDot #50758

Closed

6 tasks

s77rt mentioned this pull request Oct 15, 2024

feat: add employee and accounting page to onboarding flow #49161

Merged

50 tasks

This was referenced Dec 7, 2024

[$250] Improve/fix logic for creating a workspace during onboarding flow #53326

Open

Move Workspace creation in the onboardingFlow to OnboardingPurpose page and skip Workspace creation for OD signups #53729

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Create workspace when new user signs up, selects the "Manage my team's expenses" option and completes the "employee" step #50759

[CP Staging] Create workspace when new user signs up, selects the "Manage my team's expenses" option and completes the "employee" step #50759

marcaaron commented Oct 15, 2024 •

edited

Loading

melvin-bot bot commented Oct 15, 2024

marcaaron commented Oct 15, 2024

srikarparsi commented Oct 15, 2024 •

edited

Loading

srikarparsi commented Oct 15, 2024 •

edited

Loading

OSBotify commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

[CP Staging] Create workspace when new user signs up, selects the "Manage my team's expenses" option and completes the "employee" step #50759

[CP Staging] Create workspace when new user signs up, selects the "Manage my team's expenses" option and completes the "employee" step #50759

Conversation

marcaaron commented Oct 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 15, 2024

marcaaron commented Oct 15, 2024

srikarparsi commented Oct 15, 2024 • edited Loading

srikarparsi commented Oct 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

marcaaron commented Oct 15, 2024 •

edited

Loading

srikarparsi commented Oct 15, 2024 •

edited

Loading

srikarparsi commented Oct 15, 2024 •

edited

Loading