Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for Payment 2024-10-01][Search v2.2] Create Pinned status for chats #48823

Closed
luacmartins opened this issue Sep 9, 2024 · 16 comments
Closed

[HOLD for Payment 2024-10-01][Search v2.2] Create Pinned status for chats #48823

luacmartins opened this issue Sep 9, 2024 · 16 comments
Assignees
@luacmartins @RachCHopkins @ikevin127
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Sep 9, 2024 •
edited
Loading

Coming from here, we'll deprecate the Has and Is filters from the Advanced Search page and move them to the status bar.

Issue OwnerCurrent Issue Owner: @RachCHopkins
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 9, 2024
@luacmartins luacmartins self-assigned this Sep 9, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 9, 2024
@luacmartins luacmartins added Internal Requires API changes or must be handled by Expensify staff Daily KSv2 and removed Weekly KSv2 labels Sep 9, 2024
@luacmartins luacmartins mentioned this issue Sep 9, 2024
Merged
49 tasks
@CortneyOfstad
Copy link
Contributor

Since Rach is assigned here, I'm going to remove my assignment — thanks!

@CortneyOfstad CortneyOfstad removed their assignment Sep 11, 2024
@luacmartins luacmartins mentioned this issue Sep 13, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 13, 2024
@luacmartins
Copy link
Contributor Author

PRs in review

@ikevin127 ikevin127 mentioned this issue Sep 14, 2024
Closed
6 tasks
@luacmartins
Copy link
Contributor Author

@ikevin127 API PR is deployed

@RachCHopkins
Copy link
Contributor

RachCHopkins commented Sep 18, 2024 •
edited
Loading

@luacmartins automation is borked, does anyone need to be paid here?

(Sorry @carlosmiceli I accidentally tagged you. Too many Carlosssses)

@luacmartins
Copy link
Contributor Author

luacmartins commented Sep 18, 2024 •
edited
Loading

Not yet, the App PR is still in review

@melvin-bot Melvin Bot

This comment has been minimized.

Sign in to view
@ikevin127
Copy link
Contributor

^

This is expected. Search doesn't work offline. Closing.

From the regression issue reported above.

@ikevin127
Copy link
Contributor

⚠️ Automation failed here -> this should be on [HOLD for Payment 2024-10-01] according to today’s production deploy from #49186 (comment).

cc @RachCHopkins

@luacmartins luacmartins changed the title [Search v2.2] Create Pinned status for chats [HOLD for Payment 2024-10-01][Search v2.2] Create Pinned status for chats Sep 25, 2024
@luacmartins luacmartins added Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 and removed Reviewing Has a PR in review Weekly KSv2 labels Sep 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2024
@RachCHopkins
Copy link
Contributor

@ikevin127 was there an upwork job? I just want to check before I create one and send you an offer!

@luacmartins can you please confirm it's a $250 payment for @ikevin127 here?

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
@ikevin127
Copy link
Contributor

@RachCHopkins From what I know, there wasn't any Upwork job created for this issue.

@luacmartins
Copy link
Contributor Author

Yes $250 payment for @ikevin127

@RachCHopkins
Copy link
Contributor

Offer sent @ikevin127

Upwork Job

@ikevin127
Copy link
Contributor

@RachCHopkins Offer accepted, thank you!

@RachCHopkins
Copy link
Contributor

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@RachCHopkins RachCHopkins

@ikevin127 ikevin127

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
[#whatsnext] #expense
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@CortneyOfstad @luacmartins @RachCHopkins @ikevin127