Implemented chat type in search

[shubham1206agra]

Details

Fixed Issues

$ #46588
$ #46587

Tests

1. Go to Search option from bottom tab.
2. Click on Chat type from LHP.
3. Try different status bars and try to click on rendered results and verify that correct report view with report action highlighted opens.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[SzymczakJ]

What's the status of this PR, I'm asking because my task depends on "chat" filter.

[shubham1206agra]

Waiting on #47753 to merge

[luacmartins]

This is taking shape and looking good. Not sure why the link is centered though

[shubham1206agra]

I am not able to figure out the reason for #47690 (comment).

@ikevin127 Can you help me here?

[ikevin127]

@shubham1206agra ⛏️ Did some digging and it looks like the origin of the issue comes from the AnchorRenderer component which renders comments with links (anchors), specifically the display: 'inline' style coming from:

App/src/components/PressableWithSecondaryInteraction/index.tsx

Line 92 in 9437d98

const inlineStyle = inline ? styles.dInline : {};

which is passed from here:

App/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

Line 46 in 9437d98

inline

If the inline style is removed, the link aligns to left as expected.

You'll have to figure out how to remove that style only for our specific case.

[shubham1206agra]

@ikevin127 I don't think this is the right reason since we are using Same Anchor Renderer everywhere and it has not affected anything else at all.

[melvin-bot]

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

Looking good and tests well. Left a couple of suggestions though.

[shubham1206agra]

@ikevin127 You can review this now.

[luacmartins]

@shubham1206agra react compiler is failing

[luacmartins]

@ikevin127 could you please prioritize reviewing this PR today?

[shubham1206agra]

@shubham1206agra react compiler is failing

Fixed

[luacmartins]

LGTM and tests well

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[ikevin127]

Thanks for addressing the issues and getting this fixed, looks really good 🚀

Note

Because of the API change and outdated onyx data, first time when I visited Chats on web I was thrown an error something like reportActionItem.message.map is not a function and app crashed.

This was fixed by Sign Out which cleared outdated onyx data - NAB but wanted to mention it in case some people might encounter the crash post-merge 👍

Another issue I found is related to the Unread tab, which currently it does not look like it's working as expected, here's a video of demonstrating having an unread message which doesn't show up in the Unread tab:

Screen.Recording.2024-09-06.at.13.21.36.mov

Not sure if this is a blocker for this PRs merge or whether it should be handled in this PR or a follow-up, @luacmartins wdyt ?

[luacmartins]

Because of the API change and outdated onyx data, first time when I visited Chats on web I was thrown an error something like reportActionItem.message.map is not a function and app crashed.

This shouldn't be an issue since users wouldn't have bad data locally given they didn't have access to this feature. I also have a PR in review that will fix this.

Another issue I found is related to the Unread tab, which currently it does not look like it's working as expected, here's a video of demonstrating having an unread message which doesn't show up in the Unread tab:

Hmm I tested the unread filter a few times and it worked for me. Either way I don't think that's a blocker for this PR.

[luacmartins]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[Kicu]

Hey guys, sorry for being late to the party but I didn't see this PR being worked on before, and now that this is merged I noticed some confusion around Chats and existing filters.

I can see that possible values for Status for Chats is:
All, Unread, Sent, Attachments, Links

However when working on Advanced Filters We have created 2 specific filters for Chats called: Is and Has. These filters have values very similar to Status for chats but you can choose multiple values there, whereas Status is single value.
Check my screens:

@luacmartins what should be highlighted when user picks for example has: attachments, link in Advanced Filters?

Also these filters are still not supported by the backend, see here:

Right now this issue is not yet visible, because we haven't yet merged this: #48312 which sets filter values from query, so right now you can't choose advanced filters for Chats yet.
You can reproduce it on dev by opening Advanced filters, then running this snippet in console.

Onyx.merge("searchAdvancedFiltersForm", {type: "chat"});

What should be the next steps, are we implementing IS and HAS filters on the backend?

[luacmartins]

@Kicu I agree that those filters are very similar to the status we have for chats. I was looking at implementing the backend part for them and started running into some issues because of the multi-select case. I think it might make sense to:

1. Has filter: Get rid of this. This one has direct replacements in the status bar
2. Is filter: We already have Unread in status, so we should remove this option. Additionally, Drafts is not possible right now since we don't save drafts on the server, so we need to remove this option. That would leave us with Pinned, which we might wanna consider just moving to the status bar and then getting rid of the is filter altogether.

cc @JmillsExpensify

[JmillsExpensify]

All great points. Yes, I agree with you Carlos. This design was more aspirational in terms of where we'd like to eventually get with drafts, so let's remove it for now. Equally, anything that already has a status filter shouldn't also show in the advanced filters so let's remove those.

One question on removing the is: filter. You're referring to removing it on the front-end, but we'll still keep it on the BE for future user, correct?

[luacmartins]

Discussed this 1:1 with Jason, created an issue here

[Kicu]

thanks for the clarification and issue, someone from SWM will pick this up

[pecanoro]

Hey guys, I think this PR caused this bug here. It's an edge case, so I don't think we should block on it, but I'm wondering if I should open it for proposals or assign the original author and reviewer!

[luacmartins]

I replied in Slack, but the same issues already exists on production with Expenses