Deploy Checklist: New Expensify 2024-09-09

[github-actions]

Release Version: 9.0.31-26
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [Guided Setup Stage 3] Update the Pay w/ Expensify selectors #45264
• [No QA] Remove front-end workaround for authWrites issue #45536
• Make the members view of rooms and expense chats consistent with groups #47201
• [OldDot Rules Migration] Expense report rules #47468
• Migrate notification preference #47577
• Implemented chat type in search #47690
• grammar update simplifying an AST #47789
• Fix - eReceipt is shown when imported card expense automatically merges with scanned receipt #47798
• fix: show disabled distance rate if it is selected in IOU request #47850
• Fix - Room - Rooms mention list does not appear in message edit mode #47949
• fix: Dupe detection - Merchant field shows (none) instead of blank when (none) is selected. #47956
• fix: prevent email address selection for categorize #47985
• Make onboarding continue from last visited onboarding page #48137
• fix: LHN preview for expense report shows 0.00 when there is only one scan expense #48139
• fix: display offline UI for search page in offline mode #48146
• Don't show RBR for modified date/amount violation if not a policy report #48236
• fix: edited subtask name not update in DM last message in LHN #48285
• Fix "Add custom segment or record" image appears briefly after adding first segment #48297
• fix: Employee has the option to edit categories #48309
• Create Get-reimbursed-faster-as-a-non-US-employee.md #48353
• Update trip statuses #48365
• Fix crash when switching accounts #48379
• fix: Search - Inconsistency in selection mode behavior after holding and unholding expense. #48382
• feat: update the workspace connected bank account page for clarity and consistency #48443
• [No QA]: Restricted action: Restrict actions of Delegate Submitter #48485
• fix: Incorrect receipt on confirmation page when expenses have different receipt #48518
• [Workspace Feeds] Block non-admin members for card issue flow #48524
• chore: update task preview UI #48552
• fix: iOS - More features - Word is too close to the page border. #48573
• fix integration message #48579
• Concierge placeholder #48583
• Bump expensify common to allow any characters after first three backtick in codefence #48611
• Update react-native-image-size for content:// support #48612
• fix: add confirm modal to expensify card page #48617
• fix: Tags - App closes RHP after upgrade and clicking back button in GL code page. #48619
• fix: Scan - Clicking outside of the allow location modal submits the scan expense. #48620
• fix: double rhp animation when click issue new card #48632
• Disable legacy mode in desktop #48645
• [NoQA] fix: timing measurements are inaccurate #48654
• Fix Contains header behavior #48655
• Show expense report in LHN even if report not in submitted state/status #48661
• Fix - Workspace - Default avatar is different in full screen after uploading avatar and removing it #48667
• Fix Invoice - Unsuccessful workspace deletion results in archived label on Invoice  #48668
• [Advanced Approval Workflows] Remove advanced approval workflows beta #48706
• Add support for POLICYCHANGELOG_UPDATE_CATEGORIES #48717
• [NO QA] Update Third-Party-Payments.md #48721
• disable strict mode #48722
• Update Reimburse-Reports-Invoices-and-Bills.md #48726
• Update en.ts #48735
• Main tag shows Required status when all subtags are disabled #48738
• Move emoji to make thumbsup show up first #48748
• [No QA] Separate build and upload Fastlane lanes #48754
• Add disclaimer for the Expensify card empty state #48768
• [HybridApp] Fix attachment visibility #48781
• [No QA] Fix finalizeRelease job #48792
• [No QA] Don't skip checkDeploymentSuccess in any case #48793
• Revert "Fix crash when switching accounts" #48798
• [CP Staging] Fix/48801 #48806
• [CP Staging] Fix crash on timing #48815
• [CP Staging] Fix timing crash #48830
• [CP Staging] Fix deleted message on search #48842
• [CP Staging] Sort chats by descending date #48846
• [CP Staging] Revert some changes and fix UI bug #48848
• [No QA] Fix typo in deploy.yml #48854
• [No QA] Supply repo param for gh cli in any job w/o checkout #48857
• [CP Staging] Fix app crash when viewing member profile after Expensify Card feature is enabled #48872
• [CP Staging] fix: Expensify card page loading infinitely #48874
• fix: Expense - Unable to dismiss the delete modal by clicking outside the modal. #48878
• [CP Staging] Fix showing error when setting tax reclaimable on #48890
• [CP Staging] Fix showcontext menu on search page #48901
• [CP Staging] fix rule page loading #48907
• [No QA] Correctly bundle aab and set path #48919
• fix: Web - Scan - 'Description' and 'Category' fields are disabled after dismissing 'Allow location' modal. #48923
• [No QA] fix typo in ruby syntax #48929
• [CP Staging+Prod] Fix creating invoice by enabling hasInvoicingDetails #48935

Deploy Blockers:

• [HOLD for payment 2024-09-18] Android&iOS - App crashes after uploading a new build #48799
• [HOLD for payment 2024-09-18] Room - Dropdown button does not update the selected member count after deleting member #48801
• [$125] Rules - Page scrolls up after dismissing Auto-pay reports under RHP #48803
• [$250] [Search v2.2] Chat is scrolled to the bottom when refreshing the page #48808
• [HOLD for payment 2024-09-18] [Search v2.2] Deleted message changes to empty content with (edited) in Search - Chat page #48810
• [HOLD for Payment 2024-10-07][$250] [Search v2.2] Redirected back to "Expenses" when refreshing the page while in "chats" #48817
• Expense - Two "Members" titles in Members page in expense report #48821
• Room - Error instructs to invite users to #announce when users cannot be invited to #announce #48831
• [HOLD for payment 2024-09-18] Distance rate - Dollar sign moves to left after clicking/tapping it #48833
• [$250] Task – Assignee avatar is greyed out in main chat when complete a task #48834
• [HOLD for payment 2024-09-18] [$50] Expensify Card - Expensify Card page loads infinitely #48835
• [HOLD for payment 2024-09-18] [Search v2.2] Chats are not sorted by descending date #48847
• [HOLD for payment 2024-09-18] [HOLD for payment 2024-09-17][Search v2.2] Context menu is available for attachment which leads to crash and invalid link #48864
• [HOLD for payment 2024-09-18] [$250] Web - Scan-"Description" and "Category" fields are disabled after dismissing "Allow location" modal #48865
• [HOLD for payment 2024-09-18] [$250] Android & iOS - App crashes when viewing member profile when Expensify Card feature is enabled #48866
• [HOLD for payment 2024-09-18] [$50] Android – Workspace settings–Hmm page appears briefly when open just invited member settings #48867
• [OldDot Rules Migration] [Polish] - No error under input field when saving auto-pay amount more than 20k #48868
• iOS Rules - Text cursor moves to front after entering the third digit in Percentage field #48869
• [WAITING ON AIMANE TO ACCEPT] Android - Rules - Custom name field is not auto-focused & Text cursor is before the input in % field #48873
• [HOLD for payment 2024-09-18] Expense - Unable to dismiss the delete modal by clicking outside the modal #48875
• [AWAITING PAYMENT] [$250] [OldDot Rules Migration] [Polish] - App freezes after updating Custom report name #48879
• [HOLD for payment 2024-10-01][Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48882
• [HOLD for payment 2024-09-18] Distance - No error when entering tax reclaimable amount larger than the distance rate #48883
• Workspace – Able to remove an approver from the workspace members in Gmail account #48886
• [HOLD for payment 2024-10-31][$250] Rules - After disabling all workflow features and opening rules, page keep loading #48894
• [HOLD for payment 2024-11-18] [$250] [Search v2.2] - Chats - Selected chat is hidden when navigating via keyboard #48902
• [Search v2.2] -Message that previously had link remains in Links after removing link from the message #48910
• Web - IOU - Console error when paying elsewhere as invited user #48916

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[mvtglobally]

@luacmartins Android and IOS builds are crashing once updated. Getting the issue in a bit. but can you check if builds deployed properly?

[luacmartins]

@mvtglobally pinged in Slack, but this should be solved now

[luacmartins]

Checking off #48834. Demoted.

[luacmartins]

#48817 also happens in prod for other data types. Demoting to NAB.

[luacmartins]

#48831 demoted to NAb

[luacmartins]

Demoted #48808

[luacmartins]

Demoted #48803

[mvtglobally]

Regression is 35% left

Blocker
#48835

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Julesssss]

Demoting #48873

[luacmartins]

Demoted #48882

[mvtglobally]

TR Regression is Completed

Blockers
#48835
#48864
#48865
#48866
#48867
#48883
#48894
#48902

PRs:
#45264 - Pending validation on all environments
#47468 - Pending validation on mWeb, Android and iOS
#47690 - Repro #48864. Checking off.
#47798 - Pending validation on Web, Desktop
#48137 - is failing on Desktop. Logging an issue
#48382 - Pending validation on iOS
#48524 - Pending validation on all environments
#48632 - Pass-bug on Web, mWeb with #48835 checking off
#48655 - Pending validation on mWeb, Desktop, Android and iOS
#48668 - Pending validation on all environments
#48706 - Pending validation on mWeb, Android
#48768 - Pending validation on mWeb, Desktop, Android and iOS
#47577 (comment) Can you confirm whats needed

[luacmartins]

Demoted #48910

[luacmartins]

#47577 (comment) Can you confirm whats needed

I think regression tests should be enough here

[luacmartins]

Backend issue - #48916. NAB though

[mvtglobally]

Blockers
#48865

PRs:
#45264 - Pending validation on Desktop & failing with #48916
#47468 - is failing on mWeb and Android. #48894
#47577 (comment) - Steps are no clear. We run regular TR TC for notifications. Can I check it off?
#47798 - Pending validation on Web, Desktop
#48137 - is failing on Desktop. Logging an issue
#48524 - Pending validation on all environments
#48661 - Pending validation on all environments
#48668 - is blocked by #48701
#48722 (comment) - What URL should we use for staging?
#48781 - waiting for build

[luacmartins]

#47468 - checked off. We CPed a fix.
#47577 (comment) - yes, checked off if the regular steps for notification passed
#48668 - we're CPing a fix.
#48668 - we're CPing a fix
#48722 (comment) - no need to test this one, it affects dev only

[luacmartins]