-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room - Error instructs to invite users to #announce when users cannot be invited to #announce #48831
Comments
Triggered auto assignment to @yuwenmemon ( |
Triggered auto assignment to @kevinksullivan ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@Expensify/design What do you think about this bug? Do we need to use a different copy for this case? |
cc @paultsimura for visibility |
This is coming from: #47201 |
Demoting to NAB since it's a small copy change. |
Triggered auto assignment to @shmaxey ( |
Assigning @jamesdeanexpensify from https://expensify.slack.com/archives/C01GTK53T8Q/p1725915664037679 to give a closer look to copy. |
(handling in Slack) |
Agree that a simple copy change is enough here |
Good catch and I agree with the copy change. |
Payment for the PR from this issue is being handled in: #46838 , so no need to handle any payment here! |
@yuwenmemon, @jamesdeanexpensify, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
This one can be closed |
Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.31-5
Reproducible in staging?: Y
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4938531
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The error message for invalid search term will not show the prompt to invite member using the invite button because users cannot be invited manually in #announce room.
Actual Result:
The error message is "Member not found. To invite a new member to the room, please use the invite button above." when there is no invite button as users cannot be invited manually in #announce room.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6597926_1725910348020.20240910_032728.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: