Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - Error instructs to invite users to #announce when users cannot be invited to #announce #48831

Closed
3 of 6 tasks
IuliiaHerets opened this issue Sep 9, 2024 · 16 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.31-5
Reproducible in staging?: Y
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4938531
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Invite more than 8 members.
  4. Go to #announce.
  5. Click on the room header > Members.
  6. On the search field, enter term that will not return result.

Expected Result:

The error message for invalid search term will not show the prompt to invite member using the invite button because users cannot be invited manually in #announce room.

Actual Result:

The error message is "Member not found. To invite a new member to the room, please use the invite button above." when there is no invite button as users cannot be invited manually in #announce room.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6597926_1725910348020.20240910_032728.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 9, 2024
Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 9, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rayane-djouah
Copy link
Contributor

@Expensify/design What do you think about this bug? Do we need to use a different copy for this case?

@rayane-djouah
Copy link
Contributor

cc @paultsimura for visibility

@yuwenmemon
Copy link
Contributor

This is coming from: #47201

@luacmartins
Copy link
Contributor

Demoting to NAB since it's a small copy change.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Sep 9, 2024
@yuwenmemon yuwenmemon added the Waiting for copy User facing verbiage needs polishing label Sep 9, 2024
Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @shmaxey (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 9, 2024
@yuwenmemon
Copy link
Contributor

Assigning @jamesdeanexpensify from https://expensify.slack.com/archives/C01GTK53T8Q/p1725915664037679 to give a closer look to copy.

@jamesdeanexpensify
Copy link
Contributor

jamesdeanexpensify commented Sep 9, 2024

(handling in Slack)

@dubielzyk-expensify
Copy link
Contributor

dubielzyk-expensify commented Sep 9, 2024

Agree that a simple copy change is enough here

@shawnborton
Copy link
Contributor

Good catch and I agree with the copy change.

@joekaufmanexpensify
Copy link
Contributor

Payment for the PR from this issue is being handled in: #46838 , so no need to handle any payment here!

Copy link

melvin-bot bot commented Sep 17, 2024

@yuwenmemon, @jamesdeanexpensify, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@paultsimura
Copy link
Contributor

This one can be closed

@joekaufmanexpensify
Copy link
Contributor

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing
Projects
None yet
Development

No branches or pull requests