[HOLD for payment 2024-11-14] [$250] Search - Search icon is not responsive after tapping on room mention in Chat and exit chat

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace chat.
3. Send a message containing #admins room mention.
4. Go to Search > Chat.
5. Tap on the #admins mention.
6. Swipe to the right to close the chat.
7. Tap on the Search icon.

Expected Result:

User should be able to navigate to Search after swiping to right to close the room chat when it is opened from Search.

Actual Result:

Search icon is not responsive after tapping on room mention in Chat and closing the chat.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6626382_1728242537349.ScreenRecording_10-07-2024_03-17-45_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847130088347504306
• Upwork Job ID: 1847130088347504306
• Last Price Increase: 2024-10-25
• Automatic offers:
• rayane-djouah | Reviewer | 104596829
• Nodebrute | Contributor | 104596830

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search icon is not responsive after tapping on room mention in Chat and exit chat

What is the root cause of that problem?

The first issue is that when we navigate back by swiping, we are returned to the Home screen instead of the Search screen. The second issue is that clicking on #admin or any room name on wide screens should open the report in the RHP, rather than navigating to it directly. It's because we navigate to ROUTES.REPORT_WITH_ID instead of ROUTES.SEARCH_REPORT

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 76 in 6d8e739

const navigationRoute = reportID ? ROUTES.REPORT_WITH_ID.getRoute(reportID) : undefined;

What changes do you think we should make in order to solve the problem?

When a room mention is clicked from the search pane to address both issues, we should open the report in the RHP instead of navigating directly to it. We can do something like this

  let navigationRoute = reportID ? ROUTES.REPORT_WITH_ID.getRoute(reportID) : undefined;
    const topmostCentralPaneRoute = getTopmostCentralPaneRoute(navigationRef.getRootState() as State<RootStackParamList>)
    const backTo = Navigation.getActiveRoute();
    if(topmostCentralPaneRoute?.name === SCREENS.SEARCH.CENTRAL_PANE){
        navigationRoute = reportID ?  ROUTES.SEARCH_REPORT.getRoute({reportID,backTo}) :undefined
    }

In the above code we are checking with getTopmostCentralPaneRoute === searchpanel if yes then we will navigate to ROUTES.SEARCH

Note

This is just pseudo-code, and we can refine it further in the PR

Result ios

Screen.Recording.2024-10-07.at.2.10.18.AM.mov

Result (wide screen)

Screen.Recording.2024-10-07.at.2.10.37.AM.mov

What alternative solutions did you explore? (Optional)

Another alternative solution would be to use getUrlWithBackToParam

App/src/ROUTES.ts

Lines 266 to 269 in 6d8e739

	REPORT_WITH_ID: {
	route: 'r/:reportID?/:reportActionID?',
	getRoute: (reportID: string, reportActionID?: string, referrer?: string) => {
	const baseRoute = reportActionID ? (`r/${reportID}/${reportActionID}` as const) : (`r/${reportID}` as const);

and pass the active route here as backTo param

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 76 in 6d8e739

const navigationRoute = reportID ? ROUTES.REPORT_WITH_ID.getRoute(reportID) : undefined;

Other minor details can be addressed in the PR.

[alexpensify]

Adding this one to my test list and will get to it later this week.

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

Still on my testing list

[alexpensify]

No update

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021847130088347504306

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[alexpensify]

@rayane-djouah - can you please identify if this proposal will fix this issue? Thanks!

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

[melvin-bot]

@alexpensify @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[rayane-djouah]

👀

[rayane-djouah]

@Nodebrute Could you take a look at this related issue and this related PR? Is the bug in this issue related to them in terms of the root cause or solution?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Open Room Mention in RHP from Search  #51666

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment automatic offer (Reviewer)
• @Nodebrute requires payment automatic offer (Contributor)

[melvin-bot]

@rayane-djouah @alexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[alexpensify]

Payouts due: 2024-11-14

• Contributor: $250 @Nodebrute
• Reviewer: $250 @rayane-djouah

Upwork job is here. Everyone has been paid via Upwork.

[alexpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[alexpensify]

@rayane-djouah, can you please complete the checklist? thanks!

[rayane-djouah]

BugZero Checklist:

• Classify the bug:

  Bug classification

  Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

  Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

  Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Implemented chat type in search #47690 (comment)

• If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• @alexpensify Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

#### Precondition:

- A workspace has been created.

#### Test:

1. Navigate to the workspace chat.
2. Send a message that includes a mention of a room (example: the #admins room).
3. Navigate to "Search" and then select "Chat".
4. Tap on the room mention in the chat.
5. Confirm that the chat opens in the right-hand pane (RHP) on wider screens.
6. On iOS and Android native apps, Swipe right to close the chat.
7. On other platforms click on the back button.
8. Verify that you are redirected back to the search page.
9. Verify that the navigation buttons (Inbox, Search, Settings) are responsive.

Do we agree 👍 or 👎

[melvin-bot]

@AndrewGable, @alexpensify, @rayane-djouah, @Nodebrute Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

Thanks! I'll work on the QA test prep later this week.

[alexpensify]

Other GHs have been a priority; I'll work on the regression test soon.

[melvin-bot]

@AndrewGable, @alexpensify, @rayane-djouah, @Nodebrute Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

With the slower week, I'll be working on the last step soon.

[alexpensify]

Closing - all set here