[Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48990

WojtekBoman · 2024-09-11T15:30:25Z

Details

This PR adds an additional if statement to the getStateForAction in CustomRouter that handles going back to the search RHP from the chat section. In this case the Home screen is removed from the BottomTabNavigator to display the correct page under RHP.

Fixed Issues

$ #48882
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Launch New Expensify app.
Go to any report.
Send a message.
Send a reply to the message in thread.
Go to Search.
Go to Chats.
Tap on the parent message sent in Step 3.
Tap on the reply count to go to thread.
Return to Search page by swiping to right twice (iOS navigation) (if on Android, use device back navigation and not app button).
Verify if Search page is correctly displayed.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-11.at.15.44.39.mp4

iOS: Native

Screen.Recording.2024-09-11.at.15.47.32.mov

melvin-bot · 2024-09-11T15:51:03Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-09-12T18:58:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-13.at.12.30.16.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-18.at.10.13.25.PM.mov

iOS: Native

Screen.Recording.2024-09-13.at.12.40.52.AM.mov

Screen.Recording.2024-09-18.at.9.48.22.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-13.at.12.46.44.AM.mov

Screen.Recording.2024-09-18.at.10.05.10.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-18.at.10.08.04.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-18.at.10.20.33.PM.mov

ishpaul777 · 2024-09-12T19:25:59Z

works well on Native platforms, but we have a bug on Web 👇

Navigate to parent mesage from search then navigate to thread then go back, LHN shows Notfound view

Screen.Recording.2024-09-13.at.12.50.21.AM.mov

luacmartins · 2024-09-12T19:30:20Z

@WojtekBoman could you please take a look at the bug above?

ishpaul777 · 2024-09-12T19:54:30Z

Bug: Navigating back using app button opens report again instead of search [Mweb]

Navigate parent msg from search -> thread -> then go back using app "<" back button

Result: It does not navigate back to search

Screen.Recording.2024-09-13.at.1.18.48.AM.mov

luacmartins

Seems like we need to address this bug

ishpaul777 · 2024-09-17T14:18:32Z

gentle bump @WojtekBoman

WojtekBoman · 2024-09-18T13:16:35Z

Hey, this bug has been fixed - #48990 (comment).

This issue is present also on the main branch. This is how it looks on web:

Screen.Recording.2024-09-18.at.15.05.36.mp4

These screens are different, the first one is displayed in RHP, the second one is in wide layout, while on small screens they are displayed in the same way and it's the cause of this bug. Can we address it in a separate issue?

cc: @adamgrzybowski

ishpaul777 · 2024-09-18T16:11:02Z

I think there's already some work in progress to migrate withOnyx to useOnyx in this PR #49185, I think we should not touch that

WojtekBoman · 2024-09-18T16:34:39Z

I think there's already some work in progress to migrate withOnyx to useOnyx in this PR #49185, I think we should not touch that

Ok, I've reverted these changes :)

ishpaul777

LGTM!

luacmartins

LGTM

luacmartins · 2024-09-18T22:42:16Z

ESLint errors are unrelated to this PR.

/home/runner/work/App/App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
  583:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

melvin-bot · 2024-09-18T22:42:25Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-09-18T22:54:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-19T23:54:34Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.39-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-24T19:04:03Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.39-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-10-16T08:36:22Z

src/libs/Navigation/AppNavigator/beforeRemoveReportOpenedFromSearchRHP/index.native.ts

+        state.routes?.length >= 3 &&
+        state.routes.at(-1)?.name === SCREENS.REPORT &&
+        state.routes.at(-2)?.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR &&
+        getTopmostBottomTabRoute(state)?.name === SCREENS.HOME;


Coming from #50111, where there was a crash with a particular navigation scenario. We haven't limited this function to the search RHP, so it's running in unexpected contexts, which is partially what caused the crash. More details in the proposal.

Pop home screen when going back to Search RHP

babc3c9

WojtekBoman marked this pull request as ready for review September 11, 2024 15:50

WojtekBoman requested a review from a team as a code owner September 11, 2024 15:50

melvin-bot bot requested a review from DylanDylann September 11, 2024 15:51

melvin-bot bot removed the request for review from a team September 11, 2024 15:51

luacmartins requested review from luacmartins and ishpaul777 and removed request for DylanDylann September 11, 2024 15:54

luacmartins requested changes Sep 15, 2024

View reviewed changes

WojtekBoman added 2 commits September 18, 2024 07:29

Merge branch 'main' into fix/search-rhp-native-go-back

86742b3

Add beforeRemoveReportOpenedFromSearchRHP

83ccc2e

WojtekBoman force-pushed the fix/search-rhp-native-go-back branch from 5746d0c to 83ccc2e Compare September 18, 2024 16:32

Cleanup CustomRouter changes

40bd73f

ishpaul777 approved these changes Sep 18, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins September 18, 2024 16:52

luacmartins approved these changes Sep 18, 2024

View reviewed changes

luacmartins merged commit 5bfc3f1 into Expensify:main Sep 18, 2024
17 of 18 checks passed

melvin-bot bot added the Emergency label Sep 18, 2024

luacmartins removed the Emergency label Sep 18, 2024

github-actions bot mentioned this pull request Sep 19, 2024

Deploy Checklist: New Expensify 2024-09-19 #49505

Closed

31 tasks

jjcoffee mentioned this pull request Oct 3, 2024

[HOLD for payment 2024-10-16] [$250] Dupe detect - App crashes when leaving Review duplicates page after viewing other expense #50111

Closed

6 tasks

ishpaul777 mentioned this pull request Oct 7, 2024

[HOLD for payment 2024-10-01][Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48882

Closed

6 tasks

jjcoffee reviewed Oct 16, 2024

View reviewed changes

rayane-djouah mentioned this pull request Oct 20, 2024

[HOLD for payment 2024-11-14] [$250] Search - Search icon is not responsive after tapping on room mention in Chat and exit chat #50317

Open

6 tasks

huult mentioned this pull request Oct 22, 2024

[$250] Search-Different navigation when closing report via app back button and device back navigation #51192

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48990

[Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48990

WojtekBoman commented Sep 11, 2024 •

edited

Loading

melvin-bot bot commented Sep 11, 2024

ishpaul777 commented Sep 12, 2024 •

edited

Loading

ishpaul777 commented Sep 12, 2024

luacmartins commented Sep 12, 2024

ishpaul777 commented Sep 12, 2024

luacmartins left a comment

ishpaul777 commented Sep 17, 2024

WojtekBoman commented Sep 18, 2024 •

edited

Loading

ishpaul777 commented Sep 18, 2024

WojtekBoman commented Sep 18, 2024

ishpaul777 left a comment

luacmartins left a comment

luacmartins commented Sep 18, 2024

melvin-bot bot commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 24, 2024

jjcoffee Oct 16, 2024

[Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48990

[Search v2.1] Android & iOS - Search icon is not responsive after returning to LHN from thread #48990

Conversation

WojtekBoman commented Sep 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 11, 2024

ishpaul777 commented Sep 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Sep 12, 2024

luacmartins commented Sep 12, 2024

ishpaul777 commented Sep 12, 2024

luacmartins left a comment

Choose a reason for hiding this comment

ishpaul777 commented Sep 17, 2024

WojtekBoman commented Sep 18, 2024 • edited Loading

ishpaul777 commented Sep 18, 2024

WojtekBoman commented Sep 18, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Sep 18, 2024

melvin-bot bot commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 24, 2024

jjcoffee Oct 16, 2024

Choose a reason for hiding this comment

WojtekBoman commented Sep 11, 2024 •

edited

Loading

ishpaul777 commented Sep 12, 2024 •

edited

Loading

WojtekBoman commented Sep 18, 2024 •

edited

Loading