-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payment due Oct 7][$250] [Support CSV] Categories - File contains errors when downloading CSV with no category #49022
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Triggered auto assignment to @blimpich ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Looking into this. |
Talked about it in Slack, decided its not a deploy blocker. Doesn't prevent them from using the app and is also pretty edge case. |
Job added to Upwork: https://www.upwork.com/jobs/~021833956684433969336 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk ( |
Discussed expected behavior in this #expensify-open-source thread. Probably should just not be showing the "download csv" button if there are no categories. @rlinoz can you confirm that? |
Yeah, I think we can go with that. Another thing that we should do is make sure that if a download CSV request throws an error we don't write it in the CSV and instead show a modal. |
Current assignee @rlinoz is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@cretadn22 you can use the ones in common
|
heads up, I'm going to be ooo until 9/30. Since we're working on a PR I'm not going to invite a BZ teammate to monitor this while I'm away. If you need anything from BZ please reach out in slack for a volunteer. Thanks! |
Request to increase payment amountThe fix broadens the scope of the original bug and the additional PR represents a significant modification. Below is my summary:
|
I initially thought it was a kind of regression as now I felt obliged to raise the problem during PR testing, but I'm not sure. In favor of @cretadn22, they did an excellent job with both PRs. They were proactive in discussing solutions with us here and quickly created the PR after the issue was raised. However, I don't think much beyond that, it's up to you @Christinadobrzyn and @rlinoz :D Either way I will return here to complete the BZ checklist before payment. |
Thanks for reaching out @cretadn22 about the bonus request! Also thanks for the context and thoughts @brunovjk. I'm discussing this with the team and will get back to you as soon as possible! Note, I pushed out the payment date to Oct 7th because this PR is still in the 7 day window. |
Okay payment summary, let me know how this looks! Payouts due:
Do we need a regression test for this? |
Thank you very much @Christinadobrzyn.
Yes, I believe we can use one, I will do it before payday, I will keep an eye out for regressions. |
Hi @brunovjk would you mind writing up a regression test for us? Thank you! Moving to daily to pay out asap |
Regression Test Proposal:
Do we agree 👍 or 👎? |
I think we don't need this, we didn't have the tests for Applause when this happened and we have now, so it should be mostly covered. |
Thanks for clarifying @rlinoz |
Thanks for the insight @rlinoz! It's payment day so I paid out based on this summary - #49022 (comment) I'll not create the regression test based on #49022 (comment) Also, @brunovjk and @cretadn22 there was a discussion about some payments through Upwork not going through - if you happen to notice this payment is missing will you please let me know. I assume it will take a week or so for the payment to show up but if you happen to notice anything strange, please let me know! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.32-3
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The file should not contain error when downloading CSV with no categories.
Actual Result:
The file contains errors when downloading CSV with no category.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6600256_1726080845912.Screen_Recording_20240912_024951_Sheets.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @brunovjkThe text was updated successfully, but these errors were encountered: