Workspace - From category GL code page, tapping back button directs to Hhm not here page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab -- new workspace
3. Tap categories
4. Tap on a category
5. Tap GL code
6. Tap app back button

Expected Result:

From GL code page, tapping back button must not direct to hhm not here page.

Actual Result:

From category GL code page, tapping back button directs to hhm not here page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6600597_1726114693300.Screenrecorder-2024-09-12-09-41-27-469_compress_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-09-12 09:47:48 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

From category GL code page, tapping back button directs to hhm not here page.

What is the root cause of that problem?

in here we are navigating twice at this back button handle

After navigating go back, we also call the goBack function to navigate to backTo => not found page

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 94 to 100 in 57e1313

	onBackButtonPress={() => {
	if (isUpgraded) {
	Navigation.dismissModal();
	} else {
	Navigation.goBack();
	}
	goBack();

What changes do you think we should make in order to solve the problem?

when should have early return when navigate go back here

                onBackButtonPress={() => {
                    if (isUpgraded) {
                        Navigation.dismissModal();
                    } else {
                        Navigation.goBack();
                        return;
                    }
                    goBack();
                }}

What alternative solutions did you explore? (Optional)

[nkdengineer]

updated proposal

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• From GL code page, tapping back button must not direct to hmm not here page.

What is the root cause of that problem?

• When policy is not controlPolicy we redirect app to workspaceUpgrade page
  

  App/src/pages/workspace/categories/CategorySettingsPage.tsx

  Lines 195 to 201 in 57e1313

  	if (!isControlPolicy(policy)) {
  	Navigation.navigate(
  	ROUTES.WORKSPACE_UPGRADE.getRoute(
  	policyID,
  	CONST.UPGRADE_FEATURE_INTRO_MAPPING.glAndPayrollCodes.alias,
  	ROUTES.WORKSPACE_CATEGORY_GL_CODE.getRoute(policyID, policyCategory.name),
  	),

• here we are passing wrong fallback route
  

  App/src/pages/workspace/categories/CategorySettingsPage.tsx

  Line 200 in 57e1313

  ROUTES.WORKSPACE_CATEGORY_GL_CODE.getRoute(policyID, policyCategory.name),

What changes do you think we should make in order to solve the problem?

• change fallback route

ROUTES.WORKSPACE_CATEGORY_SETTINGS.getRoute(policyID, policyCategory.name),

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 200 in 57e1313

ROUTES.WORKSPACE_CATEGORY_GL_CODE.getRoute(policyID, policyCategory.name),

• so app will navigate to category page when clicking back button from upgrade page.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MariaHCD]

I think this will be fixed in this PR: #49076

[rayane-djouah]

I think this will be fixed in this PR: #49076

Correct!

Screen.Recording.2024-09-12.at.2.02.34.PM.mov

[MariaHCD]

Nice, thanks for confirming, @rayane-djouah!

(I was just about to ask in the Slack thread but you were faster! 🚀 )

[rlinoz]

This is fixed on staging

[luacmartins]

No payments due since this was a regression. Closing.