[HOLD for payment 2024-09-26] [$250] [Dev] Console Warning: Possible unhandled promise rejection

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-9
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726072317575939?thread_ts=1726072125.690969&cid=C049HHMV9SM

Action Performed:

Logon to ND on iOS App

Expected Result:

No console warning

Actual Result:

Console Warning
Warning: Possible unhandled promise rejection

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834518653490433368
• Upwork Job ID: 1834518653490433368
• Last Price Increase: 2024-09-13

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console warning when open native app.

What is the root cause of that problem?

When we open the app, the first route is the bottom tab navigator which has an empty path.

App/src/libs/Navigation/linkingConfig/config.ts

Lines 65 to 67 in 7748eff

	[NAVIGATORS.BOTTOM_TAB_NAVIGATOR]: {
	path: ROUTES.ROOT,
	initialRouteName: SCREENS.HOME,

App/src/ROUTES.ts

Line 21 in 7748eff

ROOT: '',

The warning is shown when we pass the empty string to the URL constructor.

App/src/libs/actions/Report.ts

Lines 2683 to 2685 in 7748eff

	if (new URL(url).searchParams.get('exitTo') === ROUTES.WORKSPACE_NEW) {
	return;
	}

What changes do you think we should make in order to solve the problem?

Make sure the url is not empty before passing it to the URL constructor.

if (url && new URL(url).searchParams.get('exitTo') === ROUTES.WORKSPACE_NEW) {
    return;
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834518653490433368

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[aimane-chnaif]

@bernhardoj's proposal looks good.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Sounds perfect. Assigning!

[bernhardoj]

PR is ready

cc: @aimane-chnaif

[stephanieelliott]

PR was deployed to prod on 9/19 but it looks like the automation didn't work. Updating manually to add payment date

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @bernhardoj owed $250 via NewDot
• Reviewer: @aimane-chnaif owed $250 via NewDot

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1834518653490433368/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[bernhardoj]

Requested in ND.

[JmillsExpensify]

@stephanieelliott mind confirming this payment summary when you're back online? Thank you!

[aimane-chnaif]

@stephanieelliott I am still using upwork

[stephanieelliott]

@aimane-chnaif are you able to request via NewDot? It looks like are eligible for ND payments, and we would prefer to pay in ND rather than Upwork if it's ok with you. Otherwise, please let me know so that I can extend the offer to you in Upwork.

Summarizing payment on this issue:

• Contributor: @bernhardoj $250 - please request via NewDot
• Contributor+: @aimane-chnaif $250 - Upwork offer extended, please accept: https://www.upwork.com/nx/wm/offer/104253282

[aimane-chnaif]

Otherwise, please let me know so that I can extend the offer to you in Upwork.

@stephanieelliott please. thx

[JmillsExpensify]

$250 approved for @bernhardoj

[stephanieelliott]

Hey @aimane-chnaif I extended the offer to you in Upwork, please accept when you get a chance! https://www.upwork.com/nx/wm/offer/104253282

[stephanieelliott]

All paid