-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-18] [HOLD for payment 2024-11-11] [$250] The setting "Mute all sounds from Expensify" keeps turning back off despite turning it on every day. #49087
Comments
Triggered auto assignment to @johnmlee101 ( |
Triggered auto assignment to @isabelastisser ( |
Job added to Upwork: https://www.upwork.com/jobs/~021834238152691021896 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee ( |
Edited by proposal-police: This proposal was edited at 2024-09-12 14:52:57 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The setting "Mute all sounds from Expensify" keeps turning back off despite turning it on every day. What is the root cause of that problem?When user mute all sounds we only merge it in onyx and no API calls are made to store the preference in backend Lines 972 to 974 in 4c424a2
What changes do you think we should make in order to solve the problem?We should do a api call for We can also do the same for usestagingserver What alternative solutions did you explore? (Optional) |
Problem Statement: The setting “Mute all sounds from Expensify” keeps turning off, even after being enabled by the user. Root Cause: The current implementation merges the Proposed Solution: We will add an API call in User.ts for the Alternative Solutions Explored:
|
📣 @eyramtitiati! 📣
|
Discussing on Slack as a similar issue was previously closed as expected. |
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.The setting "Mute all sounds from Expensify" keeps turning back off despite turning it on every day. What is the root cause of that problem?API to update "Mute all sounds from Expensify" is not implemented What changes do you think we should make in order to solve the problem?Need to implement the API and other related changes to respective files function updateIsMutedAllSounds(isMutedAllSounds: boolean) {
const optimisticData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.USER,
value: {isMutedAllSounds: isMutedAllSounds},
},
];
const failureData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.USER,
value: {isMutedAllSounds: !isMutedAllSounds},
},
];
const parameters: UpdateIsMutedAllSoundsParams = {isMutedAllSounds};
API.write(WRITE_COMMANDS.UPDATE_IS_MUTED_ALL_SOUNDS, parameters, {
optimisticData,
failureData,
});
} What alternative solutions did you explore? (Optional) |
Coming from the Slack discussion, the repro steps for this issue are wrong. The current thinking is that it happens when the app is updated, not when signing in/out (though it would also happen there, but that's expected since the setting isn't stored at the account-level). |
Bumped on Slack. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Muted setting resets on updating app. What is the root cause of that problem?After updating the app, I think backend sends Lines 80 to 102 in b00b9bc
retains information only those in the keys to preserve and resets the rest. As muting preference is within What changes do you think we should make in order to solve the problem?I tried the following. Then this muting setting does not get reset.
What alternative solutions did you explore? (Optional) |
@c3024 Thanks for the proposal! It does sound like a plausible RCA, but I'm wondering if this is true. Based on the comment here it sounds more like this should be triggered fairly rarely (the reports are of it happening "2 or 3 times a week"/"every day"): Lines 364 to 365 in 19d037b
Of course it's possible that an "emergency" reset is being triggered more often that we'd think, or even that it's being triggered by mistake on every update. @johnmlee101 Are you able to check on the BE to see what/if any Onyx keys get set (e.g. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-11. 🎊 For reference, here are some details about the assignees on this issue:
|
@jjcoffee / @c3024 @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
QQ, I see the PR hit staging last week. I'm on latest staging, desktop and..
That's the bug I was hoping would be fixed. I then signed out/in again and had the same results. Any idea why this isn't working? |
Somethings way broken here.
Turned mute back on again, followed the above steps and sounds happen on ALL the messages I send 😨 It's happening on production, web/Chrome too. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@mallenexpensify Was the mute all sounds setting turned off or just that you heard sounds? @c3024 has raised a PR with fixes for a couple of areas we missed where the loading of the new setting needed updating, but the toggle itself should have been displaying correctly. The only other thing I can think of is that you will have needed to re-enable the setting once the PR hit staging. |
I think that appearance of toggling action happening on visiting the page is not related to the issue of sounds playing even after muting. PR #52088 fixes the sounds problem. |
The payments were processed in Upwork now. @jjcoffee, do we need a regression test for this? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-18. 🎊 For reference, here are some details about the assignees on this issue:
|
@jjcoffee / @c3024 @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalTest:
Do we agree 👍 or 👎 |
All set! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @flodnv
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1726129231306989
Action Performed:
Expected Result:
Preference settings are saved for each platform and remain intact after the user signs out and signs back in.
Actual Result:
Preference settings not saved and toggles back to "OFF"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Recording.541.mp4
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @isabelastisserThe text was updated successfully, but these errors were encountered: