[HOLD for payment 2024-10-30] [$250] Use new ValidateCodeActionModal component in as many places as possible

[mountiny]

We are requiring a validation of the primary login using magic code in more actions now, and as such, we are repeating the component that handles such login. We created the ValidateCodeActionModal component, but there are some places like Copilot and verifying secondary login that does not use this modal.

Let's use this new component and remove any other usages that could lead people to reintroduce the wrong usage/ component.

Discussed here https://expensify.slack.com/archives/C01GTK53T8Q/p1726493895290119?thread_ts=1726483475.882029&cid=C01GTK53T8Q

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835679560526385104
• Upwork Job ID: 1835679560526385104
• Last Price Increase: 2024-09-16

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Current assignees @hungvu193 and @getusha are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021835679560526385104

[mountiny]

Hmm no upwork jobs

[melvin-bot]

Current assignees @hungvu193 and @getusha are eligible for the External assigner, not assigning anyone new.

[mountiny]

We will handle this with the bois

[hungvu193]

Any updates? @getusha 😄 . Let me know you if have any question.

[getusha]

@hungvu193 found some edge cases, i'll try to finalize today

[mountiny]

@hungvu193 @getusha what is your ETA for the PR?

[hungvu193]

Draft PR is up, #49445, I'm waiting for @getusha response.

[getusha]

I'll update today

[getusha]

Looks like we added another page #49230, i'll try to include that as well

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

All the deploy blockers were handled.

@arosiclair I think the plan is in general to use the ValidateCodeActionModal everywhere we will require the magic code verification, yes

[arosiclair]

Cool I will still fix the issue with forced log out while validating but let you guys refactor those Pay Someone and VBBA flows in this issue 🙏

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor: reuse ValidateCodeActionModal #49445

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @getusha requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193 / @getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@hungvu193 / @getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hungvu193 / @getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hungvu193 / @getusha] Determine if we should create a regression test for this bug.
• [@hungvu193 / @getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

This was a refactoring issue so not a bug to fix really, we do not need to create regression tests for this one and as such I dont think we need to fill in the checklist either

[hungvu193]

Are we going to create a follow up PR to address the countdown timer?

[jliexpensify]

Payment Summary

• C: @hungvu193 $250 (to be paid via ND)
• C+: @getusha $250 (to be paid via ND)

[getusha]

Are we going to create a follow up PR to address the countdown timer?

Working on this one, hopefully i'll raise a PR today or tomorrow.

[getusha]

As promised #51663

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Reviewer: @getusha owed $250 via NewDot

BugZero Checklist (@jliexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1835679560526385104/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jliexpensify]

@mountiny before I close this, are we also paying for the follow-up PR in this payment? Or will that be handled separately?

If so, is that amount also $250?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

We can pay it here, there was no new issue for that.

I would say that we should have included that in the first pr so I would vote for partial reward for the second one so $375 total each for @hungvu193 and for @getusha

[getusha]

I would say that we should have included that in the first pr so I would vote for partial reward for the second one so $375 total each for @hungvu193 and for @getusha

This actually wasn't implemented in BaseValidateCodeForm before except the sign in page, but the amount sounds reasonable to me 👍

[hungvu193]

LGTM as well 😄