[HOLD for payment 2024-11-01] [$500] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

lanitochka17 · 2024-09-28T14:38:16Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N/A Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

User is logged in to two devices
Workspace has tags

Go to staging.new.expensify.com
[Device A] Go to workspace chat
[Device A] Click + > Submit expense > Manual
[Device A] Proceed to confirmation page and click Tag
[Device B] Go to workspace settings > Tags
[Device B] Disable all tags
[Device A] Click Edit tags
[Device A] Click Settings > Custom tag name

Expected Result:

The report in the background will remain after clicking Custom tag name

Actual Result:

The report in the background changes to Tags page after clicking Custom tag name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6617841_1727469118066.20240928_042600.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021840631550279932147
Upwork Job ID: 1840631550279932147
Last Price Increase: 2024-10-10
Automatic offers:

paultsimura | Reviewer | 104272735

Issue Owner

Current Issue Owner: @Christinadobrzyn

melvin-bot · 2024-09-28T14:38:29Z

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions · 2024-09-28T14:38:31Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2024-09-28T14:38:31Z

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

roryabraham · 2024-09-29T00:52:54Z

Looks pretty NAB to me

NJ-2020 · 2024-09-29T05:59:36Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - Background report changes to Tags page after clicking Custom tag name in RHP

What is the root cause of that problem?

We're not passing the backTo param when navigating to the Custom tag name page

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Line 85 in 3047c1b

    
           onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight))}

App/src/ROUTES.ts

Lines 847 to 850 in 3047c1b

    
           WORKSPACE_EDIT_TAGS: { 
        
               route: 'settings/workspaces/:policyID/tags/:orderWeight/edit', 
        
               getRoute: (policyID: string, orderWeight: number) => `settings/workspaces/${policyID}/tags/${orderWeight}/edit` as const, 
        
           },

And same when navigating to the Settings page

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 174 to 176 in 3047c1b

    
           const navigateToTagsSettings = () => { 
        
               Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID)); 
        
           };

App/src/ROUTES.ts

Lines 843 to 846 in 3047c1b

    
           WORKSPACE_TAGS_SETTINGS: { 
        
               route: 'settings/workspaces/:policyID/tags/settings', 
        
               getRoute: (policyID: string) => `settings/workspaces/${policyID}/tags/settings` as const, 
        
           },

What changes do you think we should make in order to solve the problem?

We can add the backTo param inside the getRoute function and pass the backTo param by using route.params.backTo

WORKSPACE_TAGS_SETTINGS: {
    route: 'settings/workspaces/:policyID/tags/settings',
    getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}/tags/settings` as const, backTo),
},
WORKSPACE_EDIT_TAGS: {
    route: 'settings/workspaces/:policyID/tags/:orderWeight/edit',
    getRoute: (policyID: string, orderWeight: number, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}/tags/${orderWeight}/edit` as const, backTo),
},

WorkspaceTagsPage.tsx when navigating to Settings page

const backTo = route.params.backTo;
const navigateToTagsSettings = () => {
    Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID, backTo));
};

// ...types for route.params
[SCREENS.WORKSPACE.TAGS]: {
    policyID: string;
    backTo?: Routes;
};

And same for WorkspaceTagsSettingsPage when navigating to Custom tag name page

<MenuItemWithTopDescription
    title={policyTagLists[0]?.name}
    description={translate(`workspace.tags.customTagName`)}
    onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight, backTo))}
    shouldShowRightIcon
/>

Result

Screen.Recording.2024-09-28.at.22.57.04.mov

What alternative solutions did you explore? (Optional)

Christinadobrzyn · 2024-09-30T02:57:12Z

What does NAB mean?

NJ-2020 · 2024-09-30T03:06:52Z

@Christinadobrzyn NAB stands for Not a blocker

truph01 · 2024-09-30T05:26:09Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report in the background changes to Tags page after clicking Custom tag name

What is the root cause of that problem?

We have logic to push a new full screen navigator to the stacks if the RHN is in FULL_SCREEN_TO_RHP_MAPPING list:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 146 to 153 in d187665

    
           // Check for FullScreenNavigator 
        
           for (const [fullScreenName, RHPNames] of Object.entries(FULL_SCREEN_TO_RHP_MAPPING)) { 
        
               if (RHPNames.includes(route.name)) { 
        
                   const paramsFromRoute = getParamsFromRoute(fullScreenName); 
        
                   return createFullScreenNavigator({name: fullScreenName as FullScreenName, params: pick(route.params, paramsFromRoute)}); 
        
               } 
        
           }

When we click on "Custom tag name", the custom tag name screen is in FULL_SCREEN_TO_RHP_MAPPING:

App/src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts

Line 134 in d187665

SCREENS.WORKSPACE.TAGS_EDIT,

hence we push a new full screen navigator to stacks.

What changes do you think we should make in order to solve the problem?

In general, we should add a backTo param to the route when we click "Custom tag name". With this, in:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Line 112 in d187665

    
           function getMatchingRootRouteForRHPRoute(route: NavigationPartialRoute): NavigationPartialRoute<CentralPaneName | typeof NAVIGATORS.FULL_SCREEN_NAVIGATOR> | undefined {

logic:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 113 to 114 in d187665

    
           // Check for backTo param. One screen with different backTo value may need diferent screens visible under the overlay. 
        
           if (route.params && 'backTo' in route.params && typeof route.params.backTo === 'string') {

is called instead of pushing a new full screen navigator to stacks:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 146 to 147 in d187665

    
           // Check for FullScreenNavigator 
        
           for (const [fullScreenName, RHPNames] of Object.entries(FULL_SCREEN_TO_RHP_MAPPING)) {

In detail:
First, update the getRoute function so that it can receive the additional backTo param:

App/src/ROUTES.ts

Lines 843 to 850 in d187665

    
           WORKSPACE_TAGS_SETTINGS: { 
        
               route: 'settings/workspaces/:policyID/tags/settings', 
        
               getRoute: (policyID: string) => `settings/workspaces/${policyID}/tags/settings` as const, 
        
           }, 
        
           WORKSPACE_EDIT_TAGS: { 
        
               route: 'settings/workspaces/:policyID/tags/:orderWeight/edit', 
        
               getRoute: (policyID: string, orderWeight: number) => `settings/workspaces/${policyID}/tags/${orderWeight}/edit` as const, 
        
           },

Then, update:

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 175 in d187665

Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID));

    const navigateToTagsSettings = () => {
        Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID, Navigation.getActiveRoute()));
    };

and:

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Line 85 in d187665

    
           onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight))}

                        onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight, Navigation.getActiveRoute()))}

It will add new backTo param to the route when we click "Custom tag name"

What alternative solutions did you explore? (Optional)

Christinadobrzyn · 2024-09-30T05:55:18Z

Ah thanks @NJ-2020! That makes sense. Given that, I think this can be external so adding the label.

melvin-bot · 2024-09-30T05:55:35Z

Job added to Upwork: https://www.upwork.com/jobs/~021840631550279932147

melvin-bot · 2024-09-30T05:55:39Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

melvin-bot · 2024-10-10T17:37:47Z

Upwork job price has been updated to $500

stitesExpensify · 2024-10-10T17:37:56Z

Doubling bounty because we are fixing 2 extra bugs

Christinadobrzyn · 2024-10-15T08:45:53Z

Just an update for melvin that we're working on the PRs

twilight2294 · 2024-10-15T17:38:03Z

@stitesExpensify the PR is ready for your review

Christinadobrzyn · 2024-10-22T06:16:18Z

PR in the works! #50416

melvin-bot · 2024-10-25T02:19:31Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-10-25T02:19:35Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Background report changes to Tags page after clicking Custom tag name in RHP #50416

If no regressions arise, payment will be issued on 2024-11-01. 🎊

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment automatic offer (Reviewer)
@twilight2294 requires payment (Needs manual offer from BZ)

melvin-bot · 2024-10-25T02:19:37Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@paultsimura] The PR that introduced the bug has been identified. Link to the PR:
[@paultsimura] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@paultsimura] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@paultsimura] Determine if we should create a regression test for this bug.
[@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/441268

Christinadobrzyn · 2024-11-01T02:07:29Z

@paultsimura Do we need a regression for this?

Payouts due:

Contributor: $500 @twilight2294 (Upwork offer - https://www.upwork.com/nx/wm/offer/104689344)
Reviewer: $500 @paultsimura (Upwork offer - https://www.upwork.com/nx/wm/offer/104272735)

twilight2294 · 2024-11-01T04:21:53Z

I am paid via Upwork, can you please send me an offer

…

On Fri, Nov 1, 2024 at 7:37 AM Christina Dobrzynski < ***@***.***> wrote: @paultsimura <https://github.com/paultsimura> Do we need a regression for this? Payouts due: - Contributor: $500 @twilight2294 <https://github.com/twilight2294> (feel free to send a request to NewDot) - Reviewer: $500 @paultsimura <https://github.com/paultsimura> (Upwork offer - https://www.upwork.com/nx/wm/offer/104272735) — Reply to this email directly, view it on GitHub <#49883 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BLXFUO2H4T2KI4Z3U2DEQO3Z6LO7RAVCNFSM6AAAAABPAVY3U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRGE2TQMJQGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Christinadobrzyn · 2024-11-01T05:31:38Z

Ah thanks for letting me know @twilight2294 - can you please accept the offer here

twilight2294 · 2024-11-01T05:33:46Z

I’ve accepted the offer, thank you so much

…

On Fri, Nov 1, 2024 at 11:02 AM Christina Dobrzynski < ***@***.***> wrote: Ah thanks for letting me know @twilight2294 <https://github.com/twilight2294> - can you please accept the offer here <https://www.upwork.com/nx/wm/offer/104689344> — Reply to this email directly, view it on GitHub <#49883 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BLXFUO2447ATSA4K7XCLD2LZ6MG5DAVCNFSM6AAAAABPAVY3U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRGMZDCMZWGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

paultsimura · 2024-11-01T11:15:38Z

The PR that introduced the bug has been identified. Link to the PR: Fix - RHN throws error if tags are deleted by admin while member is selecting #49506
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49506/files#r1825710683
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

The user is logged in on two devices
Workspace has tags

Test:

[Device A] Go to a workspace chat
[Device A] Click + > Submit expense > Manual
[Device A] Proceed to the confirmation page and click Tag
[Device B] Go to the workspace settings > Tags
[Device B] Disable all tags
[Device A] Click Edit tags
[Device A] Click Settings > Custom tag name
Verify the report in the background remains unchanged

Do we agree 👍 or 👎

Christinadobrzyn · 2024-11-04T02:38:47Z

Regression test - https://github.com/Expensify/Expensify/issues/441268

Paid out based on payment summary - #49883 (comment)

But I just checked and there was discussion after the PR went to production- is there a regression that we need to track for this? @twilight2294 @paultsimura

paultsimura · 2024-11-04T08:37:06Z

Thank you @Christinadobrzyn. That one bug was related to a super edge case that is not even possible to reproduce fully in ND as the multilevel tags are not currently supported, therefore it was missed while testing.
IMO, it wouldn't be quite fair to apply the 50% penalty for such a case in the 30-files PR that covers 10+ other navigational scenarios. But if you think otherwise, let's adjust the bounty here.

Christinadobrzyn · 2024-11-05T03:04:10Z

hi @paultsimura thank you for the additional information. I think it sounds fair to keep the payment as is.

Closing this as complete!

melvin-bot · 2024-11-05T03:04:13Z

@stitesExpensify @Christinadobrzyn Be sure to fill out the Contact List!

paultsimura · 2024-11-05T09:04:30Z

Thank you @Christinadobrzyn.

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Sep 28, 2024

melvin-bot bot assigned Christinadobrzyn Sep 28, 2024

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 28, 2024

melvin-bot bot assigned stitesExpensify Sep 28, 2024

github-actions bot mentioned this issue Sep 28, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

roryabraham added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Sep 29, 2024

Christinadobrzyn added this to [#whatsnext] #expense Sep 30, 2024

Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Sep 30, 2024

melvin-bot bot changed the title ~~Tags - Background report changes to Tags page after clicking Custom tag name in RHP~~ [$250] Tags - Background report changes to Tags page after clicking Custom tag name in RHP Sep 30, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 30, 2024

melvin-bot bot assigned paultsimura Sep 30, 2024

dylanexpensify moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Oct 18, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 25, 2024

melvin-bot bot changed the title ~~[$500] Tags - Background report changes to Tags page after clicking Custom tag name in RHP~~ [HOLD for payment 2024-11-01] [$500] Tags - Background report changes to Tags page after clicking Custom tag name in RHP Oct 25, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Oct 25, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 31, 2024

melvin-bot bot added the Overdue label Nov 4, 2024

melvin-bot bot removed the Overdue label Nov 4, 2024

Christinadobrzyn closed this as completed Nov 5, 2024

github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in [#whatsnext] #expense Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-11-01] [$500] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

[HOLD for payment 2024-11-01] [$500] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

lanitochka17 commented Sep 28, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 28, 2024

github-actions bot commented Sep 28, 2024

melvin-bot bot commented Sep 28, 2024

roryabraham commented Sep 29, 2024

NJ-2020 commented Sep 29, 2024

Christinadobrzyn commented Sep 30, 2024 •

edited

Loading

NJ-2020 commented Sep 30, 2024

truph01 commented Sep 30, 2024

Christinadobrzyn commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

melvin-bot bot commented Oct 10, 2024

stitesExpensify commented Oct 10, 2024

Christinadobrzyn commented Oct 15, 2024

twilight2294 commented Oct 15, 2024

Christinadobrzyn commented Oct 22, 2024

melvin-bot bot commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024 •

edited by Christinadobrzyn

Loading

Christinadobrzyn commented Nov 1, 2024 •

edited

Loading

twilight2294 commented Nov 1, 2024 via email

Christinadobrzyn commented Nov 1, 2024

twilight2294 commented Nov 1, 2024 via email

paultsimura commented Nov 1, 2024

Christinadobrzyn commented Nov 4, 2024

paultsimura commented Nov 4, 2024

Christinadobrzyn commented Nov 5, 2024

melvin-bot bot commented Nov 5, 2024

paultsimura commented Nov 5, 2024

[HOLD for payment 2024-11-01] [$500] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

[HOLD for payment 2024-11-01] [$500] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

Comments

lanitochka17 commented Sep 28, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 28, 2024

github-actions bot commented Sep 28, 2024

melvin-bot bot commented Sep 28, 2024

roryabraham commented Sep 29, 2024

NJ-2020 commented Sep 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented Sep 30, 2024 • edited Loading

NJ-2020 commented Sep 30, 2024

truph01 commented Sep 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

melvin-bot bot commented Oct 10, 2024

stitesExpensify commented Oct 10, 2024

Christinadobrzyn commented Oct 15, 2024

twilight2294 commented Oct 15, 2024

Christinadobrzyn commented Oct 22, 2024

melvin-bot bot commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024 • edited by Christinadobrzyn Loading

Christinadobrzyn commented Nov 1, 2024 • edited Loading

twilight2294 commented Nov 1, 2024 via email

Christinadobrzyn commented Nov 1, 2024

twilight2294 commented Nov 1, 2024 via email

paultsimura commented Nov 1, 2024

Regression Test Proposal

Christinadobrzyn commented Nov 4, 2024

paultsimura commented Nov 4, 2024

Christinadobrzyn commented Nov 5, 2024

melvin-bot bot commented Nov 5, 2024

paultsimura commented Nov 5, 2024

lanitochka17 commented Sep 28, 2024 •

edited by melvin-bot bot

Loading

Christinadobrzyn commented Sep 30, 2024 •

edited

Loading

melvin-bot bot commented Oct 25, 2024 •

edited by Christinadobrzyn

Loading

Christinadobrzyn commented Nov 1, 2024 •

edited

Loading