[HOLD for payment 2021-11-04] LHN - Bottom of the conversation list is cut off

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Scroll to the bottom of the LHN

Expected Result:

Conversation list should be rendered all the way to the bottom

Actual Result:

Bottom of the conversation list is cut off .

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.0.91-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on GitHub

---

From @shawnborton https://expensify.slack.com/archives/C01GTK53T8Q/p1630487034256700

The bottom of the chats list view is cut off on iOS, likely because of the bottom home bar. I think the list view should extend to the bottom edge of the screen below the home bar, will share a screenshot of how other apps do it in thread

[MelvinBot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[PrashantMangukiya]

I just tested in v1.0.91-3 on iOS simulator. Bottom margin there and I can scroll up to end properly. Not tested yet in real device so not sure about it. Debug purpose I also set light green color, so we can see bottom margin clearly.

Wandering that someone had already fixed it in recent version? or This problem shows on real device only?

Attached is the iOS simulator screenshot.

[flodnv]

Sorry about that @PrashantMangukiya I jumped the gun too quickly. I was testing on my physical Android device and got sidetracked. Indeed, I do not experience this bug (Pixel 3). I am also on 1.0.91-0... @isagoico which device did you test on?

[isagoico]

I'm also not able to reproduce this on my Android device but @parasharrajat mentioned in the thread he is able to reproduce in his. @parasharrajat Can you please share your device information?

[parasharrajat]

@isagoico I don't see this issue on my Android device anymore.

[jboniface]

It sounds like this issue isn't validated to be happening any longer. I am removing External and unassigning myself. Please close the issue if you are confident the issue is no longer occurring, or re-add the External label if you become confident that it is occurring.

[isagoico]

@shawnborton are you still able to reproduce this issue in your iOS?

[shawnborton]

Still happening to me on my physical device.

…

On Thu, Sep 2, 2021 at 3:00 PM Isabella Goicoechea ***@***.***> wrote: @shawnborton <https://github.com/shawnborton> are you still able to reproduce this issue in your iOS? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5005 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARWH5U3L6EIPMBLSLV2VXTT77JWPANCNFSM5DHWLQLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[MelvinBot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

10 days overdue. I'm getting more depressed than Marvin.

[MelvinBot]

12 days overdue now... This issue's end is nigh!

[shawnborton]

Sounds great, adding External now.

[MelvinBot]

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Posted - https://www.upwork.com/jobs/~01ac27bbc27f74d29a
@iwiznia can you review what @parasharrajat posted above? #5005 (comment)

[iwiznia]

So, to clarify. We will revert this and this issue would go away, but bring back the old issue?
If so, which issue do we think is worse? Seems the other one, right? If so, even though I agree the previous fix is a hack and not a real fix, I don't think we should revert it without fixing the other issue.

[parasharrajat]

Yeah, I agree @iwiznia. But I don't think that issue is reproducible anymore. I can create a PR and we can ask the tester to test that issue. IF that exists, I can try to fix that one as well and if we end up putting the same code as that PR, you can simply revert my PR. (I would request a bonus for that as that is basically extra work)

But I think there are better solutions than that for the scrolling issue.

[iwiznia]

Sounds like a good plan to me. @mallenexpensify can you hire @parasharrajat please?

[mallenexpensify]

Hired @parasharrajat in Upwork

[mallenexpensify]

n6-hold is lifted, label removed! PR is waiting on review from @iwiznia

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.10-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: list is cut off at bottom in LHN #5891

If no regressions arise, payment will be issued on 2021-11-04. 🎊

[parasharrajat]

Ping for

[iwiznia]

@mallenexpensify that's for you

[mallenexpensify]

Paid in Upwork, inc. the $250 bonus for n6 hold, canceled job, now closing this (need a emoji for this... 🌂?)