[Awaiting checklist] [$250] mWeb/Chrome - Workspace - Invite button hidden behind keypad

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch both mweb and Android
2. Go to workspace -- invite members
3. Go offline and note no internet connection above
4. Select a member and tap next

Expected Result:

In mweb and Android, in offline inviting members, invite button should display in same way

Actual Result:

In mweb, invite button hidden behind keypad but in Android above keypad

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622134_1727876595223.Screenrecorder-2024-10-02-19-02-53-462_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841522414660630574
• Upwork Job ID: 1841522414660630574
• Last Price Increase: 2024-10-09
• Automatic offers:
• Nodebrute | Contributor | 104343060

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-10-02 15:35:19 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite button hidden behind keypad

What is the root cause of that problem?

We are not adding shouldEnableMaxHeight

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in 3946b22

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	testID={WorkspaceInviteMessagePage.displayName}
	>

because of which it is not using it's 100 height%

Whether to use the maxHeight (true) or use the 100% of the height (false)

What changes do you think we should make in order to solve the problem?

We should add shouldEnableMaxHeight

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in 3946b22

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	testID={WorkspaceInviteMessagePage.displayName}
	>

We should check for other places too where we have this issue. Other minor styling can be adjusted in the PR.

We have another issue here when we navigate from InviteMembersPage we can see that header is missing and there's a white space under the privacy. This is the only form page where we have this issue. To fix that we can use here

    const viewportOffsetTop = useViewportOffsetTop()

And then we can pass it as styles in screenWrapper here. We are also doing the same here

                style={{marginTop:viewportOffsetTop}}

Before

Screen.Recording.2024-10-02.at.11.37.17.PM.mov

After

Screen.Recording.2024-10-02.at.11.35.45.PM.mov

What alternative solutions did you explore? (Optional)

Or we can pass shouldEnableMaxHeight={DeviceCapabilities.canUseTouchScreen()}

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in 3946b22

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	testID={WorkspaceInviteMessagePage.displayName}
	>

Optional: To fix extra padding under the form we can pass shouldEnableKeyboardAvoidingView={false} here

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in c301698

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	testID={WorkspaceInviteMessagePage.displayName}
	>

[Nodebrute]

Proposal Updated
Added alternate solution

[twisterdotcom]

This isn't a problem I can recreate. I'd wager this is just due to the keyboard being used.

https://drive.google.com/file/d/1GPzlPbzYtM-eOsDgVXEyXGn3Io1YkOMF/view?usp=sharing

[Nodebrute]

@twisterdotcom I am able to repro this on latest main and it's very visible

Ios:mweb safari

Screen.Recording.2024-10-02.at.9.39.18.PM.mov

[twisterdotcom]

Ahh @Nodebrute are you on iOS there? I didn't test that, it wasn't included in the report. Let me double check then.

[twisterdotcom]

trim.E4224B6E-3D85-4A84-89B7-5BAEA7462262.MOV

[twisterdotcom]

Okay agreed. This has nothing to do with being offline/online either though. It just occurs regardless. Not sure what all the bottom padding is for either when you scroll with the keyboard in view. Can we fix that too @Nodebrute?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841522414660630574

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2023-10-08T14:32:00Z.

Proposal


Please re-state the problem that we are trying to solve in this issue.

mWeb/Chrome - Workspace - Invite button hidden behind keypad

What is the root cause of that problem?

• We aren't passing the shouldEnableMaxHeight prop.
  

  App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

  Lines 131 to 134 in 66d1025

  	<ScreenWrapper
  	includeSafeAreaPaddingBottom={false}
  	testID={WorkspaceInviteMessagePage.displayName}
  	>

• The privacy link is render as footerContent which is rendered below the submit button.
  

  App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

  Lines 151 to 163 in 66d1025

  	footerContent={
  	<PressableWithoutFeedback
  	onPress={openPrivacyURL}
  	role={CONST.ROLE.LINK}
  	accessibilityLabel={translate('common.privacy')}
  	href={CONST.PRIVACY_URL}
  	style={[styles.mv2, styles.alignSelfStart]}
  	>
  	<View style={[styles.flexRow]}>
  	<Text style={[styles.mr1, styles.label, styles.link]}>{translate('common.privacy')}</Text>
  	</View>
  	</PressableWithoutFeedback>
  	}

What changes do you think we should make in order to solve the problem?


• We should pass shouldEnableMaxHeight prop.
• Then we should remove the footerContent prop and render the component passed to footerContent below the input.
• Or we can render the privacy link after this view element.
• Minor style changes can be done during the PR phase.

What alternative solutions did you explore? (Optional)

• We can pass submitFlexEnabled={false} to FormProvider.
• Add styles.flex1 here.
• Add the privacy link element here.
• Add styles.mtAuto to the privacy link parent.

Result

[Nodebrute]

Proposal Updated
Added fix for missing header and bottom space

[Krishna2323]

Proposal Updtated

• Minor update to alternative solution.

[Nodebrute]

Proposal updated
added a reference

[eh2077]

Reviewing proposals

[eh2077]

@Krishna2323 Thanks for your proposal!

The privacy link is render as footerContent which is rendered below the submit button.

Does this cause the Invite button hidden issue? Or it's another issue found when investigating the issue?

[Nodebrute]

@eh2077 The privacy link is unrelated to the hidden invite button issue. I removed the link as a test, but the problem with the invite button still persists.

[eh2077]

I think we should go with @Nodebrute 's proposal as they're the first to point out the root cause and suggested a fix.

Setting shouldEnableMaxHeight property for ScreenWrapper fixes the issue.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• workspace invite submit #50581

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @Nodebrute requires payment automatic offer (Contributor)
• @eh2077 requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eh2077] Determine if we should create a regression test for this bug.
• [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Payment Summary:

• @Nodebrute paid $250 here (Contributor)
• @eh2077 paid $250 via NewDot Manual Request

[melvin-bot]

@twisterdotcom @aldo-expensify @Nodebrute @eh2077 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!