-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-29] [$250] LHN - Chat that contains only task disappears from LHN #50478
Comments
Triggered auto assignment to @VictoriaExpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
Lines 220 to 233 in 8db6347
like we did when creating a new comment: App/src/libs/actions/Report.ts Lines 492 to 498 in 8db6347
so the chat disappears from LHN: Line 141 in 8db6347
until the API CreateTask is called succesfully. What changes do you think we should make in order to solve the problem?Add a logic to update notificationPreference to place:
What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
I am unable to reproduce this on the latest main. @mkzie2, could you please list all the steps to reproduce this issue? Screen.Recording.2024-10-09.at.1.55.03.AM.mov |
Agree this is an isue and we should fix it |
Job added to Upwork: https://www.upwork.com/jobs/~021843919279680546076 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
@mkzie2's RCA and solution looks good to me Link to proposal #50478 (comment) 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Thanks for the review @hoangzinh, assigning @mkzie2 🚀 |
📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @mkzie2 You have been assigned to this job! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-29. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Hi @mkzie2 - can you please accept this offer so I can process your payment - https://www.upwork.com/nx/wm/offer/104636304 @hoangzinh can you please complete the checklist Thank you! |
@VictoriaExpensify I accepted the offer, thanks |
Regression Test ProposalWeb/Desktop
mWeb/Native
Do we agree 👍 or 👎 |
BugZero Checklist:
|
Thanks @hoangzinh - raised request to add ^^ to testrail - https://github.com/Expensify/Expensify/issues/440023 |
Payment summary: |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.46-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+bg@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Chat that contains only task does not disappear from from LHN
Actual Result:
Chat that contains only task disappears from LHN when navigating to other chats
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6628563_1728407429433.Screen_Recording_2024-10-08_at_6.42.38_in_the_evening.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @VictoriaExpensifyThe text was updated successfully, but these errors were encountered: