[HOLD for payment 2024-12-16] Copilot - The bottom line of the pop-up modal is not visible

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Security > Add copilot.
3. Add a copilot.
4. Click 3-dot menu next to the copilot.

Expected Result:

The bottom line of the pop-up modal should be visible.

Actual Result:

The bottom line of the pop-up modal is not visible.
This issue is not reproducible when the display is very zoomed out (wide screen).

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6634876_1728967955399.20241015_125044.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

cc @dangrous @rushatgabhane @allgandalf looks related to #47984

[marcaaron]

Pre-req: be on copilot beta.

I think this can be demoted.

[marcaaron]

But please address before removing the beta?

[dangrous]

@rushatgabhane can you put up a PR for this one? Would be great to get it sorted by the end of the week!

[dangrous]

@rushatgabhane do you have time for this one or should we open it up? We just have to rejigger this section I think, probably including the windowHeight and adding a Math.min() in there in some way. I think there's also some left/right wonkiness that we should look at.

I realize you took this code from some other places in the app that use similar behavior but for whatever reason it doesn't seem to fit here (maybe doesn't there either, who knows).

App/src/pages/settings/Security/SecuritySettingsPage.tsx

Lines 74 to 80 in a8e1b13

	setAnchorPosition({
	anchorPositionTop: position.top + position.height - variables.bankAccountActionPopoverTopSpacing,
	// We want the position to be 23px to the right of the left border
	anchorPositionRight: windowWidth - position.right + variables.bankAccountActionPopoverRightSpacing,
	anchorPositionHorizontal: position.x + variables.addBankAccountLeftSpacing,
	anchorPositionVertical: position.y,
	});

[allgandalf]

not overdue, waiting for @rushatgabhane 🙇

[melvin-bot]

@dangrous, @slafortune, @rushatgabhane, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dangrous]

PR in review! we just have one improvement to make to the design (coloring the icon) and then we'll be good to merge

[melvin-bot]

@dangrous, @slafortune, @rushatgabhane, @allgandalf Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@dangrous, @slafortune, @rushatgabhane, @allgandalf Still overdue 6 days?! Let's take care of this!

[dangrous]

PR in revierw

[allgandalf]

Lets make it weekly until the PR hits production @dangrous

[melvin-bot]

@dangrous, @slafortune, @rushatgabhane, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@dangrous, @slafortune, @rushatgabhane, @allgandalf Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@dangrous, @slafortune, @rushatgabhane, @allgandalf Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@dangrous, @slafortune, @rushatgabhane, @allgandalf 12 days overdue now... This issue's end is nigh!

[dangrous]

Let's get this done this week!

[slafortune]

Still waiting on PR

[allgandalf]

PR approved ✅

[allgandalf]

PR merged !!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix popover position for copilot popup #51204

If no regressions arise, payment will be issued on 2024-12-16. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@rushatgabhane / @allgandalf @slafortune @rushatgabhane / @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@slafortune)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[slafortune]

Offer sent here @allgandalf